* [PATCH 1/2] pinctrl: rockchip: Remove of_match_ptr macro for DT only driver
@ 2013-08-23 6:27 Axel Lin
2013-08-23 6:28 ` [PATCH 2/2] pinctrl: rockchip: Remove non-reachable break statement Axel Lin
2013-08-28 11:16 ` [PATCH 1/2] pinctrl: rockchip: Remove of_match_ptr macro for DT only driver Linus Walleij
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2013-08-23 6:27 UTC (permalink / raw)
To: Linus Walleij; +Cc: Heiko Stübner, linux-kernel
This is a DT only driver and rockchip_pinctrl_dt_match is always compiled in.
Thus remove of_match_ptr macro.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pinctrl/pinctrl-rockchip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index 64ad0c0..7eb1249 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -1365,7 +1365,7 @@ static struct platform_driver rockchip_pinctrl_driver = {
.driver = {
.name = "rockchip-pinctrl",
.owner = THIS_MODULE,
- .of_match_table = of_match_ptr(rockchip_pinctrl_dt_match),
+ .of_match_table = rockchip_pinctrl_dt_match,
},
};
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] pinctrl: rockchip: Remove non-reachable break statement
2013-08-23 6:27 [PATCH 1/2] pinctrl: rockchip: Remove of_match_ptr macro for DT only driver Axel Lin
@ 2013-08-23 6:28 ` Axel Lin
2013-08-28 11:17 ` Linus Walleij
2013-08-28 11:16 ` [PATCH 1/2] pinctrl: rockchip: Remove of_match_ptr macro for DT only driver Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: Axel Lin @ 2013-08-23 6:28 UTC (permalink / raw)
To: Linus Walleij; +Cc: Heiko Stübner, linux-kernel
The break statement after return is non-reachable, remove them.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pinctrl/pinctrl-rockchip.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-rockchip.c b/drivers/pinctrl/pinctrl-rockchip.c
index 7eb1249..319a64a 100644
--- a/drivers/pinctrl/pinctrl-rockchip.c
+++ b/drivers/pinctrl/pinctrl-rockchip.c
@@ -585,7 +585,6 @@ static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
switch (param) {
case PIN_CONFIG_BIAS_DISABLE:
return rockchip_set_pull(bank, pin - bank->pin_base, param);
- break;
case PIN_CONFIG_BIAS_PULL_UP:
case PIN_CONFIG_BIAS_PULL_DOWN:
case PIN_CONFIG_BIAS_PULL_PIN_DEFAULT:
@@ -596,10 +595,8 @@ static int rockchip_pinconf_set(struct pinctrl_dev *pctldev, unsigned int pin,
return -EINVAL;
return rockchip_set_pull(bank, pin - bank->pin_base, param);
- break;
default:
return -ENOTSUPP;
- break;
}
return 0;
@@ -633,7 +630,6 @@ static int rockchip_pinconf_get(struct pinctrl_dev *pctldev, unsigned int pin,
break;
default:
return -ENOTSUPP;
- break;
}
return 0;
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] pinctrl: rockchip: Remove of_match_ptr macro for DT only driver
2013-08-23 6:27 [PATCH 1/2] pinctrl: rockchip: Remove of_match_ptr macro for DT only driver Axel Lin
2013-08-23 6:28 ` [PATCH 2/2] pinctrl: rockchip: Remove non-reachable break statement Axel Lin
@ 2013-08-28 11:16 ` Linus Walleij
1 sibling, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2013-08-28 11:16 UTC (permalink / raw)
To: Axel Lin; +Cc: Heiko Stübner, linux-kernel@vger.kernel.org
On Fri, Aug 23, 2013 at 8:27 AM, Axel Lin <axel.lin@ingics.com> wrote:
> This is a DT only driver and rockchip_pinctrl_dt_match is always compiled in.
> Thus remove of_match_ptr macro.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Patch applied, thanks!
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-08-28 11:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-23 6:27 [PATCH 1/2] pinctrl: rockchip: Remove of_match_ptr macro for DT only driver Axel Lin
2013-08-23 6:28 ` [PATCH 2/2] pinctrl: rockchip: Remove non-reachable break statement Axel Lin
2013-08-28 11:17 ` Linus Walleij
2013-08-28 11:16 ` [PATCH 1/2] pinctrl: rockchip: Remove of_match_ptr macro for DT only driver Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.