* [PATCH] vb2: Add debug print for the output buffer planes lengths checks
@ 2013-08-26 15:47 Sylwester Nawrocki
2013-08-27 8:51 ` Laurent Pinchart
2013-08-27 8:59 ` Marek Szyprowski
0 siblings, 2 replies; 3+ messages in thread
From: Sylwester Nawrocki @ 2013-08-26 15:47 UTC (permalink / raw)
To: linux-media
Cc: m.szyprowski, pawel, hans.verkuil, laurent.pinchart, m.chehab,
Sylwester Nawrocki, Kyungmin Park
Add debug print so it's easier to find any errors resulting from
the planes' configuration checks added in commit 8023ed09cb278004a2
"videobuf2-core: Verify planes lengths for output buffers".
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
drivers/media/v4l2-core/videobuf2-core.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
index de0e87f..6bffc96 100644
--- a/drivers/media/v4l2-core/videobuf2-core.c
+++ b/drivers/media/v4l2-core/videobuf2-core.c
@@ -1205,8 +1205,11 @@ static int __buf_prepare(struct vb2_buffer *vb, const struct v4l2_buffer *b)
int ret;
ret = __verify_length(vb, b);
- if (ret < 0)
+ if (ret < 0) {
+ dprintk(1, "%s(): plane parameters verification failed: %d\n",
+ __func__, ret);
return ret;
+ }
switch (q->memory) {
case V4L2_MEMORY_MMAP:
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] vb2: Add debug print for the output buffer planes lengths checks
2013-08-26 15:47 [PATCH] vb2: Add debug print for the output buffer planes lengths checks Sylwester Nawrocki
@ 2013-08-27 8:51 ` Laurent Pinchart
2013-08-27 8:59 ` Marek Szyprowski
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2013-08-27 8:51 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: linux-media, m.szyprowski, pawel, hans.verkuil, m.chehab,
Kyungmin Park
Hi Sylwester,
Thank you for the patch.
On Monday 26 August 2013 17:47:53 Sylwester Nawrocki wrote:
> Add debug print so it's easier to find any errors resulting from
> the planes' configuration checks added in commit 8023ed09cb278004a2
> "videobuf2-core: Verify planes lengths for output buffers".
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/v4l2-core/videobuf2-core.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/videobuf2-core.c
> b/drivers/media/v4l2-core/videobuf2-core.c index de0e87f..6bffc96 100644
> --- a/drivers/media/v4l2-core/videobuf2-core.c
> +++ b/drivers/media/v4l2-core/videobuf2-core.c
> @@ -1205,8 +1205,11 @@ static int __buf_prepare(struct vb2_buffer *vb, const
> struct v4l2_buffer *b) int ret;
>
> ret = __verify_length(vb, b);
> - if (ret < 0)
> + if (ret < 0) {
> + dprintk(1, "%s(): plane parameters verification failed: %d\n",
> + __func__, ret);
> return ret;
> + }
>
> switch (q->memory) {
> case V4L2_MEMORY_MMAP:
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] vb2: Add debug print for the output buffer planes lengths checks
2013-08-26 15:47 [PATCH] vb2: Add debug print for the output buffer planes lengths checks Sylwester Nawrocki
2013-08-27 8:51 ` Laurent Pinchart
@ 2013-08-27 8:59 ` Marek Szyprowski
1 sibling, 0 replies; 3+ messages in thread
From: Marek Szyprowski @ 2013-08-27 8:59 UTC (permalink / raw)
To: Sylwester Nawrocki
Cc: linux-media, pawel, hans.verkuil, laurent.pinchart, m.chehab,
Kyungmin Park
Hello,
On 8/26/2013 5:47 PM, Sylwester Nawrocki wrote:
> Add debug print so it's easier to find any errors resulting from
> the planes' configuration checks added in commit 8023ed09cb278004a2
> "videobuf2-core: Verify planes lengths for output buffers".
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/media/v4l2-core/videobuf2-core.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
> index de0e87f..6bffc96 100644
> --- a/drivers/media/v4l2-core/videobuf2-core.c
> +++ b/drivers/media/v4l2-core/videobuf2-core.c
> @@ -1205,8 +1205,11 @@ static int __buf_prepare(struct vb2_buffer *vb, const struct v4l2_buffer *b)
> int ret;
>
> ret = __verify_length(vb, b);
> - if (ret < 0)
> + if (ret < 0) {
> + dprintk(1, "%s(): plane parameters verification failed: %d\n",
> + __func__, ret);
> return ret;
> + }
>
> switch (q->memory) {
> case V4L2_MEMORY_MMAP:
Best regards
--
Marek Szyprowski
Samsung R&D Institute Poland
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-27 8:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-26 15:47 [PATCH] vb2: Add debug print for the output buffer planes lengths checks Sylwester Nawrocki
2013-08-27 8:51 ` Laurent Pinchart
2013-08-27 8:59 ` Marek Szyprowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.