All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
To: "H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
Cc: "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"jwboyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<jwboyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	"keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org"
	<keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
Subject: Re: [PATCH 05/10] asus-wmi: Restrict debugfs interface when module loading is restricted
Date: Thu, 29 Aug 2013 18:49:13 +0000	[thread overview]
Message-ID: <1377802153.27493.18.camel@x230> (raw)
In-Reply-To: <521F9708.6040902-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>

On Thu, 2013-08-29 at 11:46 -0700, H. Peter Anvin wrote:
> On 08/29/2013 11:35 AM, Matthew Garrett wrote:
> > On Thu, 2013-08-29 at 11:22 -0700, H. Peter Anvin wrote:
> >> On 08/19/2013 09:10 AM, Matthew Garrett wrote:
> >>> +	if (!capable(CAP_COMPROMISE_KERNEL))
> >>> +		return -EPERM;
> >>> +
> >>
> >> Stale bits?
> > 
> > Yeah. Did I manage to send out the old copy of that again? I'm sorry,
> > spending a few months concentrating on cloud stuff seems to have
> > entirely destroyed my ability to deal with git :(
> > 
> 
> No, you mixed and matched in a single patch...

Right, but I'd fixed that in V2 (which I see I *did* send correctly, and
you're just replying to the old one :))

> I still believe that CAP_RAWIO should be forbidden in this case.

Seems fair.

-- 
Matthew Garrett <matthew.garrett@nebula.com>

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <matthew.garrett@nebula.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>,
	"jwboyer@redhat.com" <jwboyer@redhat.com>,
	"keescook@chromium.org" <keescook@chromium.org>
Subject: Re: [PATCH 05/10] asus-wmi: Restrict debugfs interface when module loading is restricted
Date: Thu, 29 Aug 2013 18:49:13 +0000	[thread overview]
Message-ID: <1377802153.27493.18.camel@x230> (raw)
In-Reply-To: <521F9708.6040902@zytor.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 982 bytes --]

On Thu, 2013-08-29 at 11:46 -0700, H. Peter Anvin wrote:
> On 08/29/2013 11:35 AM, Matthew Garrett wrote:
> > On Thu, 2013-08-29 at 11:22 -0700, H. Peter Anvin wrote:
> >> On 08/19/2013 09:10 AM, Matthew Garrett wrote:
> >>> +	if (!capable(CAP_COMPROMISE_KERNEL))
> >>> +		return -EPERM;
> >>> +
> >>
> >> Stale bits?
> > 
> > Yeah. Did I manage to send out the old copy of that again? I'm sorry,
> > spending a few months concentrating on cloud stuff seems to have
> > entirely destroyed my ability to deal with git :(
> > 
> 
> No, you mixed and matched in a single patch...

Right, but I'd fixed that in V2 (which I see I *did* send correctly, and
you're just replying to the old one :))

> I still believe that CAP_RAWIO should be forbidden in this case.

Seems fair.

-- 
Matthew Garrett <matthew.garrett@nebula.com>
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

  parent reply	other threads:[~2013-08-29 18:49 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-19 16:10 [PATCH 01/10] Add secure_modules() call Matthew Garrett
2013-08-19 16:10 ` [PATCH 02/10] PCI: Lock down BAR access when module security is enabled Matthew Garrett
2013-08-19 16:10 ` [PATCH 05/10] asus-wmi: Restrict debugfs interface when module loading is restricted Matthew Garrett
     [not found]   ` <1376928619-3775-5-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-08-19 16:20     ` Kees Cook
2013-08-19 16:20       ` Kees Cook
     [not found]       ` <CAGXu5jJtvVx76ZZrk+s4KwopT-ocZcMbwWNM1ELxH4crm=QGLw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-08-19 17:15         ` Matthew Garrett
2013-08-19 17:15           ` Matthew Garrett
2013-08-29 18:22     ` H. Peter Anvin
2013-08-29 18:22       ` H. Peter Anvin
2013-08-29 18:35       ` Matthew Garrett
2013-08-29 18:35         ` Matthew Garrett
2013-08-29 18:46         ` H. Peter Anvin
2013-08-29 18:46           ` H. Peter Anvin
     [not found]           ` <521F9708.6040902-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2013-08-29 18:49             ` Matthew Garrett [this message]
2013-08-29 18:49               ` Matthew Garrett
2013-08-29 19:05               ` H. Peter Anvin
2013-08-29 19:05                 ` H. Peter Anvin
     [not found]                 ` <521F9B8B.6090300-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>
2013-08-29 19:07                   ` Matthew Garrett
2013-08-29 19:07                     ` Matthew Garrett
2013-08-29 19:28                   ` Josh Boyer
2013-08-29 19:28                     ` Josh Boyer
2013-08-19 16:10 ` [PATCH 06/10] Restrict /dev/mem and /dev/kmem " Matthew Garrett
2013-08-19 16:10 ` [PATCH 07/10] acpi: Ignore acpi_rsdp kernel parameter " Matthew Garrett
2013-08-19 16:10 ` [PATCH 08/10] kexec: Disable at runtime if the kernel enforces module loading restrictions Matthew Garrett
     [not found]   ` <1376928619-3775-8-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-09-01  8:52     ` Geert Uytterhoeven
2013-09-01  8:52       ` Geert Uytterhoeven
2013-08-19 16:10 ` [PATCH 09/10] x86: Restrict MSR access when module loading is restricted Matthew Garrett
     [not found] ` <1376928619-3775-1-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-08-19 16:10   ` [PATCH 03/10] x86: Lock down IO port access when module security is enabled Matthew Garrett
2013-08-19 16:10     ` Matthew Garrett
2013-08-19 16:10   ` [PATCH 04/10] ACPI: Limit access to custom_method Matthew Garrett
2013-08-19 16:10     ` Matthew Garrett
     [not found]     ` <1376928619-3775-4-git-send-email-matthew.garrett-05XSO3Yj/JvQT0dZR+AlfA@public.gmane.org>
2013-08-29 17:58       ` Lenny Szubowicz
2013-08-29 17:58         ` Lenny Szubowicz
2013-08-19 16:10   ` [PATCH 10/10] Add option to automatically enforce module signatures when in Secure Boot mode Matthew Garrett
2013-08-19 16:10     ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377802153.27493.18.camel@x230 \
    --to=matthew.garrett-05xso3yj/jvqt0dzr+alfa@public.gmane.org \
    --cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
    --cc=jwboyer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.