All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <amwang@redhat.com>
To: David Stevens <dlstevens@us.ibm.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, netdev-owner@vger.kernel.org
Subject: Re: [PATCH net-next v10 10/11] vxlan: respect scope_id for ll addr
Date: Fri, 30 Aug 2013 16:10:50 +0800	[thread overview]
Message-ID: <1377850250.2591.8.camel@cr0> (raw)
In-Reply-To: <OF231098A1.4B9DE99C-ON85257BD6.0074456A-85257BD6.00754552@us.ibm.com>

On Thu, 2013-08-29 at 17:20 -0400, David Stevens wrote:
> netdev-owner@vger.kernel.org wrote on 08/28/2013 01:22:58 AM:
> 
> > From: Cong Wang <amwang@redhat.com>
>  
> > As pointed out by David, we should take care of scope id for ll
> > addr, and use it for route lookup.
> 
>         It is an error to have a zero scope_id for an LL addr, but
> this code is not correct, because it only honors scope_id for
> LL addrs. Multicast addresses also require scope_id be set.
>         This shouldn't be in the transmit path. The netlink code
> that sets it should require it be nonzero for LL addrs and multicast
> addrs when it is set, and the transmit path should *always* use scope_id,
> whether for an lladdr or not, whether scope_id is zero or not.
> 

Except multicast address, I think this is what I did in some version
before? It is you who told me to respect scope id on tx path for
routing... I am really tired of changing it back again and again...

I will drop this patch and let you fix it by yourself later.

Thanks!

  reply	other threads:[~2013-08-30  8:10 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-28  5:22 [PATCH net-next v10 00/11] vxlan: add ipv6 support Cong Wang
2013-08-28  5:22 ` [PATCH net-next v10 01/11] ipv6: make ip6_dst_hoplimit() static inline Cong Wang
2013-08-28 10:39   ` Eric Dumazet
2013-08-28  5:22 ` [PATCH net-next v10 02/11] ipv6: move ip6_local_out into core kernel Cong Wang
2013-08-28  5:22 ` [PATCH net-next v10 03/11] ipv6: export a stub for IPv6 symbols used by vxlan Cong Wang
2013-08-28 16:12   ` Stephen Hemminger
2013-08-30  7:47     ` Cong Wang
2013-08-28  5:22 ` [PATCH net-next v10 04/11] ipv6: export some IPv6 special addresses to modules Cong Wang
2013-08-28  5:22 ` [PATCH net-next v10 05/11] ipv6: do not call ndisc_send_rs() with write lock Cong Wang
2013-08-28 15:34   ` Hannes Frederic Sowa
2013-08-28  5:22 ` [PATCH net-next v10 06/11] vxlan: add ipv6 support Cong Wang
2013-08-28  5:22 ` [PATCH net-next v10 07/11] vxlan: add ipv6 route short circuit support Cong Wang
2013-08-28 16:08   ` Stephen Hemminger
2013-08-28  5:22 ` [PATCH net-next v10 08/11] ipv6: move in6_dev_finish_destroy() into core kernel Cong Wang
2013-08-28  5:22 ` [PATCH net-next v10 09/11] vxlan: add ipv6 proxy support Cong Wang
2013-08-28 16:13   ` Stephen Hemminger
2013-08-28  5:22 ` [PATCH net-next v10 10/11] vxlan: respect scope_id for ll addr Cong Wang
2013-08-29 21:20   ` David Stevens
2013-08-30  8:10     ` Cong Wang [this message]
2013-08-28  5:22 ` [PATCH net-next v10 11/11] ipv6: Add generic UDP Tunnel segmentation Cong Wang
2013-08-28 17:55   ` Pravin Shelar
2013-08-30  8:16     ` Cong Wang
2013-08-30 21:14       ` Pravin Shelar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1377850250.2591.8.camel@cr0 \
    --to=amwang@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dlstevens@us.ibm.com \
    --cc=netdev-owner@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.