From: Stephen Hemminger <stephen@networkplumber.org>
To: Cong Wang <amwang@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
David Stevens <dlstevens@us.ibm.com>
Subject: Re: [PATCH net-next v10 07/11] vxlan: add ipv6 route short circuit support
Date: Wed, 28 Aug 2013 09:08:01 -0700 [thread overview]
Message-ID: <20130828090801.64a89878@nehalam.linuxnetplumber.net> (raw)
In-Reply-To: <1377667379-2315-8-git-send-email-amwang@redhat.com>
On Wed, 28 Aug 2013 13:22:55 +0800
Cong Wang <amwang@redhat.com> wrote:
> + n = neigh_lookup(ipv6_stub->nd_tbl, &pip6->daddr, dev);
> + if (!n && vxlan->flags & VXLAN_F_L3MISS) {
> + union vxlan_addr ipa;
> + ipa.sin6.sin6_addr = pip6->daddr;
> + ipa.sa.sa_family = AF_INET6;
Please always add paren's when doing bitwise mask in comparison, gcc will even warn
about this.
You could use C99 initialization for this which has added benefit
of zeroing unused fields.
union vxlan_addr ipa = {
.sa.sa_family = AF_INET6,
.sin6.sin6_sin6)addr = pip6->daddr,
};
next prev parent reply other threads:[~2013-08-28 16:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 5:22 [PATCH net-next v10 00/11] vxlan: add ipv6 support Cong Wang
2013-08-28 5:22 ` [PATCH net-next v10 01/11] ipv6: make ip6_dst_hoplimit() static inline Cong Wang
2013-08-28 10:39 ` Eric Dumazet
2013-08-28 5:22 ` [PATCH net-next v10 02/11] ipv6: move ip6_local_out into core kernel Cong Wang
2013-08-28 5:22 ` [PATCH net-next v10 03/11] ipv6: export a stub for IPv6 symbols used by vxlan Cong Wang
2013-08-28 16:12 ` Stephen Hemminger
2013-08-30 7:47 ` Cong Wang
2013-08-28 5:22 ` [PATCH net-next v10 04/11] ipv6: export some IPv6 special addresses to modules Cong Wang
2013-08-28 5:22 ` [PATCH net-next v10 05/11] ipv6: do not call ndisc_send_rs() with write lock Cong Wang
2013-08-28 15:34 ` Hannes Frederic Sowa
2013-08-28 5:22 ` [PATCH net-next v10 06/11] vxlan: add ipv6 support Cong Wang
2013-08-28 5:22 ` [PATCH net-next v10 07/11] vxlan: add ipv6 route short circuit support Cong Wang
2013-08-28 16:08 ` Stephen Hemminger [this message]
2013-08-28 5:22 ` [PATCH net-next v10 08/11] ipv6: move in6_dev_finish_destroy() into core kernel Cong Wang
2013-08-28 5:22 ` [PATCH net-next v10 09/11] vxlan: add ipv6 proxy support Cong Wang
2013-08-28 16:13 ` Stephen Hemminger
2013-08-28 5:22 ` [PATCH net-next v10 10/11] vxlan: respect scope_id for ll addr Cong Wang
2013-08-29 21:20 ` David Stevens
2013-08-30 8:10 ` Cong Wang
2013-08-28 5:22 ` [PATCH net-next v10 11/11] ipv6: Add generic UDP Tunnel segmentation Cong Wang
2013-08-28 17:55 ` Pravin Shelar
2013-08-30 8:16 ` Cong Wang
2013-08-30 21:14 ` Pravin Shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130828090801.64a89878@nehalam.linuxnetplumber.net \
--to=stephen@networkplumber.org \
--cc=amwang@redhat.com \
--cc=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.