* [Buildroot] [PATCH] dependencies: Add host prerequisite for elf2flt
@ 2013-09-04 8:16 Axel Lin
2013-09-04 8:51 ` Thomas Petazzoni
0 siblings, 1 reply; 9+ messages in thread
From: Axel Lin @ 2013-09-04 8:16 UTC (permalink / raw)
To: buildroot
This ensures elf2flt will be built when BR2_PACKAGE_HOST_ELF2FLT=y before
building other packages.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
I don't have a blackfin platform, only test build this for blackfin.
Without this patch, the first time build will result in ELF binary because
busybox is built before elf2flt.
With this path, the result looks good, it produces BFLT executable for busybox.
support/dependencies/dependencies.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/support/dependencies/dependencies.mk b/support/dependencies/dependencies.mk
index 4a220e0..3b8ea31 100644
--- a/support/dependencies/dependencies.mk
+++ b/support/dependencies/dependencies.mk
@@ -24,6 +24,10 @@ ifeq ($(BR2_CCACHE),y)
DEPENDENCIES_HOST_PREREQ += host-ccache
endif
+ifeq ($(BR2_PACKAGE_HOST_ELF2FLT),y)
+DEPENDENCIES_HOST_PREREQ += host-elf2flt
+endif
+
core-dependencies:
@HOSTCC="$(firstword $(HOSTCC))" MAKE="$(MAKE)" \
DL_TOOLS="$(sort $(DL_TOOLS_DEPENDENCIES))" \
--
1.8.1.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] dependencies: Add host prerequisite for elf2flt
2013-09-04 8:16 [Buildroot] [PATCH] dependencies: Add host prerequisite for elf2flt Axel Lin
@ 2013-09-04 8:51 ` Thomas Petazzoni
2013-09-04 10:34 ` Gustavo Zacarias
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2013-09-04 8:51 UTC (permalink / raw)
To: buildroot
Dear Axel Lin,
On Wed, 04 Sep 2013 16:16:55 +0800, Axel Lin wrote:
> This ensures elf2flt will be built when BR2_PACKAGE_HOST_ELF2FLT=y before
> building other packages.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> I don't have a blackfin platform, only test build this for blackfin.
> Without this patch, the first time build will result in ELF binary because
> busybox is built before elf2flt.
> With this path, the result looks good, it produces BFLT executable for busybox.
I don't think host-elf2flt should be added at this level of dependency.
If I understand correctly elf2flt, it interfaces with the linker, so I
believe making elf2flt a dependency of binutils would probably make a
bit more sense.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] dependencies: Add host prerequisite for elf2flt
2013-09-04 8:51 ` Thomas Petazzoni
@ 2013-09-04 10:34 ` Gustavo Zacarias
2013-09-04 11:19 ` Thomas Petazzoni
0 siblings, 1 reply; 9+ messages in thread
From: Gustavo Zacarias @ 2013-09-04 10:34 UTC (permalink / raw)
To: buildroot
On 09/04/2013 05:51 AM, Thomas Petazzoni wrote:
> I don't think host-elf2flt should be added at this level of dependency.
> If I understand correctly elf2flt, it interfaces with the linker, so I
> believe making elf2flt a dependency of binutils would probably make a
> bit more sense.
It's already done correctly in the dependency deparment...
HOST_ELF2FLT_DEPENDENCIES = host-binutils host-zlib
The problem is it's never pulled in when it's necessary - before the
real packages start building, so adding it up as a gcc dep when
BR2_BINFMT_FLAT=y would be appropiate.
Regards.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] dependencies: Add host prerequisite for elf2flt
2013-09-04 10:34 ` Gustavo Zacarias
@ 2013-09-04 11:19 ` Thomas Petazzoni
2013-09-04 11:27 ` Gustavo Zacarias
0 siblings, 1 reply; 9+ messages in thread
From: Thomas Petazzoni @ 2013-09-04 11:19 UTC (permalink / raw)
To: buildroot
Dear Gustavo Zacarias,
On Wed, 04 Sep 2013 07:34:34 -0300, Gustavo Zacarias wrote:
> On 09/04/2013 05:51 AM, Thomas Petazzoni wrote:
> > I don't think host-elf2flt should be added at this level of dependency.
> > If I understand correctly elf2flt, it interfaces with the linker, so I
> > believe making elf2flt a dependency of binutils would probably make a
> > bit more sense.
>
> It's already done correctly in the dependency deparment...
>
> HOST_ELF2FLT_DEPENDENCIES = host-binutils host-zlib
What I was suggesting is that host-elf2flt should have been a
dependency of host-binutils. But that's obviously wrong, since elf2flt
requires the libbfd library I suspect.
> The problem is it's never pulled in when it's necessary - before the
> real packages start building, so adding it up as a gcc dep when
> BR2_BINFMT_FLAT=y would be appropiate.
Indeed. If it's not needed during the gcc build, one solution is to add
its as a dependency in host-gcc-final.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] dependencies: Add host prerequisite for elf2flt
2013-09-04 11:19 ` Thomas Petazzoni
@ 2013-09-04 11:27 ` Gustavo Zacarias
2013-09-04 11:34 ` Thomas Petazzoni
0 siblings, 1 reply; 9+ messages in thread
From: Gustavo Zacarias @ 2013-09-04 11:27 UTC (permalink / raw)
To: buildroot
On 09/04/2013 08:19 AM, Thomas Petazzoni wrote:
>> HOST_ELF2FLT_DEPENDENCIES = host-binutils host-zlib
>
> What I was suggesting is that host-elf2flt should have been a
> dependency of host-binutils. But that's obviously wrong, since elf2flt
> requires the libbfd library I suspect.
Yes that's true, the order would be binutils -> elf2flt -> gcc -> world
domination.
> Indeed. If it's not needed during the gcc build, one solution is to add
> its as a dependency in host-gcc-final.
It's needed for some uClibc combination, link-flat.so which uses elf2flt
pulls in libgcc according to uclibc/Makerules (used in
uclibc/libc/Makefile.in).
I think it's safer to pull it in for gcc-intermediate or even gcc-initial.
Regards.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] dependencies: Add host prerequisite for elf2flt
2013-09-04 11:27 ` Gustavo Zacarias
@ 2013-09-04 11:34 ` Thomas Petazzoni
[not found] ` <CAAXf6LW+C8GpD8vh4D3xQKNHggYOXmbG8xSRBttuYt8+usCnoA@mail.gmail.com>
2013-09-04 12:14 ` Thomas De Schampheleire
0 siblings, 2 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2013-09-04 11:34 UTC (permalink / raw)
To: buildroot
Dear Gustavo Zacarias,
On Wed, 04 Sep 2013 08:27:17 -0300, Gustavo Zacarias wrote:
> > Indeed. If it's not needed during the gcc build, one solution is to add
> > its as a dependency in host-gcc-final.
>
> It's needed for some uClibc combination, link-flat.so which uses elf2flt
> pulls in libgcc according to uclibc/Makerules (used in
> uclibc/libc/Makefile.in).
> I think it's safer to pull it in for gcc-intermediate or even gcc-initial.
gcc-intermediate is going to be skipped in some situations after my
patch "[PATCHv2 03/14] toolchain-internal: skip gcc-intermediate when
possible" is merged.
So, as a dependency of gcc-initial seems like a better choice.
Thanks,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2013-09-04 12:16 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-04 8:16 [Buildroot] [PATCH] dependencies: Add host prerequisite for elf2flt Axel Lin
2013-09-04 8:51 ` Thomas Petazzoni
2013-09-04 10:34 ` Gustavo Zacarias
2013-09-04 11:19 ` Thomas Petazzoni
2013-09-04 11:27 ` Gustavo Zacarias
2013-09-04 11:34 ` Thomas Petazzoni
[not found] ` <CAAXf6LW+C8GpD8vh4D3xQKNHggYOXmbG8xSRBttuYt8+usCnoA@mail.gmail.com>
2013-09-04 12:14 ` Gustavo Zacarias
2013-09-04 12:16 ` Thomas De Schampheleire
2013-09-04 12:14 ` Thomas De Schampheleire
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.