Re: [PATCH] qemu: add recommend of kernel-modules for all qemu machines

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2013-09-04 at 17:22 +0100, Ross Burton wrote:
> Only qemumips was recommending kernel-modules which meant that the other qemu
> machines were missing some kernel modules, for example binfmt-misc.
> 
> Move the recommends to qemu.inc so that all qemu machines pull in the kernel
> modules that have been built.
> 
> [ YOCTO #4863 ]
> 
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/conf/machine/include/qemu.inc |    2 ++
>  meta/conf/machine/qemumips.conf    |    2 --
>  meta/conf/machine/qemumips64.conf  |    2 --
>  3 files changed, 2 insertions(+), 4 deletions(-)

How many modules are built for the qemu machines? Are they all useful?
I'm just trying to get a feel for how much we're adding here and whether
this is the right thing to be doing...

Cheers,

Richard



> 
> diff --git a/meta/conf/machine/include/qemu.inc b/meta/conf/machine/include/qemu.inc
> index 545f8d1..7baf13e 100644
> --- a/meta/conf/machine/include/qemu.inc
> +++ b/meta/conf/machine/include/qemu.inc
> @@ -27,3 +27,5 @@ EXTRA_IMAGEDEPENDS += "qemu-native qemu-helper-native"
>  
>  # Provide the nfs server kernel module for all qemu images
>  KERNEL_FEATURES_append_pn-linux-yocto = " features/nfsd/nfsd-enable.scc"
> +
> +MACHINE_EXTRA_RRECOMMENDS = "kernel-modules"
> diff --git a/meta/conf/machine/qemumips.conf b/meta/conf/machine/qemumips.conf
> index ce1c419..89721a6 100644
> --- a/meta/conf/machine/qemumips.conf
> +++ b/meta/conf/machine/qemumips.conf
> @@ -9,5 +9,3 @@ KERNEL_IMAGETYPE = "vmlinux"
>  KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
>  
>  SERIAL_CONSOLE = "115200 ttyS0"
> -
> -MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
> diff --git a/meta/conf/machine/qemumips64.conf b/meta/conf/machine/qemumips64.conf
> index b2c7998..7ba98cb 100644
> --- a/meta/conf/machine/qemumips64.conf
> +++ b/meta/conf/machine/qemumips64.conf
> @@ -9,5 +9,3 @@ KERNEL_IMAGETYPE = "vmlinux"
>  KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
>  
>  SERIAL_CONSOLE = "115200 ttyS0"
> -
> -MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"