Re: [PATCH] qemu: add recommend of kernel-modules for all qemu machines

From: Martin Jansa <martin.jansa@gmail.com>
To: Bruce Ashfield <bruce.ashfield@gmail.com>
Cc: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] qemu: add recommend of kernel-modules for all qemu machines
Date: Thu, 5 Sep 2013 09:11:33 +0200	[thread overview]
Message-ID: <20130905071133.GG11500@jama> (raw)
In-Reply-To: <CADkTA4NbnmnQZXB2YLv5psJwA=gDAh9Bi4sGOr2dp30sTR0bJg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3544 bytes --]

On Wed, Sep 04, 2013 at 08:51:25PM -0400, Bruce Ashfield wrote:
> On Wed, Sep 4, 2013 at 6:01 PM, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> > On Wed, 2013-09-04 at 17:22 +0100, Ross Burton wrote:
> >> Only qemumips was recommending kernel-modules which meant that the other qemu
> >> machines were missing some kernel modules, for example binfmt-misc.
> >>
> >> Move the recommends to qemu.inc so that all qemu machines pull in the kernel
> >> modules that have been built.
> >>
> >> [ YOCTO #4863 ]
> >>
> >> Signed-off-by: Ross Burton <ross.burton@intel.com>
> >> ---
> >>  meta/conf/machine/include/qemu.inc |    2 ++
> >>  meta/conf/machine/qemumips.conf    |    2 --
> >>  meta/conf/machine/qemumips64.conf  |    2 --
> >>  3 files changed, 2 insertions(+), 4 deletions(-)
> >
> > How many modules are built for the qemu machines? Are they all useful?
> > I'm just trying to get a feel for how much we're adding here and whether
> > this is the right thing to be doing...
> 
> We can control the configs as tightly as we want, so if we are building too much
> for this, I'm happy to trim things down.

I don't think this is right way to do it.

It's good to have as many optional modules available in feed (so to
enable many modules in configs - you never know what obscure device
someone will try to test with qemu and one more module and package in
feed has smaller overhead then need to change configs) and install
only important modules by default in every image.

> 
> Cheers,
> 
> Bruce
> 
> >
> > Cheers,
> >
> > Richard
> >
> >
> >
> >>
> >> diff --git a/meta/conf/machine/include/qemu.inc b/meta/conf/machine/include/qemu.inc
> >> index 545f8d1..7baf13e 100644
> >> --- a/meta/conf/machine/include/qemu.inc
> >> +++ b/meta/conf/machine/include/qemu.inc
> >> @@ -27,3 +27,5 @@ EXTRA_IMAGEDEPENDS += "qemu-native qemu-helper-native"
> >>
> >>  # Provide the nfs server kernel module for all qemu images
> >>  KERNEL_FEATURES_append_pn-linux-yocto = " features/nfsd/nfsd-enable.scc"
> >> +
> >> +MACHINE_EXTRA_RRECOMMENDS = "kernel-modules"
> >> diff --git a/meta/conf/machine/qemumips.conf b/meta/conf/machine/qemumips.conf
> >> index ce1c419..89721a6 100644
> >> --- a/meta/conf/machine/qemumips.conf
> >> +++ b/meta/conf/machine/qemumips.conf
> >> @@ -9,5 +9,3 @@ KERNEL_IMAGETYPE = "vmlinux"
> >>  KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
> >>
> >>  SERIAL_CONSOLE = "115200 ttyS0"
> >> -
> >> -MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
> >> diff --git a/meta/conf/machine/qemumips64.conf b/meta/conf/machine/qemumips64.conf
> >> index b2c7998..7ba98cb 100644
> >> --- a/meta/conf/machine/qemumips64.conf
> >> +++ b/meta/conf/machine/qemumips64.conf
> >> @@ -9,5 +9,3 @@ KERNEL_IMAGETYPE = "vmlinux"
> >>  KERNEL_ALT_IMAGETYPE = "vmlinux.bin"
> >>
> >>  SERIAL_CONSOLE = "115200 ttyS0"
> >> -
> >> -MACHINE_EXTRA_RRECOMMENDS = " kernel-modules"
> >
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 
> 
> 
> -- 
> "Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end"
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]