From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: Christophe Leroy <christophe.leroy@c-s.fr>,
linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc 8xx: Fixing issue with CONFIG_PIN_TLB
Date: Thu, 12 Sep 2013 10:15:11 +1000 [thread overview]
Message-ID: <1378944911.4066.12.camel@pasglop> (raw)
In-Reply-To: <1378939017.12204.409.camel@snotra.buserror.net>
On Wed, 2013-09-11 at 17:36 -0500, Scott Wood wrote:
> I wonder why we don't start from entry 31 so we can actually make use of
> that autodecrement. What will happen when we load the first normal TLB
> entry later on? I don't see any setting of SPRN_MD_CTR after this code,
> so won't it overwrite entry 30 (the middle 8M) in the CONFIG_PIN_TLB
> case?
>
> Ben, would patches like this be considered bugfixes as far as merging
> goes, or would they be for next given that it's something that's never
> really worked right and hasn't been touched in years?
Since they don't affect anything outside of 8xx, I'm happy to take them
until around -rc2 or 3. But it's your call really.
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Scott Wood <scottwood@freescale.com>
Cc: Christophe Leroy <christophe.leroy@c-s.fr>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc 8xx: Fixing issue with CONFIG_PIN_TLB
Date: Thu, 12 Sep 2013 10:15:11 +1000 [thread overview]
Message-ID: <1378944911.4066.12.camel@pasglop> (raw)
In-Reply-To: <1378939017.12204.409.camel@snotra.buserror.net>
On Wed, 2013-09-11 at 17:36 -0500, Scott Wood wrote:
> I wonder why we don't start from entry 31 so we can actually make use of
> that autodecrement. What will happen when we load the first normal TLB
> entry later on? I don't see any setting of SPRN_MD_CTR after this code,
> so won't it overwrite entry 30 (the middle 8M) in the CONFIG_PIN_TLB
> case?
>
> Ben, would patches like this be considered bugfixes as far as merging
> goes, or would they be for next given that it's something that's never
> really worked right and hasn't been touched in years?
Since they don't affect anything outside of 8xx, I'm happy to take them
until around -rc2 or 3. But it's your call really.
Cheers,
Ben.
next prev parent reply other threads:[~2013-09-12 0:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-11 16:44 [PATCH] powerpc 8xx: Fixing issue with CONFIG_PIN_TLB Christophe Leroy
2013-09-11 16:44 ` Christophe Leroy
2013-09-11 22:36 ` Scott Wood
2013-09-11 22:36 ` Scott Wood
2013-09-12 0:15 ` Benjamin Herrenschmidt [this message]
2013-09-12 0:15 ` Benjamin Herrenschmidt
2013-09-12 5:57 ` leroy christophe
2013-09-12 5:57 ` leroy christophe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1378944911.4066.12.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.