All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yves-Alexis Perez <corsac@debian.org>
To: Aaron Lu <aaron.lu@intel.com>
Cc: Matthew Garrett <matthew.garrett@nebula.com>,
	Seth Forshee <seth.forshee@canonical.com>,
	intel-gfx@lists.freedesktop.org,
	Felipe Contreras <felipe.contreras@gmail.com>,
	Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	linux-acpi@vger.kernel.org, Lee Chun-Yi <joeyli.kernel@gmail.com>,
	Richard Purdie <rpurdie@rpsys.net>,
	Igor Gnatenko <i.gnatenko.brain@gmail.com>
Subject: Re: [PATCH v2 0/3] Fix Win8 backlight issue
Date: Fri, 20 Sep 2013 15:00:15 +0200	[thread overview]
Message-ID: <1379682015.9746.3.camel@oban> (raw)
In-Reply-To: <1379409796-29350-1-git-send-email-aaron.lu@intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 1392 bytes --]

On mar., 2013-09-17 at 17:23 +0800, Aaron Lu wrote:
> v1 has the subject of "Rework ACPI video driver" and is posted here:
> http://lkml.org/lkml/2013/9/9/74
> Since the objective is really to fix Win8 backlight issues, I changed
> the subject in this version, sorry about that.
> 
> This patchset has three patches, the first introduced a new API named
> backlight_device_registered in backlight layer that can be used for
> backlight interface provider module to check if a specific type
> backlight
> interface has been registered, see changelog for patch 1/3 for
> details.
> Then patch 2/3 does the cleanup to sepeate the backlight control and
> event delivery functionality in the ACPI video module and patch 3/3
> solves some Win8 backlight control problems by avoiding register ACPI
> video's backlight interface if:
> 1 Kernel cmdline option acpi_backlight=video is not given;
> 2 This is a Win8 system;
> 3 Native backlight control interface exists.

I've tested this on my x230 (using pure UEFI with CSM disabled). As far
as I can tell, it works as I would expect:

- brightness keys work in initramfs, in console after boot, in lightdm
prompt and in Xfce (wether or not xfce4-power-manager is running).

I don't have brightness notifications (from xfce4-power-manager) but I
don't usually need them so I'm fine with that.

Regards,
-- 
Yves-Alexis

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

WARNING: multiple messages have this Message-ID (diff)
From: Yves-Alexis Perez <corsac@debian.org>
To: Aaron Lu <aaron.lu@intel.com>
Cc: linux-acpi@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Daniel Vetter <daniel@ffwll.ch>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Matthew Garrett <matthew.garrett@nebula.com>,
	Seth Forshee <seth.forshee@canonical.com>,
	Lee Chun-Yi <joeyli.kernel@gmail.com>,
	Richard Purdie <rpurdie@rpsys.net>,
	Igor Gnatenko <i.gnatenko.brain@gmail.com>,
	Felipe Contreras <felipe.contreras@gmail.com>,
	Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
	Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH v2 0/3] Fix Win8 backlight issue
Date: Fri, 20 Sep 2013 15:00:15 +0200	[thread overview]
Message-ID: <1379682015.9746.3.camel@oban> (raw)
In-Reply-To: <1379409796-29350-1-git-send-email-aaron.lu@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1392 bytes --]

On mar., 2013-09-17 at 17:23 +0800, Aaron Lu wrote:
> v1 has the subject of "Rework ACPI video driver" and is posted here:
> http://lkml.org/lkml/2013/9/9/74
> Since the objective is really to fix Win8 backlight issues, I changed
> the subject in this version, sorry about that.
> 
> This patchset has three patches, the first introduced a new API named
> backlight_device_registered in backlight layer that can be used for
> backlight interface provider module to check if a specific type
> backlight
> interface has been registered, see changelog for patch 1/3 for
> details.
> Then patch 2/3 does the cleanup to sepeate the backlight control and
> event delivery functionality in the ACPI video module and patch 3/3
> solves some Win8 backlight control problems by avoiding register ACPI
> video's backlight interface if:
> 1 Kernel cmdline option acpi_backlight=video is not given;
> 2 This is a Win8 system;
> 3 Native backlight control interface exists.

I've tested this on my x230 (using pure UEFI with CSM disabled). As far
as I can tell, it works as I would expect:

- brightness keys work in initramfs, in console after boot, in lightdm
prompt and in Xfce (wether or not xfce4-power-manager is running).

I don't have brightness notifications (from xfce4-power-manager) but I
don't usually need them so I'm fine with that.

Regards,
-- 
Yves-Alexis

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  parent reply	other threads:[~2013-09-20 13:00 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-17  9:23 [PATCH v2 0/3] Fix Win8 backlight issue Aaron Lu
2013-09-17  9:23 ` [PATCH v2 1/3] backlight: introduce backlight_device_registered Aaron Lu
2013-09-17 13:03   ` Igor Gnatenko
2013-09-20 13:01   ` Yves-Alexis Perez
2013-09-20 13:01     ` Yves-Alexis Perez
2013-09-17  9:23 ` [PATCH v2 2/3] ACPI / video: seperate backlight control and event interface Aaron Lu
2013-09-17 13:04   ` Igor Gnatenko
2013-09-20 13:01   ` Yves-Alexis Perez
2013-09-20 13:01     ` Yves-Alexis Perez
2013-09-17  9:23 ` [PATCH v2 3/3] ACPI / video: Do not register backlight if win8 and native interface exists Aaron Lu
2013-09-17 13:04   ` Igor Gnatenko
2013-09-20  8:36   ` Jani Nikula
2013-09-20  8:36     ` Jani Nikula
2013-09-22  2:47     ` Aaron Lu
2013-09-22  2:47       ` Aaron Lu
2013-09-20 13:02   ` Yves-Alexis Perez
2013-09-20 13:02     ` Yves-Alexis Perez
2013-09-17 13:34 ` [PATCH v2 0/3] Fix Win8 backlight issue Igor Gnatenko
2013-09-18  1:03   ` Aaron Lu
2013-09-18  1:03     ` Aaron Lu
2013-09-18  6:30     ` Igor Gnatenko
2013-09-18 12:31       ` Aaron Lu
2013-09-18 12:36         ` Igor Gnatenko
2013-09-22  9:10           ` Aaron Lu
2013-09-22 10:23             ` Igor Gnatenko
2013-09-20 13:00 ` Yves-Alexis Perez [this message]
2013-09-20 13:00   ` Yves-Alexis Perez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379682015.9746.3.camel@oban \
    --to=corsac@debian.org \
    --cc=aaron.lu@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=felipe.contreras@gmail.com \
    --cc=i.gnatenko.brain@gmail.com \
    --cc=ibm-acpi@hmh.eng.br \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=joeyli.kernel@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.garrett@nebula.com \
    --cc=rjw@sisk.pl \
    --cc=rpurdie@rpsys.net \
    --cc=seth.forshee@canonical.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.