All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Mack <zonque@gmail.com>
To: linux-ubs@vger.kernel.org
Cc: balbi@ti.com, linux-omap@vger.kernel.org,
	gregkh@linuxfoundation.org, Daniel Mack <zonque@gmail.com>
Subject: [PATCH 2/4] usb: musb: blackfin: use SIMPLE_DEV_PM_OPS
Date: Sun, 22 Sep 2013 13:46:59 +0200	[thread overview]
Message-ID: <1379850421-7966-2-git-send-email-zonque@gmail.com> (raw)
In-Reply-To: <1379850421-7966-1-git-send-email-zonque@gmail.com>

This makes bfin_pm_ops const.

Also, checkpatch.pl complains about the use of DEV_PM_OPS:

  ERROR: Macros with complex values should be enclosed in parenthesis

Signed-off-by: Daniel Mack <zonque@gmail.com>
---
 drivers/usb/musb/blackfin.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/musb/blackfin.c b/drivers/usb/musb/blackfin.c
index 72e2056..7db75c9 100644
--- a/drivers/usb/musb/blackfin.c
+++ b/drivers/usb/musb/blackfin.c
@@ -562,12 +562,9 @@ static int bfin_resume(struct device *dev)
 	return 0;
 }
 
-static struct dev_pm_ops bfin_pm_ops = {
-	.suspend	= bfin_suspend,
-	.resume		= bfin_resume,
-};
+static SIMPLE_DEV_PM_OPS(bfin_pm_ops, bfin_suspend, bfin_resume);
 
-#define DEV_PM_OPS	&bfin_pm_ops
+#define DEV_PM_OPS	(&bfin_pm_ops)
 #else
 #define DEV_PM_OPS	NULL
 #endif
-- 
1.8.3.1


  reply	other threads:[~2013-09-22 11:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-22 11:46 [PATCH 1/4] usb: musb: am35x: use SIMPLE_DEV_PM_OPS Daniel Mack
2013-09-22 11:46 ` Daniel Mack [this message]
2013-09-22 11:47 ` [PATCH 3/4] usb: musb: omap2430: " Daniel Mack
2013-09-22 11:47 ` [PATCH 4/4] usb: musb: ux500: " Daniel Mack
2013-09-23 21:20 ` [PATCH 1/4] usb: musb: am35x: " Felipe Balbi
2013-09-24  6:57   ` Daniel Mack
2013-09-25 13:48     ` Felipe Balbi
2013-09-27 18:47       ` Daniel Mack
2013-09-30 16:25         ` Felipe Balbi
2013-09-30 16:56           ` Daniel Mack
2013-10-02  8:10           ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1379850421-7966-2-git-send-email-zonque@gmail.com \
    --to=zonque@gmail.com \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-ubs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.