Re: [PATCH 1/4] usb: musb: am35x: use SIMPLE_DEV_PM_OPS

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 949 bytes --]

Hi,

On Sun, Sep 22, 2013 at 01:46:58PM +0200, Daniel Mack wrote:
> This makes am35x_pm_ops const.
> 
> Also, checkpatch.pl complains about the use of DEV_PM_OPS:
> 
>   ERROR: Macros with complex values should be enclosed in parenthesis
> 
> Signed-off-by: Daniel Mack <zonque@gmail.com>
> ---
>  drivers/usb/musb/am35x.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/usb/musb/am35x.c b/drivers/usb/musb/am35x.c
> index 5c310c6..df32a29 100644
> --- a/drivers/usb/musb/am35x.c
> +++ b/drivers/usb/musb/am35x.c
> @@ -616,12 +616,9 @@ static int am35x_resume(struct device *dev)
>  	return 0;
>  }
>  
> -static struct dev_pm_ops am35x_pm_ops = {
> -	.suspend	= am35x_suspend,
> -	.resume		= am35x_resume,
> -};
> +static SIMPLE_DEV_PM_OPS(am35x_pm_ops, am35x_suspend, am35x_resume);

you could as well remove the DEV_PM_OPS trickery. Ditto for all other
patches

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]