All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wen Gong <wgong@codeaurora.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Brian Norris <briannorris@chromium.org>,
	ath10k <ath10k@lists.infradead.org>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size
Date: Mon, 08 Mar 2021 15:22:23 +0800	[thread overview]
Message-ID: <137aaa6a6aa0ad0c0cf6e358705369c5@codeaurora.org> (raw)
In-Reply-To: <20210210115322.0b65a856@gandalf.local.home>

On 2021-02-11 00:53, Steven Rostedt wrote:
> On Wed, 10 Feb 2021 11:48:23 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
>> On Wed, 10 Feb 2021 11:30:26 -0500
>> Steven Rostedt <rostedt@goodmis.org> wrote:
>> 
>> > Can you test this patch?
>> 
>> v2:
> 
> Bah!
> 
> v3:
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index b79bcacdd6f9..90d7ade03499 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -2739,7 +2739,7 @@ trace_event_buffer_lock_reserve(struct
> trace_buffer **current_rb,
>  	    (entry = this_cpu_read(trace_buffered_event))) {
>  		/* Try to use the per cpu buffer first */
>  		val = this_cpu_inc_return(trace_buffered_event_cnt);
> -		if (val == 1) {
> +		if ((len < (PAGE_SIZE - sizeof(*entry))) && val == 1) {
>  			trace_event_setup(entry, type, trace_ctx);
>  			entry->array[0] = len;
>  			return entry;
After apply this 
patch(https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/kernel/trace/trace.c?id=b220c049d5196dd94d992dd2dc8cba1a5e6123bf).
It not crash again on my v4.19 kernel.

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Wen Gong <wgong@codeaurora.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Brian Norris <briannorris@chromium.org>,
	ath10k <ath10k@lists.infradead.org>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size
Date: Mon, 08 Mar 2021 15:22:23 +0800	[thread overview]
Message-ID: <137aaa6a6aa0ad0c0cf6e358705369c5@codeaurora.org> (raw)
In-Reply-To: <20210210115322.0b65a856@gandalf.local.home>

On 2021-02-11 00:53, Steven Rostedt wrote:
> On Wed, 10 Feb 2021 11:48:23 -0500
> Steven Rostedt <rostedt@goodmis.org> wrote:
> 
>> On Wed, 10 Feb 2021 11:30:26 -0500
>> Steven Rostedt <rostedt@goodmis.org> wrote:
>> 
>> > Can you test this patch?
>> 
>> v2:
> 
> Bah!
> 
> v3:
> 
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index b79bcacdd6f9..90d7ade03499 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -2739,7 +2739,7 @@ trace_event_buffer_lock_reserve(struct
> trace_buffer **current_rb,
>  	    (entry = this_cpu_read(trace_buffered_event))) {
>  		/* Try to use the per cpu buffer first */
>  		val = this_cpu_inc_return(trace_buffered_event_cnt);
> -		if (val == 1) {
> +		if ((len < (PAGE_SIZE - sizeof(*entry))) && val == 1) {
>  			trace_event_setup(entry, type, trace_ctx);
>  			entry->array[0] = len;
>  			return entry;
After apply this 
patch(https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/kernel/trace/trace.c?id=b220c049d5196dd94d992dd2dc8cba1a5e6123bf).
It not crash again on my v4.19 kernel.

  reply	other threads:[~2021-03-08  7:25 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-09  2:59 [PATCH] ath10k: change len of trace_ath10k_log_dbg_dump for large buffer size Wen Gong
2021-02-09  2:59 ` Wen Gong
2021-02-09  7:34 ` Kalle Valo
2021-02-09  7:34 ` Kalle Valo
2021-02-09 19:35 ` Brian Norris
2021-02-09 19:35   ` Brian Norris
2021-02-09 19:55   ` Steven Rostedt
2021-02-09 19:55     ` Steven Rostedt
2021-02-09 21:34     ` Steven Rostedt
2021-02-09 21:34       ` Steven Rostedt
2021-02-10  2:01       ` Wen Gong
2021-02-10  2:01         ` Wen Gong
2021-02-10 16:30         ` Steven Rostedt
2021-02-10 16:30           ` Steven Rostedt
2021-02-10 16:48           ` Steven Rostedt
2021-02-10 16:48             ` Steven Rostedt
2021-02-10 16:53             ` Steven Rostedt
2021-02-10 16:53               ` Steven Rostedt
2021-03-08  7:22               ` Wen Gong [this message]
2021-03-08  7:22                 ` Wen Gong
2021-02-10  2:11   ` Wen Gong
2021-02-10  2:11     ` Wen Gong
2021-02-10  2:14     ` Brian Norris
2021-02-10  2:14       ` Brian Norris
2021-02-10  2:24       ` Wen Gong
2021-02-10  2:24         ` Wen Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=137aaa6a6aa0ad0c0cf6e358705369c5@codeaurora.org \
    --to=wgong@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=briannorris@chromium.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.