From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
gleb@redhat.com, pbonzini@redhat.com, agraf@suse.de,
mpm@selenic.com, herbert@gondor.hengli.com.au,
linuxppc-dev@ozlabs.org, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH 2/3] hwrng: Add a driver for the hwrng found in power7+ systems
Date: Thu, 26 Sep 2013 08:01:27 +0000 [thread overview]
Message-ID: <1380182487.28561.22.camel@pasglop> (raw)
In-Reply-To: <1380177066-3835-2-git-send-email-michael@ellerman.id.au>
On Thu, 2013-09-26 at 16:31 +1000, Michael Ellerman wrote:
> + pr_info("registered powernv hwrng.\n");
First letter of a line should get a capital :-) Also since
it's per-device, at least indicate the OF path or the chip number or
something ...
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: tytso@mit.edu, kvm@vger.kernel.org, gleb@redhat.com,
linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org,
kvm-ppc@vger.kernel.org, agraf@suse.de,
herbert@gondor.hengli.com.au, Paul Mackerras <paulus@samba.org>,
mpm@selenic.com, pbonzini@redhat.com
Subject: Re: [PATCH 2/3] hwrng: Add a driver for the hwrng found in power7+ systems
Date: Thu, 26 Sep 2013 18:01:27 +1000 [thread overview]
Message-ID: <1380182487.28561.22.camel@pasglop> (raw)
In-Reply-To: <1380177066-3835-2-git-send-email-michael@ellerman.id.au>
On Thu, 2013-09-26 at 16:31 +1000, Michael Ellerman wrote:
> + pr_info("registered powernv hwrng.\n");
First letter of a line should get a capital :-) Also since
it's per-device, at least indicate the OF path or the chip number or
something ...
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
gleb@redhat.com, pbonzini@redhat.com, agraf@suse.de,
mpm@selenic.com, herbert@gondor.hengli.com.au,
linuxppc-dev@ozlabs.org, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH 2/3] hwrng: Add a driver for the hwrng found in power7+ systems
Date: Thu, 26 Sep 2013 18:01:27 +1000 [thread overview]
Message-ID: <1380182487.28561.22.camel@pasglop> (raw)
In-Reply-To: <1380177066-3835-2-git-send-email-michael@ellerman.id.au>
On Thu, 2013-09-26 at 16:31 +1000, Michael Ellerman wrote:
> + pr_info("registered powernv hwrng.\n");
First letter of a line should get a capital :-) Also since
it's per-device, at least indicate the OF path or the chip number or
something ...
Cheers,
Ben.
next prev parent reply other threads:[~2013-09-26 8:01 UTC|newest]
Thread overview: 147+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-26 6:31 [PATCH 1/3] powerpc: Implement arch_get_random_long/int() for powernv Michael Ellerman
2013-09-26 6:31 ` Michael Ellerman
2013-09-26 6:31 ` Michael Ellerman
2013-09-26 6:31 ` Michael Ellerman
2013-09-26 6:31 ` [PATCH 2/3] hwrng: Add a driver for the hwrng found in power7+ systems Michael Ellerman
2013-09-26 6:31 ` Michael Ellerman
2013-09-26 6:31 ` Michael Ellerman
2013-09-26 6:31 ` Michael Ellerman
2013-09-26 8:01 ` Benjamin Herrenschmidt [this message]
2013-09-26 8:01 ` Benjamin Herrenschmidt
2013-09-26 8:01 ` Benjamin Herrenschmidt
2013-10-01 8:25 ` Michael Ellerman
2013-10-01 8:25 ` Michael Ellerman
2013-10-01 8:25 ` Michael Ellerman
2013-09-26 6:31 ` [PATCH 3/3] KVM: PPC: Book3S: Add support for hwrng found on some powernv systems Michael Ellerman
2013-09-26 6:31 ` Michael Ellerman
2013-09-26 6:31 ` Michael Ellerman
2013-09-26 6:31 ` Michael Ellerman
2013-09-26 9:06 ` Paolo Bonzini
2013-09-26 9:06 ` Paolo Bonzini
2013-09-26 9:06 ` Paolo Bonzini
2013-09-26 9:06 ` Paolo Bonzini
2013-10-01 8:34 ` Michael Ellerman
2013-10-01 8:34 ` Michael Ellerman
2013-10-01 8:34 ` Michael Ellerman
2013-10-01 8:34 ` Michael Ellerman
2013-10-01 8:39 ` Gleb Natapov
2013-10-01 8:39 ` Gleb Natapov
2013-10-01 8:39 ` Gleb Natapov
2013-10-01 9:23 ` Paul Mackerras
2013-10-01 9:23 ` Paul Mackerras
2013-10-01 9:23 ` Paul Mackerras
2013-10-01 9:57 ` Gleb Natapov
2013-10-01 9:57 ` Gleb Natapov
2013-10-01 9:57 ` Gleb Natapov
2013-10-01 10:00 ` Alexander Graf
2013-10-01 10:00 ` Alexander Graf
2013-10-01 10:00 ` Alexander Graf
2013-10-01 9:38 ` Benjamin Herrenschmidt
2013-10-01 9:38 ` Benjamin Herrenschmidt
2013-10-01 9:38 ` Benjamin Herrenschmidt
2013-10-01 11:19 ` Paolo Bonzini
2013-10-01 11:19 ` Paolo Bonzini
2013-10-01 11:19 ` Paolo Bonzini
2013-10-01 21:44 ` Benjamin Herrenschmidt
2013-10-01 21:44 ` Benjamin Herrenschmidt
2013-10-01 21:44 ` Benjamin Herrenschmidt
2013-10-02 8:38 ` Paolo Bonzini
2013-10-02 8:38 ` Paolo Bonzini
2013-10-02 8:38 ` Paolo Bonzini
2013-10-02 5:09 ` Paul Mackerras
2013-10-02 5:09 ` Paul Mackerras
2013-10-02 5:09 ` Paul Mackerras
2013-10-02 8:46 ` Paolo Bonzini
2013-10-02 8:46 ` Paolo Bonzini
2013-10-02 8:46 ` Paolo Bonzini
2013-10-02 9:06 ` Benjamin Herrenschmidt
2013-10-02 9:06 ` Benjamin Herrenschmidt
2013-10-02 9:06 ` Benjamin Herrenschmidt
2013-10-02 9:11 ` Alexander Graf
2013-10-02 9:11 ` Alexander Graf
2013-10-02 9:11 ` Alexander Graf
2013-10-02 9:50 ` Alexander Graf
2013-10-02 9:50 ` Alexander Graf
2013-10-02 9:50 ` Alexander Graf
2013-10-02 10:02 ` Gleb Natapov
2013-10-02 10:02 ` Gleb Natapov
2013-10-02 10:02 ` Gleb Natapov
2013-10-02 13:57 ` Michael Ellerman
2013-10-02 13:57 ` Michael Ellerman
2013-10-02 13:57 ` Michael Ellerman
2013-10-02 14:08 ` Alexander Graf
2013-10-02 14:08 ` Alexander Graf
2013-10-02 14:08 ` Alexander Graf
2013-10-02 14:33 ` Paolo Bonzini
2013-10-02 14:33 ` Paolo Bonzini
2013-10-02 14:33 ` Paolo Bonzini
2013-10-02 14:36 ` Alexander Graf
2013-10-02 14:36 ` Alexander Graf
2013-10-02 14:36 ` Alexander Graf
2013-10-02 14:38 ` Paolo Bonzini
2013-10-02 14:38 ` Paolo Bonzini
2013-10-02 14:38 ` Paolo Bonzini
2013-10-02 22:45 ` Paul Mackerras
2013-10-02 22:45 ` Paul Mackerras
2013-10-02 22:45 ` Paul Mackerras
2013-10-03 5:48 ` Gleb Natapov
2013-10-03 5:48 ` Gleb Natapov
2013-10-03 5:48 ` Gleb Natapov
2013-10-03 10:06 ` Paul Mackerras
2013-10-03 10:06 ` Paul Mackerras
2013-10-03 10:06 ` Paul Mackerras
2013-10-03 12:08 ` Gleb Natapov
2013-10-03 12:08 ` Gleb Natapov
2013-10-03 12:08 ` Gleb Natapov
2013-10-02 14:37 ` Gleb Natapov
2013-10-02 14:37 ` Gleb Natapov
2013-10-02 14:37 ` Gleb Natapov
2013-10-02 22:21 ` Benjamin Herrenschmidt
2013-10-02 22:21 ` Benjamin Herrenschmidt
2013-10-02 22:21 ` Benjamin Herrenschmidt
2013-10-03 6:08 ` Gleb Natapov
2013-10-03 6:08 ` Gleb Natapov
2013-10-03 6:08 ` Gleb Natapov
2013-10-02 22:13 ` Benjamin Herrenschmidt
2013-10-02 22:13 ` Benjamin Herrenschmidt
2013-10-02 22:13 ` Benjamin Herrenschmidt
2013-10-02 14:10 ` Gleb Natapov
2013-10-02 14:10 ` Gleb Natapov
2013-10-02 14:10 ` Gleb Natapov
2013-10-02 22:15 ` Benjamin Herrenschmidt
2013-10-02 22:15 ` Benjamin Herrenschmidt
2013-10-02 22:15 ` Benjamin Herrenschmidt
2013-10-02 22:02 ` Benjamin Herrenschmidt
2013-10-02 22:02 ` Benjamin Herrenschmidt
2013-10-02 22:02 ` Benjamin Herrenschmidt
2013-10-03 5:43 ` Gleb Natapov
2013-10-03 5:43 ` Gleb Natapov
2013-10-03 5:43 ` Gleb Natapov
2013-10-03 7:22 ` Benjamin Herrenschmidt
2013-10-03 7:22 ` Benjamin Herrenschmidt
2013-10-03 7:22 ` Benjamin Herrenschmidt
2013-10-02 22:07 ` Benjamin Herrenschmidt
2013-10-02 22:07 ` Benjamin Herrenschmidt
2013-10-02 22:07 ` Benjamin Herrenschmidt
2013-10-03 6:28 ` Gleb Natapov
2013-10-03 6:28 ` Gleb Natapov
2013-10-03 6:28 ` Gleb Natapov
2013-10-02 21:58 ` Benjamin Herrenschmidt
2013-10-02 21:58 ` Benjamin Herrenschmidt
2013-10-02 21:58 ` Benjamin Herrenschmidt
2013-10-01 9:58 ` Paolo Bonzini
2013-10-01 9:58 ` Paolo Bonzini
2013-10-01 9:58 ` Paolo Bonzini
2013-10-01 9:58 ` Paolo Bonzini
2013-09-27 14:15 ` Anshuman Khandual
2013-09-27 14:27 ` Anshuman Khandual
2013-09-27 14:15 ` Anshuman Khandual
2013-09-27 14:15 ` Anshuman Khandual
2013-10-01 8:36 ` Michael Ellerman
2013-10-01 8:36 ` Michael Ellerman
2013-10-01 8:36 ` Michael Ellerman
2013-10-01 8:36 ` Michael Ellerman
2013-09-26 7:58 ` [PATCH 1/3] powerpc: Implement arch_get_random_long/int() for powernv Benjamin Herrenschmidt
2013-09-26 7:58 ` Benjamin Herrenschmidt
2013-09-26 7:58 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2013-10-11 3:07 Michael Ellerman
2013-10-11 3:07 ` [PATCH 2/3] hwrng: Add a driver for the hwrng found in power7+ systems Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1380182487.28561.22.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=agraf@suse.de \
--cc=gleb@redhat.com \
--cc=herbert@gondor.hengli.com.au \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=mpm@selenic.com \
--cc=paulus@samba.org \
--cc=pbonzini@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.