From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@linaro.org>,
Simon Horman <horms@verge.net.au>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-sh@vger.kernel.org, devicetree@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH/RFC v4] ARM: shmobile: armadillo800eva-reference: add SDHI and MMCIF interfaces
Date: Mon, 30 Sep 2013 11:10:34 +0000 [thread overview]
Message-ID: <138071238.VjAY8SX7B8@avalon> (raw)
In-Reply-To: <CACRpkdbtQy16waQnp2Os0bx5f0AGigHJysMcJnga+FsMEN27iA@mail.gmail.com>
Hi Linus,
[Updated the devicetree mailing list e-mail address]
On Monday 30 September 2013 01:20:46 Linus Walleij wrote:
> On Sun, Sep 29, 2013 at 8:49 AM, Laurent Pinchart wrote:
> > On Friday 27 September 2013 16:08:31 Linus Walleij wrote:
> >> Can't you just locate the node using of_find_node_by_path()
> >> or whatever and then use this:
> >> int of_update_property(struct device_node *np, struct property *newprop)?
> >
> > Where can I do that ? I need the PFC/GPIO devices to have been probed, so
> > board init isn't an option, but I also need the device to be enabled not
> > to have been probed yet.
> >
> > One option would be to use a bus notifier to find out when the PFC/GPIO
> > devices are available, and extend of_update_property() with a notification
> > mechanism (either generic, or specific to the enabled propery) to detect
> > when a device gets enabled and probe it.
>
> Argh that sounds awfully complicated...
>
> I would consider doing this right inside the PCF/GPIO driver right at the
> end of its probe function. As it is related to pins anyway... or is that too
> ugly?
As a reminder, we need to decide whether to register an SDHI (SD controller)
device or a WiFi module device, and thus configure pinmuxing appropriately,
based on the state of a GPIO connected to a user-accessible switch. This
behaviour is board-specific, not SoC-specific. That's why I believe the code
should be in board code.
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Rob Herring <rob.herring@calxeda.com>,
Grant Likely <grant.likely@linaro.org>,
Simon Horman <horms@verge.net.au>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-sh@vger.kernel.org, devicetree@vger.kernel.org,
Magnus Damm <magnus.damm@gmail.com>
Subject: Re: [PATCH/RFC v4] ARM: shmobile: armadillo800eva-reference: add SDHI and MMCIF interfaces
Date: Mon, 30 Sep 2013 13:10:34 +0200 [thread overview]
Message-ID: <138071238.VjAY8SX7B8@avalon> (raw)
In-Reply-To: <CACRpkdbtQy16waQnp2Os0bx5f0AGigHJysMcJnga+FsMEN27iA@mail.gmail.com>
Hi Linus,
[Updated the devicetree mailing list e-mail address]
On Monday 30 September 2013 01:20:46 Linus Walleij wrote:
> On Sun, Sep 29, 2013 at 8:49 AM, Laurent Pinchart wrote:
> > On Friday 27 September 2013 16:08:31 Linus Walleij wrote:
> >> Can't you just locate the node using of_find_node_by_path()
> >> or whatever and then use this:
> >> int of_update_property(struct device_node *np, struct property *newprop)?
> >
> > Where can I do that ? I need the PFC/GPIO devices to have been probed, so
> > board init isn't an option, but I also need the device to be enabled not
> > to have been probed yet.
> >
> > One option would be to use a bus notifier to find out when the PFC/GPIO
> > devices are available, and extend of_update_property() with a notification
> > mechanism (either generic, or specific to the enabled propery) to detect
> > when a device gets enabled and probe it.
>
> Argh that sounds awfully complicated...
>
> I would consider doing this right inside the PCF/GPIO driver right at the
> end of its probe function. As it is related to pins anyway... or is that too
> ugly?
As a reminder, we need to decide whether to register an SDHI (SD controller)
device or a WiFi module device, and thus configure pinmuxing appropriately,
based on the state of a GPIO connected to a user-accessible switch. This
behaviour is board-specific, not SoC-specific. That's why I believe the code
should be in board code.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-09-30 11:10 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 15:38 [PATCH/RFC v4] ARM: shmobile: armadillo800eva-reference: add SDHI and MMCIF interfaces Guennadi Liakhovetski
2013-09-25 5:36 ` Simon Horman
[not found] ` <20130925053636.GD1916-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>
2013-09-25 7:03 ` Simon Horman
2013-09-25 7:03 ` Simon Horman
2013-09-25 9:05 ` Laurent Pinchart
2013-09-26 7:46 ` Linus Walleij
2013-09-26 8:24 ` Guennadi Liakhovetski
2013-09-26 9:41 ` Magnus Damm
2013-09-26 9:57 ` Guennadi Liakhovetski
2013-09-26 10:17 ` Magnus Damm
2013-09-27 0:55 ` Laurent Pinchart
2013-09-27 14:08 ` Linus Walleij
2013-09-29 6:49 ` Laurent Pinchart
2013-09-29 23:20 ` Linus Walleij
2013-09-30 11:10 ` Laurent Pinchart [this message]
2013-09-30 11:10 ` Laurent Pinchart
2013-10-08 11:19 ` Linus Walleij
2013-10-08 11:19 ` Linus Walleij
2013-10-08 14:32 ` Laurent Pinchart
2013-10-08 14:32 ` Laurent Pinchart
2013-09-30 13:15 ` Grant Likely
2013-09-30 14:38 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=138071238.VjAY8SX7B8@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=g.liakhovetski@gmx.de \
--cc=grant.likely@linaro.org \
--cc=horms@verge.net.au \
--cc=linus.walleij@linaro.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.