All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <matthew.garrett@nebula.com>
To: "corentin.chary@gmail.com" <corentin.chary@gmail.com>
Cc: "acpi4asus-user@lists.sourceforge.net"
	<acpi4asus-user@lists.sourceforge.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"felipe.contreras@gmail.com" <felipe.contreras@gmail.com>,
	"platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v2] platform: x86: asus-wmi: add fan control
Date: Thu, 10 Oct 2013 16:06:40 +0000	[thread overview]
Message-ID: <1381421199.4248.2.camel@x230.lan> (raw)
In-Reply-To: <CAHR064ge8zew7uMeD+_LXR3ju5ARGG1y8utLOFzOLexny_DPLA@mail.gmail.com>

On Thu, 2013-10-10 at 16:59 +0100, Corentin Chary wrote:

> 
> This doesn't really seems to be related to wmi, and is likely to be
> available only on a subset of models. Maybe it should a separate
> driver instead ?

This version seems to be implemented entirely in WMI, and it's using the
same WMI GUID as asus-wmi - implementing it here seems appropriate. I am
concerned about the phys/virt thing, though. The ACPI interpreter is
running in the kernel, not the hardware - are we artificially limiting
SystemMemory opregions to physical addresses?

-- 
Matthew Garrett <matthew.garrett@nebula.com>

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Garrett <matthew.garrett@nebula.com>
To: "corentin.chary@gmail.com" <corentin.chary@gmail.com>
Cc: "acpi4asus-user@lists.sourceforge.net" 
	<acpi4asus-user@lists.sourceforge.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"felipe.contreras@gmail.com" <felipe.contreras@gmail.com>,
	"platform-driver-x86@vger.kernel.org" 
	<platform-driver-x86@vger.kernel.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v2] platform: x86: asus-wmi: add fan control
Date: Thu, 10 Oct 2013 16:06:40 +0000	[thread overview]
Message-ID: <1381421199.4248.2.camel@x230.lan> (raw)
In-Reply-To: <CAHR064ge8zew7uMeD+_LXR3ju5ARGG1y8utLOFzOLexny_DPLA@mail.gmail.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 760 bytes --]

On Thu, 2013-10-10 at 16:59 +0100, Corentin Chary wrote:

> 
> This doesn't really seems to be related to wmi, and is likely to be
> available only on a subset of models. Maybe it should a separate
> driver instead ?

This version seems to be implemented entirely in WMI, and it's using the
same WMI GUID as asus-wmi - implementing it here seems appropriate. I am
concerned about the phys/virt thing, though. The ACPI interpreter is
running in the kernel, not the hardware - are we artificially limiting
SystemMemory opregions to physical addresses?

-- 
Matthew Garrett <matthew.garrett@nebula.com>
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

  parent reply	other threads:[~2013-10-10 16:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-08 12:48 [PATCH v2] platform: x86: asus-wmi: add fan control Felipe Contreras
2013-10-08 12:57 ` Felipe Contreras
     [not found] ` <CAHR064ge8zew7uMeD+_LXR3ju5ARGG1y8utLOFzOLexny_DPLA@mail.gmail.com>
2013-10-10 16:06   ` Matthew Garrett [this message]
2013-10-10 16:06     ` Matthew Garrett
2013-10-13  9:29     ` Felipe Contreras
2013-10-13 15:17       ` Matthew Garrett
2013-10-14  2:31         ` Felipe Contreras
2013-10-14 15:52           ` Matthew Garrett
2013-10-14 23:18             ` Felipe Contreras
2013-10-14 23:22               ` Matthew Garrett
2013-10-14 23:27                 ` Felipe Contreras
2013-10-14 23:34                   ` Matthew Garrett
2013-10-15  0:22                     ` Felipe Contreras
2013-10-13  8:49   ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1381421199.4248.2.camel@x230.lan \
    --to=matthew.garrett@nebula.com \
    --cc=acpi4asus-user@lists.sourceforge.net \
    --cc=corentin.chary@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.