From: Peter Lieven <pl@kamp.de>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com, Peter Lieven <pl@kamp.de>,
ronniesahlberg@gmail.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCHv7 05/17] block: add wrappers for logical block provisioning information
Date: Thu, 24 Oct 2013 12:06:54 +0200 [thread overview]
Message-ID: <1382609227-23989-6-git-send-email-pl@kamp.de> (raw)
In-Reply-To: <1382609227-23989-1-git-send-email-pl@kamp.de>
This adds 2 wrappers to read the unallocated_blocks_are_zero and
can_write_zeroes_with_unmap info from the BDI. The wrappers are
required to check for the existence of a backing_hd and
if the devices are opened with the correct flags.
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Peter Lieven <pl@kamp.de>
---
block.c | 30 ++++++++++++++++++++++++++++++
include/block/block.h | 2 ++
2 files changed, 32 insertions(+)
diff --git a/block.c b/block.c
index 0d97ce6..0601b02 100644
--- a/block.c
+++ b/block.c
@@ -3094,6 +3094,36 @@ int bdrv_has_zero_init(BlockDriverState *bs)
return 0;
}
+bool bdrv_unallocated_blocks_are_zero(BlockDriverState *bs)
+{
+ BlockDriverInfo bdi;
+
+ if (bs->backing_hd) {
+ return false;
+ }
+
+ if (bdrv_get_info(bs, &bdi) == 0) {
+ return bdi.unallocated_blocks_are_zero;
+ }
+
+ return false;
+}
+
+bool bdrv_can_write_zeroes_with_unmap(BlockDriverState *bs)
+{
+ BlockDriverInfo bdi;
+
+ if (bs->backing_hd || !(bs->open_flags & BDRV_O_UNMAP)) {
+ return false;
+ }
+
+ if (bdrv_get_info(bs, &bdi) == 0) {
+ return bdi.can_write_zeroes_with_unmap;
+ }
+
+ return false;
+}
+
typedef struct BdrvCoGetBlockStatusData {
BlockDriverState *bs;
BlockDriverState *base;
diff --git a/include/block/block.h b/include/block/block.h
index 9c76967..803c5ca 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -344,6 +344,8 @@ int bdrv_discard(BlockDriverState *bs, int64_t sector_num, int nb_sectors);
int bdrv_co_discard(BlockDriverState *bs, int64_t sector_num, int nb_sectors);
int bdrv_has_zero_init_1(BlockDriverState *bs);
int bdrv_has_zero_init(BlockDriverState *bs);
+bool bdrv_unallocated_blocks_are_zero(BlockDriverState *bs);
+bool bdrv_can_write_zeroes_with_unmap(BlockDriverState *bs);
int64_t bdrv_get_block_status(BlockDriverState *bs, int64_t sector_num,
int nb_sectors, int *pnum);
int bdrv_is_allocated(BlockDriverState *bs, int64_t sector_num, int nb_sectors,
--
1.7.9.5
next prev parent reply other threads:[~2013-10-24 10:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 10:06 [Qemu-devel] [PATCHv7 00/17] block: logical block provisioning enhancements Peter Lieven
2013-10-24 10:06 ` [Qemu-devel] [PATCHv7 01/17] block: make BdrvRequestFlags public Peter Lieven
2013-10-24 10:06 ` [Qemu-devel] [PATCHv7 02/17] block: add flags to bdrv_*_write_zeroes Peter Lieven
2013-10-24 10:06 ` [Qemu-devel] [PATCHv7 03/17] block: introduce BDRV_REQ_MAY_UNMAP request flag Peter Lieven
2013-10-24 10:06 ` [Qemu-devel] [PATCHv7 04/17] block: add logical block provisioning info to BlockDriverInfo Peter Lieven
2013-10-24 10:06 ` Peter Lieven [this message]
2013-10-24 10:06 ` [Qemu-devel] [PATCHv7 06/17] block/iscsi: add .bdrv_get_info Peter Lieven
2013-10-24 10:06 ` [Qemu-devel] [PATCHv7 07/17] block: add BlockLimits structure to BlockDriverState Peter Lieven
2013-10-24 10:06 ` [Qemu-devel] [PATCHv7 08/17] block/raw: copy BlockLimits on raw_open Peter Lieven
2013-10-24 10:06 ` [Qemu-devel] [PATCHv7 09/17] block: honour BlockLimits in bdrv_co_do_write_zeroes Peter Lieven
2013-10-24 10:06 ` [Qemu-devel] [PATCHv7 10/17] block: honour BlockLimits in bdrv_co_discard Peter Lieven
2013-11-11 13:20 ` Kevin Wolf
2013-11-12 8:53 ` Peter Lieven
2013-11-12 9:19 ` Paolo Bonzini
2013-11-12 9:21 ` Peter Lieven
2013-11-12 9:45 ` Kevin Wolf
2013-10-24 10:07 ` [Qemu-devel] [PATCHv7 11/17] iscsi: set limits in BlockDriverState Peter Lieven
2013-10-24 10:07 ` [Qemu-devel] [PATCHv7 12/17] iscsi: simplify iscsi_co_discard Peter Lieven
2013-10-24 10:07 ` [Qemu-devel] [PATCHv7 13/17] iscsi: add bdrv_co_write_zeroes Peter Lieven
2013-10-24 10:07 ` [Qemu-devel] [PATCHv7 14/17] block: introduce bdrv_make_zero Peter Lieven
2013-10-24 10:07 ` [Qemu-devel] [PATCHv7 15/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks Peter Lieven
2013-10-24 10:07 ` [Qemu-devel] [PATCHv7 16/17] qemu-img: add support for fully allocated images Peter Lieven
2013-10-24 10:07 ` [Qemu-devel] [PATCHv7 17/17] qemu-img: conditionally zero out target on convert Peter Lieven
2013-10-24 14:20 ` [Qemu-devel] [PATCHv7 00/17] block: logical block provisioning enhancements Paolo Bonzini
2013-11-06 13:08 ` Stefan Hajnoczi
2013-11-06 13:09 ` Paolo Bonzini
2013-11-06 19:38 ` Peter Lieven
2013-11-06 21:16 ` Paolo Bonzini
2013-11-08 17:52 ` ronnie sahlberg
2013-11-08 18:03 ` ronnie sahlberg
2013-11-08 19:29 ` Peter Lieven
2013-11-08 19:28 ` Peter Lieven
2013-11-06 19:36 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1382609227-23989-6-git-send-email-pl@kamp.de \
--to=pl@kamp.de \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.