From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Lieven <pl@kamp.de>
Cc: kwolf@redhat.com, Stefan Hajnoczi <stefanha@gmail.com>,
stefanha@redhat.com, qemu-devel@nongnu.org,
ronniesahlberg@gmail.com
Subject: Re: [Qemu-devel] [PATCHv7 00/17] block: logical block provisioning enhancements
Date: Wed, 06 Nov 2013 22:16:27 +0100 [thread overview]
Message-ID: <527AB1AB.5000404@redhat.com> (raw)
In-Reply-To: <2B1D10CE-E165-4393-94EB-6804C88BAFFC@kamp.de>
Il 06/11/2013 20:38, Peter Lieven ha scritto:
>
> Am 06.11.2013 um 14:09 schrieb Paolo Bonzini <pbonzini@redhat.com>:
>
>> Il 06/11/2013 14:08, Stefan Hajnoczi ha scritto:
>>> Thanks, applied to my block-next tree:
>>> https://github.com/stefanha/qemu/commits/block-next
>>>
>>> This will go into QEMU 1.8. Since it's a new feature that touches core
>>> block layer code and several block drivers, I can't merge it into
>>> 1.7-rc.
>>
>> Yay! With these patches I can properly emulate WRITE SAME in the SCSI
>> layer.
>
> Yes, you can, but only when write same is used to write zeroes. The other
> case is still unhandled or needs emulation.
WRITE SAME with UNMAP is incorrect in the current QEMU code. Your patch
let me fix it so that the payload can be read back with no change, *and*
sectors are unmapped when possible.
Paolo
next prev parent reply other threads:[~2013-11-06 21:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-24 10:06 [Qemu-devel] [PATCHv7 00/17] block: logical block provisioning enhancements Peter Lieven
2013-10-24 10:06 ` [Qemu-devel] [PATCHv7 01/17] block: make BdrvRequestFlags public Peter Lieven
2013-10-24 10:06 ` [Qemu-devel] [PATCHv7 02/17] block: add flags to bdrv_*_write_zeroes Peter Lieven
2013-10-24 10:06 ` [Qemu-devel] [PATCHv7 03/17] block: introduce BDRV_REQ_MAY_UNMAP request flag Peter Lieven
2013-10-24 10:06 ` [Qemu-devel] [PATCHv7 04/17] block: add logical block provisioning info to BlockDriverInfo Peter Lieven
2013-10-24 10:06 ` [Qemu-devel] [PATCHv7 05/17] block: add wrappers for logical block provisioning information Peter Lieven
2013-10-24 10:06 ` [Qemu-devel] [PATCHv7 06/17] block/iscsi: add .bdrv_get_info Peter Lieven
2013-10-24 10:06 ` [Qemu-devel] [PATCHv7 07/17] block: add BlockLimits structure to BlockDriverState Peter Lieven
2013-10-24 10:06 ` [Qemu-devel] [PATCHv7 08/17] block/raw: copy BlockLimits on raw_open Peter Lieven
2013-10-24 10:06 ` [Qemu-devel] [PATCHv7 09/17] block: honour BlockLimits in bdrv_co_do_write_zeroes Peter Lieven
2013-10-24 10:06 ` [Qemu-devel] [PATCHv7 10/17] block: honour BlockLimits in bdrv_co_discard Peter Lieven
2013-11-11 13:20 ` Kevin Wolf
2013-11-12 8:53 ` Peter Lieven
2013-11-12 9:19 ` Paolo Bonzini
2013-11-12 9:21 ` Peter Lieven
2013-11-12 9:45 ` Kevin Wolf
2013-10-24 10:07 ` [Qemu-devel] [PATCHv7 11/17] iscsi: set limits in BlockDriverState Peter Lieven
2013-10-24 10:07 ` [Qemu-devel] [PATCHv7 12/17] iscsi: simplify iscsi_co_discard Peter Lieven
2013-10-24 10:07 ` [Qemu-devel] [PATCHv7 13/17] iscsi: add bdrv_co_write_zeroes Peter Lieven
2013-10-24 10:07 ` [Qemu-devel] [PATCHv7 14/17] block: introduce bdrv_make_zero Peter Lieven
2013-10-24 10:07 ` [Qemu-devel] [PATCHv7 15/17] block/get_block_status: fix BDRV_BLOCK_ZERO for unallocated blocks Peter Lieven
2013-10-24 10:07 ` [Qemu-devel] [PATCHv7 16/17] qemu-img: add support for fully allocated images Peter Lieven
2013-10-24 10:07 ` [Qemu-devel] [PATCHv7 17/17] qemu-img: conditionally zero out target on convert Peter Lieven
2013-10-24 14:20 ` [Qemu-devel] [PATCHv7 00/17] block: logical block provisioning enhancements Paolo Bonzini
2013-11-06 13:08 ` Stefan Hajnoczi
2013-11-06 13:09 ` Paolo Bonzini
2013-11-06 19:38 ` Peter Lieven
2013-11-06 21:16 ` Paolo Bonzini [this message]
2013-11-08 17:52 ` ronnie sahlberg
2013-11-08 18:03 ` ronnie sahlberg
2013-11-08 19:29 ` Peter Lieven
2013-11-08 19:28 ` Peter Lieven
2013-11-06 19:36 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=527AB1AB.5000404@redhat.com \
--to=pbonzini@redhat.com \
--cc=kwolf@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
--cc=stefanha@gmail.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.