All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Andrea Adami <andrea.adami@gmail.com>
Cc: openembeded-devel <openembedded-devel@lists.openembedded.org>,
	openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] bitbake.conf: Default DISTRO to nodistro
Date: Fri, 08 Nov 2013 09:47:41 +0000	[thread overview]
Message-ID: <1383904061.6271.297.camel@ted> (raw)
In-Reply-To: <CAAQYJAuMoE6gOMmM2trSN1MY7weCF+07JAJuhQu1K=p5KxO=Yg@mail.gmail.com>

On Fri, 2013-11-08 at 10:33 +0100, Andrea Adami wrote:
> On Fri, Nov 8, 2013 at 10:25 AM, Burton, Ross <ross.burton@intel.com> wrote:
> > On 7 November 2013 23:18, Richard Purdie
> > <richard.purdie@linuxfoundation.org> wrote:
> >> +DISTRO ??= "nodistro"
> >
> > Wouldn't "oe-core" be a better name, considering that's what
> > DISTROVERSION becomes if DISTRO is unset?
> >
> > Ross
> 
> 
> Agreed, we already have DISTRO_VERSION = "oe-core.0"
> This sounds also the right name for THE default distro.

I disagree and I feel quite strongly about this. OE-Core is not a
distro. The whole idea was that OE-Core should build with sane defaults
without any distro set. This is a dummy placeholder value and it really
does mean to say that no distro is set.

We did put a value into the DISTRO_VERSION field so you could tell what
was being used but again its a placeholder.

So in my view "nodistro" is clearer about what is meant.

Cheers,

Richard







WARNING: multiple messages have this Message-ID (diff)
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Andrea Adami <andrea.adami@gmail.com>
Cc: openembeded-devel <openembedded-devel@lists.openembedded.org>,
	openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH] bitbake.conf: Default DISTRO to nodistro
Date: Fri, 08 Nov 2013 09:47:41 +0000	[thread overview]
Message-ID: <1383904061.6271.297.camel@ted> (raw)
In-Reply-To: <CAAQYJAuMoE6gOMmM2trSN1MY7weCF+07JAJuhQu1K=p5KxO=Yg@mail.gmail.com>

On Fri, 2013-11-08 at 10:33 +0100, Andrea Adami wrote:
> On Fri, Nov 8, 2013 at 10:25 AM, Burton, Ross <ross.burton@intel.com> wrote:
> > On 7 November 2013 23:18, Richard Purdie
> > <richard.purdie@linuxfoundation.org> wrote:
> >> +DISTRO ??= "nodistro"
> >
> > Wouldn't "oe-core" be a better name, considering that's what
> > DISTROVERSION becomes if DISTRO is unset?
> >
> > Ross
> 
> 
> Agreed, we already have DISTRO_VERSION = "oe-core.0"
> This sounds also the right name for THE default distro.

I disagree and I feel quite strongly about this. OE-Core is not a
distro. The whole idea was that OE-Core should build with sane defaults
without any distro set. This is a dummy placeholder value and it really
does mean to say that no distro is set.

We did put a value into the DISTRO_VERSION field so you could tell what
was being used but again its a placeholder.

So in my view "nodistro" is clearer about what is meant.

Cheers,

Richard







  reply	other threads:[~2013-11-08  9:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07 23:18 [PATCH] bitbake.conf: Default DISTRO to nodistro Richard Purdie
2013-11-08  9:25 ` Burton, Ross
2013-11-08  9:33   ` Andrea Adami
2013-11-08  9:33     ` [OE-core] " Andrea Adami
2013-11-08  9:47     ` Richard Purdie [this message]
2013-11-08  9:47       ` Richard Purdie
2013-11-08 11:23       ` Martin Jansa
2013-11-08 11:23         ` [OE-core] " Martin Jansa
2013-11-08 11:58         ` Otavio Salvador
2013-11-08 11:58           ` [OE-core] " Otavio Salvador
2013-11-08 11:58       ` Otavio Salvador
2013-11-08 11:58         ` [OE-core] " Otavio Salvador
2013-11-08 15:33       ` Mark Hatle
2013-11-08 16:28       ` Khem Raj
2013-11-08 16:28         ` [OE-core] " Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1383904061.6271.297.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=andrea.adami@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.