All of lore.kernel.org
 help / color / mirror / Atom feed
From: dinguyen@altera.com (Dinh Nguyen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 4/4] arm: socfgpa: make use of common scu_a9_get_base() interface
Date: Mon, 11 Nov 2013 17:24:55 -0600	[thread overview]
Message-ID: <1384212295.3765.0.camel@linux-builds1> (raw)
In-Reply-To: <1383794204-4714-5-git-send-email-jszhang@marvell.com>

On Thu, 2013-11-07 at 11:16 +0800, Jisheng Zhang wrote:
> Make use of common scu_a9_get_base() and delete the comment since the
> interface is self commented.
> 
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
>  arch/arm/mach-socfpga/socfpga.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-socfpga/socfpga.c b/arch/arm/mach-socfpga/socfpga.c
> index bfce964..b695887 100644
> --- a/arch/arm/mach-socfpga/socfpga.c
> +++ b/arch/arm/mach-socfpga/socfpga.c
> @@ -24,6 +24,7 @@
>  #include <asm/hardware/cache-l2x0.h>
>  #include <asm/mach/arch.h>
>  #include <asm/mach/map.h>
> +#include <asm/smp_scu.h>
>  
>  #include "core.h"
>  
> @@ -51,8 +52,7 @@ static void __init socfpga_scu_map_io(void)
>  {
>  	unsigned long base;
>  
> -	/* Get SCU base */
> -	asm("mrc p15, 4, %0, c15, c0, 0" : "=r" (base));
> +	base = scu_a9_get_base();
>  
>  	scu_io_desc.pfn = __phys_to_pfn(base);
>  	iotable_init(&scu_io_desc, 1);

Acked-by: Dinh Nguyen <dinguyen@altera.com>

Thanks,

WARNING: multiple messages have this Message-ID (diff)
From: Dinh Nguyen <dinguyen@altera.com>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: <rob.herring@calxeda.com>, <linux@arm.linux.org.uk>,
	<kernel@pengutronix.de>, <baohua@kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 4/4] arm: socfgpa: make use of common scu_a9_get_base() interface
Date: Mon, 11 Nov 2013 17:24:55 -0600	[thread overview]
Message-ID: <1384212295.3765.0.camel@linux-builds1> (raw)
In-Reply-To: <1383794204-4714-5-git-send-email-jszhang@marvell.com>

On Thu, 2013-11-07 at 11:16 +0800, Jisheng Zhang wrote:
> Make use of common scu_a9_get_base() and delete the comment since the
> interface is self commented.
> 
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> ---
>  arch/arm/mach-socfpga/socfpga.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-socfpga/socfpga.c b/arch/arm/mach-socfpga/socfpga.c
> index bfce964..b695887 100644
> --- a/arch/arm/mach-socfpga/socfpga.c
> +++ b/arch/arm/mach-socfpga/socfpga.c
> @@ -24,6 +24,7 @@
>  #include <asm/hardware/cache-l2x0.h>
>  #include <asm/mach/arch.h>
>  #include <asm/mach/map.h>
> +#include <asm/smp_scu.h>
>  
>  #include "core.h"
>  
> @@ -51,8 +52,7 @@ static void __init socfpga_scu_map_io(void)
>  {
>  	unsigned long base;
>  
> -	/* Get SCU base */
> -	asm("mrc p15, 4, %0, c15, c0, 0" : "=r" (base));
> +	base = scu_a9_get_base();
>  
>  	scu_io_desc.pfn = __phys_to_pfn(base);
>  	iotable_init(&scu_io_desc, 1);

Acked-by: Dinh Nguyen <dinguyen@altera.com>

Thanks,




  reply	other threads:[~2013-11-11 23:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-07  3:16 [PATCH V2 0/4] arm: make use of common scu_a9_get_base() interface Jisheng Zhang
2013-11-07  3:16 ` Jisheng Zhang
2013-11-07  3:16 ` [PATCH V2 1/4] arm: highbank: " Jisheng Zhang
2013-11-07  3:16   ` Jisheng Zhang
2013-11-07  3:16 ` [PATCH V2 2/4] arm: imx: " Jisheng Zhang
2013-11-07  3:16   ` Jisheng Zhang
2013-11-07  3:16 ` [PATCH V2 3/4] arm: prima2: " Jisheng Zhang
2013-11-07  3:16   ` Jisheng Zhang
2013-11-07  3:16 ` [PATCH V2 4/4] arm: socfgpa: " Jisheng Zhang
2013-11-07  3:16   ` Jisheng Zhang
2013-11-11 23:24   ` Dinh Nguyen [this message]
2013-11-11 23:24     ` Dinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1384212295.3765.0.camel@linux-builds1 \
    --to=dinguyen@altera.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.