From: Scott Wood <scottwood-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
To: Haiying Wang <Haiying.Wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
Cc: Varun Sethi <Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: Re: [PATCH] iommu/fsl_pamu: use physical cpu index to find the matched cpu nodes
Date: Thu, 14 Nov 2013 16:10:25 -0600 [thread overview]
Message-ID: <1384467025.1403.210.camel@snotra.buserror.net> (raw)
In-Reply-To: <1384457440.2144.15.camel@haiying-laptop>
On Thu, 2013-11-14 at 14:30 -0500, Haiying Wang wrote:
> In the case we miss to bring up some cpus, we need to make sure we can
> find the correct cpu nodes in the device tree based on the given logical
> cpu index from the caller.
>
> Signed-off-by: Haiying Wang <Haiying.Wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
> ---
> drivers/iommu/fsl_pamu.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c
> index cba0498..a9ab57b 100644
> --- a/drivers/iommu/fsl_pamu.c
> +++ b/drivers/iommu/fsl_pamu.c
> @@ -539,6 +539,7 @@ u32 get_stash_id(u32 stash_dest_hint, u32 vcpu)
Should probably also s/vcpu/cpu/g as vcpu makes no sense outside of
virtualization code.
> u32 cache_level;
> int len, found = 0;
> int i;
> + u32 cpuid = get_hard_smp_processor_id(vcpu);
s/cpuid/phys_cpu/ or similar
-Scott
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Haiying Wang <Haiying.Wang@freescale.com>
Cc: Varun Sethi <Varun.Sethi@freescale.com>,
joro@8bytes.org, linuxppc-dev@lists.ozlabs.org,
iommu@lists.linux-foundation.org
Subject: Re: [PATCH] iommu/fsl_pamu: use physical cpu index to find the matched cpu nodes
Date: Thu, 14 Nov 2013 16:10:25 -0600 [thread overview]
Message-ID: <1384467025.1403.210.camel@snotra.buserror.net> (raw)
In-Reply-To: <1384457440.2144.15.camel@haiying-laptop>
On Thu, 2013-11-14 at 14:30 -0500, Haiying Wang wrote:
> In the case we miss to bring up some cpus, we need to make sure we can
> find the correct cpu nodes in the device tree based on the given logical
> cpu index from the caller.
>
> Signed-off-by: Haiying Wang <Haiying.Wang@freescale.com>
> ---
> drivers/iommu/fsl_pamu.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c
> index cba0498..a9ab57b 100644
> --- a/drivers/iommu/fsl_pamu.c
> +++ b/drivers/iommu/fsl_pamu.c
> @@ -539,6 +539,7 @@ u32 get_stash_id(u32 stash_dest_hint, u32 vcpu)
Should probably also s/vcpu/cpu/g as vcpu makes no sense outside of
virtualization code.
> u32 cache_level;
> int len, found = 0;
> int i;
> + u32 cpuid = get_hard_smp_processor_id(vcpu);
s/cpuid/phys_cpu/ or similar
-Scott
next prev parent reply other threads:[~2013-11-14 22:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 19:30 [PATCH] iommu/fsl_pamu: use physical cpu index to find the matched cpu nodes Haiying Wang
2013-11-14 19:30 ` Haiying Wang
2013-11-14 22:10 ` Scott Wood [this message]
2013-11-14 22:10 ` Scott Wood
[not found] ` <1384467025.1403.210.camel-88ow+0ZRuxG2UiBs7uKeOtHuzzzSOjJt@public.gmane.org>
2013-11-15 3:16 ` Varun Sethi
2013-11-15 3:16 ` Varun Sethi
[not found] ` <C5ECD7A89D1DC44195F34B25E172658D0A5B0AE8-RL0Hj/+nBVDAtPZc1oz0FK4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2013-11-18 19:37 ` Scott Wood
2013-11-18 19:37 ` Scott Wood
[not found] ` <1384803449.1403.313.camel-88ow+0ZRuxG2UiBs7uKeOtHuzzzSOjJt@public.gmane.org>
2013-11-19 2:42 ` Varun Sethi
2013-11-19 2:42 ` Varun Sethi
[not found] ` <C5ECD7A89D1DC44195F34B25E172658D0A5B966D-RL0Hj/+nBVDAtPZc1oz0FK4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2013-11-19 3:04 ` Scott Wood
2013-11-19 3:04 ` Scott Wood
[not found] ` <1384830256.1403.340.camel-88ow+0ZRuxG2UiBs7uKeOtHuzzzSOjJt@public.gmane.org>
2013-11-19 3:09 ` Varun Sethi
2013-11-19 3:09 ` Varun Sethi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1384467025.1403.210.camel@snotra.buserror.net \
--to=scottwood-kzfg59tc24xl57midrcfdg@public.gmane.org \
--cc=Haiying.Wang-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.