Re: [tpmdd-devel] [PATCH 1/5 v2] tpm: Pull everything related to /dev/tpmX into tpm-dev.c

[Ashley Lai <adlai@linux.vnet.ibm.com>]

Nice clean up!!! The code looks much more clean after removing the
duplicated code in all drivers.  Thanks.


> diff --git a/drivers/char/tpm/tpm-dev.c b/drivers/char/tpm/tpm-dev.c
> new file mode 100644
> index 0000000..8d94e97
> --- /dev/null
> +++ b/drivers/char/tpm/tpm-dev.c
> + * Copyright (C) 2013 Obsidian Reearch Corp

Typo Research?

> + * Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> + *

> +
> +int tpm_dev_add_device(struct tpm_chip *chip)
> +{

> +	rc = misc_register(&chip->vendor.miscdev);
> +	if (rc) {
> +		chip->vendor.miscdev.name = NULL;
> +		dev_warn(chip->dev,

Any reason why we use dev_warn here instead of dev_err?

> +			"unable to misc_register %s, minor %d err=%d\n",
> +			 chip->vendor.miscdev.name,
> +			 chip->vendor.miscdev.minor, rc);
> +	}
> +	return rc;
> +}
> +

Reviewed-by: Ashley Lai <adlai@linux.vnet.ibm.com>

Regards,
--Ashley Lai