Re: [tpmdd-devel] [PATCH 1/5 v2] tpm: Pull everything related to /dev/tpmX into tpm-dev.c

[Jason Gunthorpe <jgunthorpe@obsidianresearch.com>]

On Sat, Nov 16, 2013 at 04:18:55PM -0600, Ashley Lai wrote:
> Nice clean up!!! The code looks much more clean after removing the
> duplicated code in all drivers.  Thanks.

> > +++ b/drivers/char/tpm/tpm-dev.c
> > + * Copyright (C) 2013 Obsidian Reearch Corp
> 
> Typo Research?

Yes, thanks :)
 
> > + * Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> > + *
> 
> > +
> > +int tpm_dev_add_device(struct tpm_chip *chip)
> > +{
> 
> > +	rc = misc_register(&chip->vendor.miscdev);
> > +	if (rc) {
> > +		chip->vendor.miscdev.name = NULL;
> > +		dev_warn(chip->dev,
> 
> Any reason why we use dev_warn here instead of dev_err?

Indeed, it was dev_err before I moved it. 

Hmm, it has been so long.. I think an earlier draft had
tpm_dev_add_device return void (like in other subsystems), so warn
made more sense. However I eventually changed it to propogate errors,
and didn't catch the flip.

Lets put it back.

Thanks!
Jason