Re: [PATCH v3 1/7] xen: vNUMA support for PV guests

[Dario Faggioli <dario.faggioli@citrix.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1825 bytes --]

On lun, 2013-11-18 at 15:24 -0500, Elena Ufimtseva wrote:
> Signed-off-by: Elena Ufimtseva <ufimtseva@gmail.com>

> diff --git a/xen/common/domctl.c b/xen/common/domctl.c
> index 904d27b..af6ae9b 100644

> @@ -889,6 +890,84 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
>      }
>      break;
>  
> +    case XEN_DOMCTL_setvnumainfo:
> +    {
> +        unsigned int dist_size, nr_vnodes;
> +        
> +        ret = -EINVAL;
> +        
> +        /* 
> +         * If number of vnodes was set before,
> +         * dont initilize it again.
> +         */
> +        //ASSERT(d->vnuma.nr_vnodes > 0);
>
Kill this? :-P

Apart from this, most of my comments to previous round have been
addressed, but I think some of the ones Jan provided haven't.

Elena, can you double check?

http://bugs.xenproject.org/xen/mid/%3C5285EE480200007800103692@nat28.tlf.novell.com%3E

> diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
> index a057069..77853e8 100644
> --- a/xen/include/xen/domain.h
> +++ b/xen/include/xen/domain.h
> @@ -89,4 +89,13 @@ extern unsigned int xen_processor_pmbits;
>  
>  extern bool_t opt_dom0_vcpus_pin;
>  
> +struct vnuma_info {
> +    unsigned int nr_vnodes;
> +    unsigned int pad;
> +    unsigned int *vdistance;
> +    unsigned int *vcpu_to_vnode;
> +    unsigned int *vnode_to_pnode;
> +    struct vmemrange *vmemrange;
> +};
> +
>
And one last thing. Sorry if it's me not remembering, but what's 'pad'
above useful for?

Thanks and Regards,
Dario

-- 
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK)


[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

[-- Attachment #2: Type: text/plain, Size: 126 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel