From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/5] regulator: max14577: Add regulator driver for Maxim 14577
Date: Thu, 21 Nov 2013 15:27:13 +0100 [thread overview]
Message-ID: <1385044033.748.29.camel@AMDC1943> (raw)
In-Reply-To: <3987325.g4jkYp0g0H@amdc1032>
On Wed, 2013-11-20 at 18:58 +0100, Bartlomiej Zolnierkiewicz wrote:
> Err..
>
> > I'm missing something obvious "info" is redundant and can be removed
> > altogether.
> >
> > Best regards,
> > --
> > Bartlomiej Zolnierkiewicz
> > Samsung R&D Institute Poland
> > Samsung Electronics
> >
> > > + for (i = 0; i < pdata->num_regulators; i++) {
> > > + int id = pdata->regulators[i].id;
> > > +
> > > + config.init_data = pdata->regulators[i].initdata;
> > > + config.of_node = pdata->regulators[i].of_node;
> > > +
> > > + info->regulators[i] = devm_regulator_register(&pdev->dev,
> > > + &supported_regulators[id], &config);
> > > + if (IS_ERR(info->regulators[i])) {
>
> This code actually reads from "info" but it can be fixed trivially
> to not require "info".
You're right, it can be removed. The info was a left-over from 3.10
where there isn't devm_regulator_register(). Thanks for review.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: devicetree@vger.kernel.org,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Samuel Ortiz <sameo@linux.intel.com>,
Pawel Moll <pawel.moll@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Lee Jones <lee.jones@linaro.org>, Mark Brown <broonie@kernel.org>,
Anton Vorontsov <anton@enomsg.org>,
linux-doc@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <rob.herring@calxeda.com>,
linux-kernel@vger.kernel.org,
Chanwoo Choi <cw00.choi@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Rob Landley <rob@landley.net>,
Grant Likely <grant.likely@linaro.org>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v2 4/5] regulator: max14577: Add regulator driver for Maxim 14577
Date: Thu, 21 Nov 2013 15:27:13 +0100 [thread overview]
Message-ID: <1385044033.748.29.camel@AMDC1943> (raw)
In-Reply-To: <3987325.g4jkYp0g0H@amdc1032>
On Wed, 2013-11-20 at 18:58 +0100, Bartlomiej Zolnierkiewicz wrote:
> Err..
>
> > I'm missing something obvious "info" is redundant and can be removed
> > altogether.
> >
> > Best regards,
> > --
> > Bartlomiej Zolnierkiewicz
> > Samsung R&D Institute Poland
> > Samsung Electronics
> >
> > > + for (i = 0; i < pdata->num_regulators; i++) {
> > > + int id = pdata->regulators[i].id;
> > > +
> > > + config.init_data = pdata->regulators[i].initdata;
> > > + config.of_node = pdata->regulators[i].of_node;
> > > +
> > > + info->regulators[i] = devm_regulator_register(&pdev->dev,
> > > + &supported_regulators[id], &config);
> > > + if (IS_ERR(info->regulators[i])) {
>
> This code actually reads from "info" but it can be fixed trivially
> to not require "info".
You're right, it can be removed. The info was a left-over from 3.10
where there isn't devm_regulator_register(). Thanks for review.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Samuel Ortiz <sameo@linux.intel.com>,
Lee Jones <lee.jones@linaro.org>,
Anton Vorontsov <anton@enomsg.org>,
David Woodhouse <dwmw2@infradead.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Pawel Moll <pawel.moll@arm.com>,
Stephen Warren <swarren@wwwdotorg.org>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Landley <rob@landley.net>,
linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH v2 4/5] regulator: max14577: Add regulator driver for Maxim 14577
Date: Thu, 21 Nov 2013 15:27:13 +0100 [thread overview]
Message-ID: <1385044033.748.29.camel@AMDC1943> (raw)
In-Reply-To: <3987325.g4jkYp0g0H@amdc1032>
On Wed, 2013-11-20 at 18:58 +0100, Bartlomiej Zolnierkiewicz wrote:
> Err..
>
> > I'm missing something obvious "info" is redundant and can be removed
> > altogether.
> >
> > Best regards,
> > --
> > Bartlomiej Zolnierkiewicz
> > Samsung R&D Institute Poland
> > Samsung Electronics
> >
> > > + for (i = 0; i < pdata->num_regulators; i++) {
> > > + int id = pdata->regulators[i].id;
> > > +
> > > + config.init_data = pdata->regulators[i].initdata;
> > > + config.of_node = pdata->regulators[i].of_node;
> > > +
> > > + info->regulators[i] = devm_regulator_register(&pdev->dev,
> > > + &supported_regulators[id], &config);
> > > + if (IS_ERR(info->regulators[i])) {
>
> This code actually reads from "info" but it can be fixed trivially
> to not require "info".
You're right, it can be removed. The info was a left-over from 3.10
where there isn't devm_regulator_register(). Thanks for review.
Best regards,
Krzysztof
next prev parent reply other threads:[~2013-11-21 14:27 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-20 14:12 [PATCH v2 0/5] mfd: max14577: Add max14577 MFD drivers Krzysztof Kozlowski
2013-11-20 14:12 ` Krzysztof Kozlowski
2013-11-20 14:12 ` [PATCH v2 1/5] mfd: max14577: Add max14577 MFD driver core Krzysztof Kozlowski
2013-11-20 14:12 ` Krzysztof Kozlowski
2013-11-20 15:31 ` Mark Brown
2013-11-20 15:31 ` Mark Brown
2013-11-20 15:31 ` Mark Brown
2013-11-21 10:31 ` Krzysztof Kozlowski
2013-11-21 10:31 ` Krzysztof Kozlowski
2013-11-21 10:34 ` Lee Jones
2013-11-21 10:34 ` Lee Jones
2013-11-21 11:43 ` Krzysztof Kozlowski
2013-11-21 11:43 ` Krzysztof Kozlowski
2013-11-21 12:20 ` Lee Jones
2013-11-21 12:20 ` Lee Jones
2013-11-21 13:34 ` Krzysztof Kozlowski
2013-11-21 13:34 ` Krzysztof Kozlowski
2013-11-20 14:12 ` [PATCH v2 2/5] extcon: max14577: Add extcon-max14577 driver to support MUIC device Krzysztof Kozlowski
2013-11-20 14:12 ` Krzysztof Kozlowski
2013-11-20 14:12 ` [PATCH v2 3/5] charger: max14577: Add charger support for Maxim 14577 Krzysztof Kozlowski
2013-11-20 14:12 ` Krzysztof Kozlowski
2013-11-20 14:12 ` [PATCH v2 4/5] regulator: max14577: Add regulator driver " Krzysztof Kozlowski
2013-11-20 14:12 ` Krzysztof Kozlowski
2013-11-20 15:35 ` Mark Brown
2013-11-20 15:35 ` Mark Brown
2013-11-20 17:54 ` Bartlomiej Zolnierkiewicz
2013-11-20 17:54 ` Bartlomiej Zolnierkiewicz
2013-11-20 17:58 ` Bartlomiej Zolnierkiewicz
2013-11-20 17:58 ` Bartlomiej Zolnierkiewicz
2013-11-21 14:27 ` Krzysztof Kozlowski [this message]
2013-11-21 14:27 ` Krzysztof Kozlowski
2013-11-21 14:27 ` Krzysztof Kozlowski
2013-11-20 14:12 ` [PATCH v2 5/5] mfd: max14577: Add device tree bindings document Krzysztof Kozlowski
2013-11-20 14:12 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385044033.748.29.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.