From: Imre Deak <imre.deak@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: add intel_display_power_enabled_sw for use in atomic ctx
Date: Wed, 27 Nov 2013 20:42:36 +0200 [thread overview]
Message-ID: <1385577756.2839.9.camel@ideak-mobl> (raw)
In-Reply-To: <CAKMK7uEK=Vu03uKaxVVopbB=-ezrRZS+gY4RcnPAq6OthyLw3g@mail.gmail.com>
On Wed, 2013-11-27 at 19:38 +0100, Daniel Vetter wrote:
> On Wed, Nov 27, 2013 at 7:30 PM, Ville Syrjälä
> <ville.syrjala@linux.intel.com> wrote:
> > I'm not sure the barriers really provide extra value. Some other
> > thread could still come along just after this and disable the power
> > wells.
>
> Yeah, the barrriers don't really add anything - the access from the
> capture code is racy, but we don't really care about that. I'd still
> like to see us dump this information into the error state though since
> now the sw tracking could get out of sync with the hw and leave us
> puzzled when trying to analyze such a dump.
Right, so calling any form of intel_display_power_enabled() is
pointless. So that should be also removed and the value of
intel_display_power_enabled_sw() saved.
--Imre
> -Daniel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2013-11-27 18:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 18:09 [PATCH] drm/i915: add intel_display_power_enabled_sw for use in atomic ctx Imre Deak
2013-11-27 18:30 ` Ville Syrjälä
2013-11-27 18:38 ` Daniel Vetter
2013-11-27 18:42 ` Imre Deak [this message]
2013-11-27 20:02 ` [PATCH] drm/i915: add intel_display_power_enabled_sw() " Imre Deak
2013-11-28 13:50 ` Paulo Zanoni
2013-11-28 14:05 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385577756.2839.9.camel@ideak-mobl \
--to=imre.deak@intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.