All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: add intel_display_power_enabled_sw() for use in atomic ctx
Date: Thu, 28 Nov 2013 15:05:28 +0100	[thread overview]
Message-ID: <20131128140528.GL27344@phenom.ffwll.local> (raw)
In-Reply-To: <CA+gsUGSLjGR9OdsNG--TkRH2gAOk1gqbTGtiFBe8FZmtHH4tSA@mail.gmail.com>

On Thu, Nov 28, 2013 at 11:50:33AM -0200, Paulo Zanoni wrote:
> 2013/11/27 Imre Deak <imre.deak@intel.com>:
> > Atm we call intel_display_power_enabled() from
> > i915_capture_error_state() in IRQ context and then take a mutex. To fix
> > this add a new intel_display_power_enabled_sw() which returns the domain
> > state based on software tracking as opposed to reading the actual HW
> > state.
> >
> > Since we use domain_use_count for this without locking on the reader
> > side make sure we increase the counter only after enabling all required
> > power wells and decrease it before disabling any of these power wells.
> >
> > Regression introduced in
> > commit 1b02383464b4a915627ef3b8fd0ad7f07168c54c
> > Author: Imre Deak <imre.deak@intel.com>
> > Date:   Tue Sep 24 16:17:09 2013 +0300
> >
> >     drm/i915: support for multiple power wells
> >
> > Note that atm we depend on the value returned by
> > intel_display_power_enabled_sw() in i915_capture_error_state() to avoid
> > unclaimed register access reports. This was never guaranteed though,
> > since another thread can disable the power concurrently. If this is a
> > problem we need another explicit way to disable the reporting during
> > error captures.
> >
> > v2:
> > - remove barriers as the caller can't depend on the value
> >   returned from i915_capture_error_state_sw() anyway (Ville)
> > - dump the state of pipe/transcoder power domain state (Daniel)
> >
> > Reported-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
> 
> 
> Makes sense to me. Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch

      reply	other threads:[~2013-11-28 14:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-27 18:09 [PATCH] drm/i915: add intel_display_power_enabled_sw for use in atomic ctx Imre Deak
2013-11-27 18:30 ` Ville Syrjälä
2013-11-27 18:38   ` Daniel Vetter
2013-11-27 18:42     ` Imre Deak
2013-11-27 20:02 ` [PATCH] drm/i915: add intel_display_power_enabled_sw() " Imre Deak
2013-11-28 13:50   ` Paulo Zanoni
2013-11-28 14:05     ` Daniel Vetter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20131128140528.GL27344@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=przanoni@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.