From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [RFC] mac80211: fix rx_nss calculation for drivers with hw rc
Date: Mon, 02 Dec 2013 11:59:32 +0100 [thread overview]
Message-ID: <1385981972.4445.7.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1385981647-4147-1-git-send-email-michal.kazior@tieto.com> (sfid-20131202_115744_274098_9362F537)
On Mon, 2013-12-02 at 11:54 +0100, Michal Kazior wrote:
> Drivers with hardware rate control were given
> sta->rx_nss set to 0. This was because rx_nss
> calculation procedure was protected by hw/sw rate
> control check.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
> ---
> Hi Johannes,
>
> I've re-checked the issue I've mentioned with the patch 'ath10k: use nss
> provided by mac80211'.
>
> Apparently drivers with HW rate control are only affected by this bug
> and this patch is what I came up with as a quick fix. Any comments?
Yeah this looks reasonable. I guess I'll apply it despite the [RFC]
johannes
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [RFC] mac80211: fix rx_nss calculation for drivers with hw rc
Date: Mon, 02 Dec 2013 11:59:32 +0100 [thread overview]
Message-ID: <1385981972.4445.7.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1385981647-4147-1-git-send-email-michal.kazior@tieto.com> (sfid-20131202_115744_274098_9362F537)
On Mon, 2013-12-02 at 11:54 +0100, Michal Kazior wrote:
> Drivers with hardware rate control were given
> sta->rx_nss set to 0. This was because rx_nss
> calculation procedure was protected by hw/sw rate
> control check.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
> ---
> Hi Johannes,
>
> I've re-checked the issue I've mentioned with the patch 'ath10k: use nss
> provided by mac80211'.
>
> Apparently drivers with HW rate control are only affected by this bug
> and this patch is what I came up with as a quick fix. Any comments?
Yeah this looks reasonable. I guess I'll apply it despite the [RFC]
johannes
next prev parent reply other threads:[~2013-12-02 11:00 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-22 13:26 [PATCH 0/3] ath10k: fixes 2013-11-22 Michal Kazior
2013-11-22 13:26 ` Michal Kazior
2013-11-22 13:26 ` [PATCH 1/3] ath10k: use nss provided by mac80211 Michal Kazior
2013-11-22 13:26 ` Michal Kazior
2013-11-24 13:50 ` Kalle Valo
2013-11-24 13:50 ` Kalle Valo
2013-11-25 10:11 ` Michal Kazior
2013-11-25 10:11 ` Michal Kazior
2013-11-22 13:26 ` [PATCH 2/3] ath10k: implement sta_rc_update() Michal Kazior
2013-11-22 13:26 ` Michal Kazior
2013-11-22 13:26 ` [PATCH 3/3] ath10k: fix Tx status clearing Michal Kazior
2013-11-22 13:26 ` Michal Kazior
2013-11-24 13:51 ` Kalle Valo
2013-11-24 13:51 ` Kalle Valo
2013-11-26 13:57 ` [PATCH v2 0/3] ath10k: fixes 2013-11-22 Michal Kazior
2013-11-26 13:57 ` Michal Kazior
2013-11-26 13:57 ` [PATCH v2 1/3] ath10k: use nss provided by mac80211 Michal Kazior
2013-11-26 13:57 ` Michal Kazior
2013-11-27 10:25 ` Michal Kazior
2013-11-27 10:25 ` Michal Kazior
2013-11-27 14:55 ` Kalle Valo
2013-11-27 14:55 ` Kalle Valo
2013-11-29 15:37 ` Johannes Berg
2013-11-29 15:37 ` Johannes Berg
2013-12-02 10:54 ` [RFC] mac80211: fix rx_nss calculation for drivers with hw rc Michal Kazior
2013-12-02 10:54 ` Michal Kazior
2013-12-02 10:59 ` Johannes Berg [this message]
2013-12-02 10:59 ` Johannes Berg
2013-12-02 14:42 ` Johannes Berg
2013-12-02 14:42 ` Johannes Berg
2013-11-26 13:57 ` [PATCH v2 2/3] ath10k: implement sta_rc_update() Michal Kazior
2013-11-26 13:57 ` Michal Kazior
2013-11-27 15:03 ` Kalle Valo
2013-11-27 15:03 ` Kalle Valo
2013-12-18 10:11 ` [PATCH v2] " Michal Kazior
2013-12-18 10:11 ` Michal Kazior
2013-12-20 10:21 ` Kalle Valo
2013-12-20 10:21 ` Kalle Valo
2013-12-20 13:56 ` Ben Greear
2013-12-20 13:56 ` Ben Greear
2013-11-26 13:57 ` [PATCH v2 3/3] ath10k: fix Tx status clearing Michal Kazior
2013-11-26 13:57 ` Michal Kazior
2013-11-27 15:04 ` [PATCH v2 0/3] ath10k: fixes 2013-11-22 Kalle Valo
2013-11-27 15:04 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385981972.4445.7.camel@jlt4.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.