From: jonas.jensen@gmail.com (Jonas Jensen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dma: fix vchan_cookie_complete() debug print
Date: Fri, 6 Dec 2013 16:42:09 +0100 [thread overview]
Message-ID: <1386344529-25617-1-git-send-email-jonas.jensen@gmail.com> (raw)
vd->tx.cookie is set zero on dma_cookie_complete(),
save to local before printing it.
Signed-off-by: Jonas Jensen <jonas.jensen@gmail.com>
---
Notes:
dev_vdbg() could also be moved to happen earlier, what do you prefer?
Applies to next-20131206
drivers/dma/virt-dma.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/virt-dma.h b/drivers/dma/virt-dma.h
index 85c19d6..181b9526 100644
--- a/drivers/dma/virt-dma.h
+++ b/drivers/dma/virt-dma.h
@@ -84,10 +84,12 @@ static inline bool vchan_issue_pending(struct virt_dma_chan *vc)
static inline void vchan_cookie_complete(struct virt_dma_desc *vd)
{
struct virt_dma_chan *vc = to_virt_chan(vd->tx.chan);
+ dma_cookie_t cookie;
+ cookie = vd->tx.cookie;
dma_cookie_complete(&vd->tx);
dev_vdbg(vc->chan.device->dev, "txd %p[%x]: marked complete\n",
- vd, vd->tx.cookie);
+ vd, cookie);
list_add_tail(&vd->node, &vc->desc_completed);
tasklet_schedule(&vc->task);
--
1.8.2.1
WARNING: multiple messages have this Message-ID (diff)
From: Jonas Jensen <jonas.jensen@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, arm@kernel.org,
vinod.koul@intel.com, dan.j.williams@intel.com,
Jonas Jensen <jonas.jensen@gmail.com>
Subject: [PATCH] dma: fix vchan_cookie_complete() debug print
Date: Fri, 6 Dec 2013 16:42:09 +0100 [thread overview]
Message-ID: <1386344529-25617-1-git-send-email-jonas.jensen@gmail.com> (raw)
vd->tx.cookie is set zero on dma_cookie_complete(),
save to local before printing it.
Signed-off-by: Jonas Jensen <jonas.jensen@gmail.com>
---
Notes:
dev_vdbg() could also be moved to happen earlier, what do you prefer?
Applies to next-20131206
drivers/dma/virt-dma.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/virt-dma.h b/drivers/dma/virt-dma.h
index 85c19d6..181b9526 100644
--- a/drivers/dma/virt-dma.h
+++ b/drivers/dma/virt-dma.h
@@ -84,10 +84,12 @@ static inline bool vchan_issue_pending(struct virt_dma_chan *vc)
static inline void vchan_cookie_complete(struct virt_dma_desc *vd)
{
struct virt_dma_chan *vc = to_virt_chan(vd->tx.chan);
+ dma_cookie_t cookie;
+ cookie = vd->tx.cookie;
dma_cookie_complete(&vd->tx);
dev_vdbg(vc->chan.device->dev, "txd %p[%x]: marked complete\n",
- vd, vd->tx.cookie);
+ vd, cookie);
list_add_tail(&vd->node, &vc->desc_completed);
tasklet_schedule(&vc->task);
--
1.8.2.1
next reply other threads:[~2013-12-06 15:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-06 15:42 Jonas Jensen [this message]
2013-12-06 15:42 ` [PATCH] dma: fix vchan_cookie_complete() debug print Jonas Jensen
2013-12-06 17:20 ` Dan Williams
2013-12-06 17:20 ` Dan Williams
2013-12-09 9:25 ` [PATCH v2] " Jonas Jensen
2013-12-09 9:25 ` Jonas Jensen
2014-01-20 10:00 ` Vinod Koul
2014-01-20 10:00 ` Vinod Koul
2014-01-20 9:59 ` [PATCH] " Vinod Koul
2014-01-20 9:59 ` Vinod Koul
2014-01-20 11:28 ` Russell King - ARM Linux
2014-01-20 11:28 ` Russell King - ARM Linux
2014-01-20 12:03 ` Vinod Koul
2014-01-20 12:03 ` Vinod Koul
2014-01-20 13:28 ` Russell King - ARM Linux
2014-01-20 13:28 ` Russell King - ARM Linux
2014-01-26 11:23 ` Vinod Koul
2014-01-26 11:23 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1386344529-25617-1-git-send-email-jonas.jensen@gmail.com \
--to=jonas.jensen@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.