All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org
Cc: vdavydov-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org,
	cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCHSET REPOST cgroup/for-3.14] cgroup: factor out css creation into create_css()
Date: Fri,  6 Dec 2013 15:27:45 -0500	[thread overview]
Message-ID: <1386361672-27791-1-git-send-email-tj@kernel.org> (raw)

Hello,

This is repost of the following.

 http://thread.gmane.org/gmane.linux.kernel.cgroups/8981

It got reviewed and acked then but I somehow forgot apply and Vladimir
reporting the same bug that the first patch in the original patch
fixed reminded me.  The first patch is already applied to
cgroup/for-3.13-fixes which is pulled into for-3.14 for this series.

While the patches are not completely identical, the adjustments are
trivial.  css_id got ripped out in the meantime, so "[PATCH 4/9]
cgroup: move css_id commit from cgroup_populate_dir() to online_css()"
is dropped and the patches are refreshed to reflect the dropping of
css_id handling in cgroup_create().  I'm applying the series to
cgroup/for-3.14.

The original patchset description follows.  Thanks and sorry about the
messup.

For unified hierarchy, a css's (cgroup_subsys_state) lifetime will be
different from that of the associated cgroup.  css's may be created
and destroyed dynamically over the lifetime of a single cgroup.  The
previous changes decoupled css destruction from cgroup's.  This
patchset decouples css creation from cgroup's.

This patchset contains the following seven patches.

 0001-cgroup-css-iterations-and-css_from_dir-are-safe-unde.patch
 0002-cgroup-make-for_each_subsys-useable-under-cgroup_roo.patch
 0003-cgroup-reorder-operations-in-cgroup_create.patch
 0004-cgroup-combine-css-handling-loops-in-cgroup_create.patch
 0005-cgroup-factor-out-cgroup_subsys_state-creation-into-.patch
 0006-cgroup-implement-for_each_css.patch
 0007-cgroup-remove-for_each_root_subsys.patch

0001-0002 are prep patches.

0003-0005 collect css creation operations into single loop and factor
it out into create_css().

0006-0007 are somewhat tangential.  As everything is css based now and
the enabled set of css's might be differ depending on the specific
cgroup in the future, they introduce for_each_css() and replace most
uses of for_each_root_subsys() with it.  The two left overs are
opencoded and for_each_root_subsys() and the related logic are
removed.

This patchset shouldn't bring any userland noticeable behavior
changes.  It's on top of cgroup/for-3.12 d1625964da ("cgroup: fix
cgroup_css() invocation in css_from_id()") and available in the
following git branch.

 include/linux/cgroup.h |    9 -
 kernel/cgroup.c        |  300 ++++++++++++++++++++++++++-----------------------
 2 files changed, 161 insertions(+), 148 deletions(-)

--
tejun

WARNING: multiple messages have this Message-ID (diff)
From: Tejun Heo <tj@kernel.org>
To: lizefan@huawei.com
Cc: containers@lists.linux-foundation.org, cgroups@vger.kernel.org,
	linux-kernel@vger.kernel.org, vdavydov@parallels.com
Subject: [PATCHSET REPOST cgroup/for-3.14] cgroup: factor out css creation into create_css()
Date: Fri,  6 Dec 2013 15:27:45 -0500	[thread overview]
Message-ID: <1386361672-27791-1-git-send-email-tj@kernel.org> (raw)

Hello,

This is repost of the following.

 http://thread.gmane.org/gmane.linux.kernel.cgroups/8981

It got reviewed and acked then but I somehow forgot apply and Vladimir
reporting the same bug that the first patch in the original patch
fixed reminded me.  The first patch is already applied to
cgroup/for-3.13-fixes which is pulled into for-3.14 for this series.

While the patches are not completely identical, the adjustments are
trivial.  css_id got ripped out in the meantime, so "[PATCH 4/9]
cgroup: move css_id commit from cgroup_populate_dir() to online_css()"
is dropped and the patches are refreshed to reflect the dropping of
css_id handling in cgroup_create().  I'm applying the series to
cgroup/for-3.14.

The original patchset description follows.  Thanks and sorry about the
messup.

For unified hierarchy, a css's (cgroup_subsys_state) lifetime will be
different from that of the associated cgroup.  css's may be created
and destroyed dynamically over the lifetime of a single cgroup.  The
previous changes decoupled css destruction from cgroup's.  This
patchset decouples css creation from cgroup's.

This patchset contains the following seven patches.

 0001-cgroup-css-iterations-and-css_from_dir-are-safe-unde.patch
 0002-cgroup-make-for_each_subsys-useable-under-cgroup_roo.patch
 0003-cgroup-reorder-operations-in-cgroup_create.patch
 0004-cgroup-combine-css-handling-loops-in-cgroup_create.patch
 0005-cgroup-factor-out-cgroup_subsys_state-creation-into-.patch
 0006-cgroup-implement-for_each_css.patch
 0007-cgroup-remove-for_each_root_subsys.patch

0001-0002 are prep patches.

0003-0005 collect css creation operations into single loop and factor
it out into create_css().

0006-0007 are somewhat tangential.  As everything is css based now and
the enabled set of css's might be differ depending on the specific
cgroup in the future, they introduce for_each_css() and replace most
uses of for_each_root_subsys() with it.  The two left overs are
opencoded and for_each_root_subsys() and the related logic are
removed.

This patchset shouldn't bring any userland noticeable behavior
changes.  It's on top of cgroup/for-3.12 d1625964da ("cgroup: fix
cgroup_css() invocation in css_from_id()") and available in the
following git branch.

 include/linux/cgroup.h |    9 -
 kernel/cgroup.c        |  300 ++++++++++++++++++++++++++-----------------------
 2 files changed, 161 insertions(+), 148 deletions(-)

--
tejun

             reply	other threads:[~2013-12-06 20:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-06 20:27 Tejun Heo [this message]
2013-12-06 20:27 ` [PATCHSET REPOST cgroup/for-3.14] cgroup: factor out css creation into create_css() Tejun Heo
     [not found] ` <1386361672-27791-1-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-12-06 20:27   ` [PATCH 1/7] cgroup: css iterations and css_from_dir() are safe under cgroup_mutex Tejun Heo
2013-12-06 20:27     ` Tejun Heo
2013-12-06 20:27   ` [PATCH 2/7] cgroup: make for_each_subsys() useable under cgroup_root_mutex Tejun Heo
2013-12-06 20:27     ` Tejun Heo
2013-12-06 20:27   ` Tejun Heo
2013-12-06 20:27   ` [PATCH 3/7] cgroup: reorder operations in cgroup_create() Tejun Heo
2013-12-06 20:27     ` Tejun Heo
2013-12-06 20:27   ` [PATCH 4/7] cgroup: combine css handling loops " Tejun Heo
2013-12-06 20:27     ` Tejun Heo
2013-12-06 20:27   ` [PATCH 5/7] cgroup: factor out cgroup_subsys_state creation into create_css() Tejun Heo
2013-12-06 20:27     ` Tejun Heo
2013-12-06 20:27   ` [PATCH 6/7] cgroup: implement for_each_css() Tejun Heo
2013-12-06 20:27   ` [PATCH 7/7] cgroup: remove for_each_root_subsys() Tejun Heo
2013-12-06 20:27     ` Tejun Heo
2013-12-09  9:15   ` [PATCHSET REPOST cgroup/for-3.14] cgroup: factor out css creation into create_css() Li Zefan
2013-12-09  9:15     ` Li Zefan
2013-12-06 20:27 ` [PATCH 6/7] cgroup: implement for_each_css() Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1386361672-27791-1-git-send-email-tj@kernel.org \
    --to=tj-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
    --cc=vdavydov-bzQdu9zFT3WakBO8gow8eQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.