From: Jiang Liu <liuj97@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Shaohua Li <shli@kernel.org>, Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jiang Liu <liuj97@gmail.com>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Steven Rostedt <rostedt@goodmis.org>,
Jiri Kosina <trivial@kernel.org>,
Wang YanQing <udknight@gmail.com>,
linux-arch@vger.kernel.org
Subject: [PATCH v3 [resend] 07/18] smp, IA64: kill SMP single function call interrupt
Date: Mon, 16 Dec 2013 00:36:29 +0800 [thread overview]
Message-ID: <1387125400-28849-8-git-send-email-liuj97@gmail.com> (raw)
In-Reply-To: <1387125400-28849-1-git-send-email-liuj97@gmail.com>
Commit 9a46ad6d6df3b54 "smp: make smp_call_function_many() use logic
similar to smp_call_function_single()" has unified the way to handle
single and multiple cross-CPU function calls. Now only one interrupt
is needed for architecture specific code to support generic SMP function
call interfaces, so kill the redundant single function call interrupt.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Shaohua Li <shli@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Jiri Kosina <trivial@kernel.org>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: linux-ia64@vger.kernel.org
Signed-off-by: Jiang Liu <liuj97@gmail.com>
---
arch/ia64/kernel/smp.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/ia64/kernel/smp.c b/arch/ia64/kernel/smp.c
index 9fcd4e6..0532909 100644
--- a/arch/ia64/kernel/smp.c
+++ b/arch/ia64/kernel/smp.c
@@ -62,8 +62,7 @@ static DEFINE_PER_CPU_SHARED_ALIGNED(unsigned short [NR_CPUS],
#define IPI_CALL_FUNC 0
#define IPI_CPU_STOP 1
-#define IPI_CALL_FUNC_SINGLE 2
-#define IPI_KDUMP_CPU_STOP 3
+#define IPI_KDUMP_CPU_STOP 2
/* This needs to be cacheline aligned because it is written to by *other* CPUs. */
static DEFINE_PER_CPU_SHARED_ALIGNED(unsigned long, ipi_operation);
@@ -116,9 +115,6 @@ handle_IPI (int irq, void *dev_id)
case IPI_CALL_FUNC:
generic_smp_call_function_interrupt();
break;
- case IPI_CALL_FUNC_SINGLE:
- generic_smp_call_function_single_interrupt();
- break;
#ifdef CONFIG_KEXEC
case IPI_KDUMP_CPU_STOP:
unw_init_running(kdump_cpu_freeze, NULL);
@@ -318,7 +314,7 @@ smp_flush_tlb_mm (struct mm_struct *mm)
void arch_send_call_function_single_ipi(int cpu)
{
- send_IPI_single(cpu, IPI_CALL_FUNC_SINGLE);
+ send_IPI_single(cpu, IPI_CALL_FUNC);
}
void arch_send_call_function_ipi_mask(const struct cpumask *mask)
--
1.8.1.2
WARNING: multiple messages have this Message-ID (diff)
From: Jiang Liu <liuj97@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Shaohua Li <shli@kernel.org>, Tony Luck <tony.luck@intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Jiang Liu <liuj97@gmail.com>, Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Steven Rostedt <rostedt@goodmis.org>,
Jiri Kosina <trivial@kernel.org>,
Wang YanQing <udknight@gmail.com>,
linux-arch@vger.kernel.org
Subject: [PATCH v3 [resend] 07/18] smp, IA64: kill SMP single function call interrupt
Date: Sun, 15 Dec 2013 16:36:29 +0000 [thread overview]
Message-ID: <1387125400-28849-8-git-send-email-liuj97@gmail.com> (raw)
In-Reply-To: <1387125400-28849-1-git-send-email-liuj97@gmail.com>
Commit 9a46ad6d6df3b54 "smp: make smp_call_function_many() use logic
similar to smp_call_function_single()" has unified the way to handle
single and multiple cross-CPU function calls. Now only one interrupt
is needed for architecture specific code to support generic SMP function
call interfaces, so kill the redundant single function call interrupt.
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Shaohua Li <shli@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Jiri Kosina <trivial@kernel.org>
Cc: Tony Luck <tony.luck@intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: linux-ia64@vger.kernel.org
Signed-off-by: Jiang Liu <liuj97@gmail.com>
---
arch/ia64/kernel/smp.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/ia64/kernel/smp.c b/arch/ia64/kernel/smp.c
index 9fcd4e6..0532909 100644
--- a/arch/ia64/kernel/smp.c
+++ b/arch/ia64/kernel/smp.c
@@ -62,8 +62,7 @@ static DEFINE_PER_CPU_SHARED_ALIGNED(unsigned short [NR_CPUS],
#define IPI_CALL_FUNC 0
#define IPI_CPU_STOP 1
-#define IPI_CALL_FUNC_SINGLE 2
-#define IPI_KDUMP_CPU_STOP 3
+#define IPI_KDUMP_CPU_STOP 2
/* This needs to be cacheline aligned because it is written to by *other* CPUs. */
static DEFINE_PER_CPU_SHARED_ALIGNED(unsigned long, ipi_operation);
@@ -116,9 +115,6 @@ handle_IPI (int irq, void *dev_id)
case IPI_CALL_FUNC:
generic_smp_call_function_interrupt();
break;
- case IPI_CALL_FUNC_SINGLE:
- generic_smp_call_function_single_interrupt();
- break;
#ifdef CONFIG_KEXEC
case IPI_KDUMP_CPU_STOP:
unw_init_running(kdump_cpu_freeze, NULL);
@@ -318,7 +314,7 @@ smp_flush_tlb_mm (struct mm_struct *mm)
void arch_send_call_function_single_ipi(int cpu)
{
- send_IPI_single(cpu, IPI_CALL_FUNC_SINGLE);
+ send_IPI_single(cpu, IPI_CALL_FUNC);
}
void arch_send_call_function_ipi_mask(const struct cpumask *mask)
--
1.8.1.2
next prev parent reply other threads:[~2013-12-15 16:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-15 16:36 [PATCH v3 [resend] 00/18] simplify generic cross CPU function call implementation Jiang Liu
2013-12-15 16:36 ` [PATCH v3 [resend] 01/18] Revert "kernel/smp.c: free related resources when failure occurs in hotplug_cfd()" Jiang Liu
2013-12-15 16:36 ` [PATCH v3 [resend] 02/18] Revert "smp: Fix SMP function call empty cpu mask race" Jiang Liu
2013-12-15 16:36 ` [PATCH v3 [resend] 03/18] smp, alpha: kill SMP single function call interrupt Jiang Liu
2013-12-15 16:36 ` [PATCH v3 [resend] 04/18] smp, ARM: " Jiang Liu
2013-12-15 16:36 ` Jiang Liu
2013-12-15 16:36 ` [PATCH v3 [resend] 05/18] smp, ARM64: " Jiang Liu
2013-12-15 16:36 ` Jiang Liu
2013-12-17 17:16 ` Will Deacon
2013-12-17 17:16 ` Will Deacon
2013-12-15 16:36 ` [PATCH v3 [resend] 06/18] smp, blackfin: " Jiang Liu
2013-12-15 16:36 ` Jiang Liu [this message]
2013-12-15 16:36 ` [PATCH v3 [resend] 07/18] smp, IA64: " Jiang Liu
2013-12-15 16:36 ` [PATCH v3 [resend] 08/18] smp, m32r: " Jiang Liu
2013-12-15 16:36 ` [PATCH v3 [resend] 09/18] smp, mn10300: " Jiang Liu
2013-12-15 16:36 ` [PATCH v3 [resend] 10/18] smp, mn10300: enable arch_send_call_function_ipi_mask() Jiang Liu
2013-12-15 16:36 ` [PATCH v3 [resend] 11/18] smp, sh: kill SMP single function call interrupt Jiang Liu
2013-12-15 16:36 ` Jiang Liu
2013-12-15 16:36 ` [PATCH v3 [resend] 12/18] smp, sparc64: " Jiang Liu
2013-12-15 16:36 ` Jiang Liu
2013-12-15 16:36 ` [PATCH v3 [resend] 13/18] smp, sparc: " Jiang Liu
2013-12-15 16:36 ` Jiang Liu
2013-12-15 16:36 ` [PATCH v3 [resend] 14/18] smp, x86, xen: " Jiang Liu
2013-12-15 16:36 ` Jiang Liu
2013-12-16 3:00 ` Konrad Rzeszutek Wilk
2013-12-16 3:00 ` Konrad Rzeszutek Wilk
2013-12-16 4:24 ` Liu, Jinsong
2013-12-16 4:24 ` Liu, Jinsong
2013-12-16 16:33 ` Konrad Rzeszutek Wilk
2013-12-16 16:33 ` Konrad Rzeszutek Wilk
2013-12-16 4:24 ` Liu, Jinsong
2013-12-15 16:36 ` [PATCH v3 [resend] 15/18] smp, x86: " Jiang Liu
2013-12-15 16:36 ` Jiang Liu
2013-12-15 16:36 ` [PATCH v3 [resend] 16/18] smp: cleanup unsued generic_smp_call_function_single_interrupt() Jiang Liu
2013-12-15 16:36 ` [PATCH v3 [resend] 17/18] smp: rename call_single_queue as call_function_queue Jiang Liu
2013-12-15 16:36 ` [PATCH v3 [resend] 18/18] SMP, trivial: remove unused code from smp_boot.h Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387125400-28849-8-git-send-email-liuj97@gmail.com \
--to=liuj97@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=fenghua.yu@intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=shli@kernel.org \
--cc=tony.luck@intel.com \
--cc=trivial@kernel.org \
--cc=udknight@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.