* [U-Boot] [PATCH] spi: sh_spi: Use sh_spi_clear_bit() instead of open-coded
@ 2013-12-27 5:51 Axel Lin
2013-12-27 6:17 ` Nobuhiro Iwamatsu
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2013-12-27 5:51 UTC (permalink / raw)
To: u-boot
We have a sh_spi_clear_bit() function, there's no reason not to use it.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/spi/sh_spi.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/spi/sh_spi.c b/drivers/spi/sh_spi.c
index 744afe3..7ca5e36 100644
--- a/drivers/spi/sh_spi.c
+++ b/drivers/spi/sh_spi.c
@@ -151,7 +151,6 @@ static int sh_spi_send(struct sh_spi *ss, const unsigned char *tx_data,
{
int i, cur_len, ret = 0;
int remain = (int)len;
- unsigned long tmp;
if (len >= SH_SPI_FIFO_SIZE)
sh_spi_set_bit(SH_SPI_SSA, &ss->regs->cr1);
@@ -183,9 +182,7 @@ static int sh_spi_send(struct sh_spi *ss, const unsigned char *tx_data,
}
if (flags & SPI_XFER_END) {
- tmp = sh_spi_read(&ss->regs->cr1);
- tmp = tmp & ~(SH_SPI_SSD | SH_SPI_SSDB);
- sh_spi_write(tmp, &ss->regs->cr1);
+ sh_spi_clear_bit(SH_SPI_SSD | SH_SPI_SSDB, &ss->regs->cr1);
sh_spi_set_bit(SH_SPI_SSA, &ss->regs->cr1);
udelay(100);
write_fifo_empty_wait(ss);
@@ -198,16 +195,13 @@ static int sh_spi_receive(struct sh_spi *ss, unsigned char *rx_data,
unsigned int len, unsigned long flags)
{
int i;
- unsigned long tmp;
if (len > SH_SPI_MAX_BYTE)
sh_spi_write(SH_SPI_MAX_BYTE, &ss->regs->cr3);
else
sh_spi_write(len, &ss->regs->cr3);
- tmp = sh_spi_read(&ss->regs->cr1);
- tmp = tmp & ~(SH_SPI_SSD | SH_SPI_SSDB);
- sh_spi_write(tmp, &ss->regs->cr1);
+ sh_spi_clear_bit(SH_SPI_SSD | SH_SPI_SSDB, &ss->regs->cr1);
sh_spi_set_bit(SH_SPI_SSA, &ss->regs->cr1);
for (i = 0; i < len; i++) {
--
1.8.1.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] spi: sh_spi: Use sh_spi_clear_bit() instead of open-coded
2013-12-27 5:51 [U-Boot] [PATCH] spi: sh_spi: Use sh_spi_clear_bit() instead of open-coded Axel Lin
@ 2013-12-27 6:17 ` Nobuhiro Iwamatsu
2014-01-06 19:38 ` Jagan Teki
0 siblings, 1 reply; 3+ messages in thread
From: Nobuhiro Iwamatsu @ 2013-12-27 6:17 UTC (permalink / raw)
To: u-boot
Hi,
Thanks for your patch.
2013/12/27 Axel Lin <axel.lin@ingics.com>:
> We have a sh_spi_clear_bit() function, there's no reason not to use it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Best regards,
Nobuhiro
--
Nobuhiro Iwamatsu
iwamatsu at {nigauri.org / debian.org}
GPG ID: 40AD1FA6
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] spi: sh_spi: Use sh_spi_clear_bit() instead of open-coded
2013-12-27 6:17 ` Nobuhiro Iwamatsu
@ 2014-01-06 19:38 ` Jagan Teki
0 siblings, 0 replies; 3+ messages in thread
From: Jagan Teki @ 2014-01-06 19:38 UTC (permalink / raw)
To: u-boot
On Fri, Dec 27, 2013 at 11:47 AM, Nobuhiro Iwamatsu
<iwamatsu@nigauri.org> wrote:
> Hi,
>
> Thanks for your patch.
>
> 2013/12/27 Axel Lin <axel.lin@ingics.com>:
>> We have a sh_spi_clear_bit() function, there's no reason not to use it.
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>
> Acked-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
>
> Best regards,
> Nobuhiro
>
> --
> Nobuhiro Iwamatsu
> iwamatsu at {nigauri.org / debian.org}
> GPG ID: 40AD1FA6
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
Applied to u-boot-spi/master
--
Thanks,
Jagan.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-01-06 19:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-27 5:51 [U-Boot] [PATCH] spi: sh_spi: Use sh_spi_clear_bit() instead of open-coded Axel Lin
2013-12-27 6:17 ` Nobuhiro Iwamatsu
2014-01-06 19:38 ` Jagan Teki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.