From: Laura Abbott <lauraa@codeaurora.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Kyungmin Park <kmpark@infradead.org>, Dave Hansen <dave@sr71.net>,
linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, Laura Abbott <lauraa@codeaurora.org>
Subject: [RFC PATCHv3 11/11] fs/proc/kcore.c: Use for_each_potential_vmalloc_area
Date: Thu, 2 Jan 2014 13:53:29 -0800 [thread overview]
Message-ID: <1388699609-18214-12-git-send-email-lauraa@codeaurora.org> (raw)
In-Reply-To: <1388699609-18214-1-git-send-email-lauraa@codeaurora.org>
With CONFIG_INTERMIX_VMALLOC, we can no longer assume all vmalloc
is contained between VMALLOC_START and VMALLOC_END. For code that
relies on operating on the vmalloc space, use
for_each_potential_vmalloc_area to track each area separately.
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>
---
fs/proc/kcore.c | 20 +++++++++++++++-----
1 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c
index 5ed0e52..9be81a8 100644
--- a/fs/proc/kcore.c
+++ b/fs/proc/kcore.c
@@ -585,8 +585,6 @@ static struct notifier_block kcore_callback_nb __meminitdata = {
.priority = 0,
};
-static struct kcore_list kcore_vmalloc;
-
#ifdef CONFIG_ARCH_PROC_KCORE_TEXT
static struct kcore_list kcore_text;
/*
@@ -621,6 +619,11 @@ static void __init add_modules_range(void)
static int __init proc_kcore_init(void)
{
+ struct kcore_list *kcore_vmalloc;
+ unsigned long vstart;
+ unsigned long vend;
+ int i;
+
proc_root_kcore = proc_create("kcore", S_IRUSR, NULL,
&proc_kcore_operations);
if (!proc_root_kcore) {
@@ -629,9 +632,16 @@ static int __init proc_kcore_init(void)
}
/* Store text area if it's special */
proc_kcore_text_init();
- /* Store vmalloc area */
- kclist_add(&kcore_vmalloc, (void *)VMALLOC_START,
- VMALLOC_END - VMALLOC_START, KCORE_VMALLOC);
+ for_each_potential_vmalloc_area(&vstart, &vend, &i) {
+ kcore_vmalloc = kzalloc(sizeof(*kcore_vmalloc), GFP_KERNEL);
+ if (!kcore_vmalloc)
+ return 0;
+
+ /* Store vmalloc area */
+ kclist_add(kcore_vmalloc, (void *)vstart,
+ vend - vstart, KCORE_VMALLOC);
+ }
+
add_modules_range();
/* Store direct-map area from physical memory map */
kcore_update_ram();
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Laura Abbott <lauraa@codeaurora.org>
To: Andrew Morton <akpm@linux-foundation.org>,
Kyungmin Park <kmpark@infradead.org>, Dave Hansen <dave@sr71.net>,
linux-mm@kvack.org
Cc: linux-kernel@vger.kernel.org, Laura Abbott <lauraa@codeaurora.org>
Subject: [RFC PATCHv3 11/11] fs/proc/kcore.c: Use for_each_potential_vmalloc_area
Date: Thu, 2 Jan 2014 13:53:29 -0800 [thread overview]
Message-ID: <1388699609-18214-12-git-send-email-lauraa@codeaurora.org> (raw)
In-Reply-To: <1388699609-18214-1-git-send-email-lauraa@codeaurora.org>
With CONFIG_INTERMIX_VMALLOC, we can no longer assume all vmalloc
is contained between VMALLOC_START and VMALLOC_END. For code that
relies on operating on the vmalloc space, use
for_each_potential_vmalloc_area to track each area separately.
Signed-off-by: Laura Abbott <lauraa@codeaurora.org>
---
fs/proc/kcore.c | 20 +++++++++++++++-----
1 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/fs/proc/kcore.c b/fs/proc/kcore.c
index 5ed0e52..9be81a8 100644
--- a/fs/proc/kcore.c
+++ b/fs/proc/kcore.c
@@ -585,8 +585,6 @@ static struct notifier_block kcore_callback_nb __meminitdata = {
.priority = 0,
};
-static struct kcore_list kcore_vmalloc;
-
#ifdef CONFIG_ARCH_PROC_KCORE_TEXT
static struct kcore_list kcore_text;
/*
@@ -621,6 +619,11 @@ static void __init add_modules_range(void)
static int __init proc_kcore_init(void)
{
+ struct kcore_list *kcore_vmalloc;
+ unsigned long vstart;
+ unsigned long vend;
+ int i;
+
proc_root_kcore = proc_create("kcore", S_IRUSR, NULL,
&proc_kcore_operations);
if (!proc_root_kcore) {
@@ -629,9 +632,16 @@ static int __init proc_kcore_init(void)
}
/* Store text area if it's special */
proc_kcore_text_init();
- /* Store vmalloc area */
- kclist_add(&kcore_vmalloc, (void *)VMALLOC_START,
- VMALLOC_END - VMALLOC_START, KCORE_VMALLOC);
+ for_each_potential_vmalloc_area(&vstart, &vend, &i) {
+ kcore_vmalloc = kzalloc(sizeof(*kcore_vmalloc), GFP_KERNEL);
+ if (!kcore_vmalloc)
+ return 0;
+
+ /* Store vmalloc area */
+ kclist_add(kcore_vmalloc, (void *)vstart,
+ vend - vstart, KCORE_VMALLOC);
+ }
+
add_modules_range();
/* Store direct-map area from physical memory map */
kcore_update_ram();
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-01-02 21:53 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-02 21:53 [RFC PATCHv3 00/11] Intermix Lowmem and vmalloc Laura Abbott
2014-01-02 21:53 ` Laura Abbott
2014-01-02 21:53 ` [RFC PATCHv3 01/11] mce: acpi/apei: Use get_vm_area directly Laura Abbott
2014-01-02 21:53 ` Laura Abbott
2014-01-03 2:33 ` Chen, Gong
2014-01-02 21:53 ` [RFC PATCHv3 02/11] iommu/omap: " Laura Abbott
2014-01-02 21:53 ` Laura Abbott
2014-01-03 2:40 ` Chen, Gong
2014-01-02 21:53 ` [RFC PATCHv3 03/11] percpu: use VMALLOC_TOTAL instead of VMALLOC_END - VMALLOC_START Laura Abbott
2014-01-02 21:53 ` Laura Abbott
2014-01-12 3:39 ` Tejun Heo
2014-01-12 3:39 ` Tejun Heo
2014-01-02 21:53 ` [RFC PATCHv3 04/11] dm: Use VMALLOC_TOTAL instead of VMALLCO_END " Laura Abbott
2014-01-02 21:53 ` Laura Abbott
2014-01-02 21:53 ` [RFC PATCHv3 05/11] staging: lustre: Use is_vmalloc_addr Laura Abbott
2014-01-02 21:53 ` Laura Abbott
2014-01-02 21:53 ` [RFC PATCHv3 06/11] arm: use is_vmalloc_addr Laura Abbott
2014-01-02 21:53 ` Laura Abbott
2014-01-02 21:53 ` Laura Abbott
2014-01-02 22:13 ` Dave Hansen
2014-01-02 22:13 ` Dave Hansen
2014-01-02 22:13 ` Dave Hansen
2014-01-02 21:53 ` [RFC PATCHv3 07/11] arm: mm: Add iotable_init_novmreserve Laura Abbott
2014-01-02 21:53 ` Laura Abbott
2014-01-02 21:53 ` Laura Abbott
2014-01-02 21:53 ` [RFC PATCHv3 08/11] mm/vmalloc.c: Allow lowmem to be tracked in vmalloc Laura Abbott
2014-01-02 21:53 ` Laura Abbott
2014-01-02 21:53 ` [RFC PATCHv3 09/11] arm: mm: Track lowmem " Laura Abbott
2014-01-02 21:53 ` Laura Abbott
2014-01-02 21:53 ` Laura Abbott
2014-01-02 21:53 ` [RFC PATCHv3 10/11] arm: Use for_each_potential_vmalloc_area Laura Abbott
2014-01-02 21:53 ` Laura Abbott
2014-01-02 21:53 ` Laura Abbott
2014-01-02 21:53 ` Laura Abbott [this message]
2014-01-02 21:53 ` [RFC PATCHv3 11/11] fs/proc/kcore.c: " Laura Abbott
2014-01-03 18:23 ` [RFC PATCHv3 00/11] Intermix Lowmem and vmalloc Dave Hansen
2014-01-03 22:08 ` Laura Abbott
2014-01-03 22:08 ` Laura Abbott
2014-01-04 7:31 ` Minchan Kim
2014-01-04 7:31 ` Minchan Kim
2014-01-06 19:08 ` Laura Abbott
2014-01-06 19:08 ` Laura Abbott
2014-01-08 2:52 ` Minchan Kim
2014-01-08 2:52 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1388699609-18214-12-git-send-email-lauraa@codeaurora.org \
--to=lauraa@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=dave@sr71.net \
--cc=kmpark@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.