From: msalter@redhat.com (Mark Salter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/6] arm: add early_ioremap support
Date: Fri, 10 Jan 2014 15:52:02 -0500 [thread overview]
Message-ID: <1389387122.2591.96.camel@deneb.redhat.com> (raw)
In-Reply-To: <52D05ABD.30904@codeaurora.org>
On Fri, 2014-01-10 at 12:40 -0800, Stephen Boyd wrote:
> Just some minor nitpicks
>
> On 01/09/14 19:50, Mark Salter wrote:
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index c1f1a7e..78a79a6a 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -1842,6 +1842,17 @@ config UACCESS_WITH_MEMCPY
> > However, if the CPU data cache is using a write-allocate mode,
> > this option is unlikely to provide any performance gain.
> >
> > +config EARLY_IOREMAP
> > + depends on MMU
> > + bool "Provide early_ioremap() support for kernel initialization."
>
> Please drop the full stop.
>
> > + select GENERIC_EARLY_IOREMAP
> > + help
> > + Provide a mechanism for kernel initialisation code to temporarily
> > + map, in a highmem-agnostic way, memory pages in before ioremap()
> > + and friends are available (before paging_init() has run). It uses
> > + the same virtual memory range as kmap so all early mappings must
> > + be unapped before paging_init() is called.
>
> s/unapped/unmapped/
>
Will do. Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Mark Salter <msalter@redhat.com>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: linux-kernel@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/6] arm: add early_ioremap support
Date: Fri, 10 Jan 2014 15:52:02 -0500 [thread overview]
Message-ID: <1389387122.2591.96.camel@deneb.redhat.com> (raw)
In-Reply-To: <52D05ABD.30904@codeaurora.org>
On Fri, 2014-01-10 at 12:40 -0800, Stephen Boyd wrote:
> Just some minor nitpicks
>
> On 01/09/14 19:50, Mark Salter wrote:
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index c1f1a7e..78a79a6a 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -1842,6 +1842,17 @@ config UACCESS_WITH_MEMCPY
> > However, if the CPU data cache is using a write-allocate mode,
> > this option is unlikely to provide any performance gain.
> >
> > +config EARLY_IOREMAP
> > + depends on MMU
> > + bool "Provide early_ioremap() support for kernel initialization."
>
> Please drop the full stop.
>
> > + select GENERIC_EARLY_IOREMAP
> > + help
> > + Provide a mechanism for kernel initialisation code to temporarily
> > + map, in a highmem-agnostic way, memory pages in before ioremap()
> > + and friends are available (before paging_init() has run). It uses
> > + the same virtual memory range as kmap so all early mappings must
> > + be unapped before paging_init() is called.
>
> s/unapped/unmapped/
>
Will do. Thanks!
next prev parent reply other threads:[~2014-01-10 20:52 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 3:50 [PATCH v3 0/6] generic early_ioremap support Mark Salter
2014-01-10 3:50 ` Mark Salter
2014-01-10 3:50 ` [PATCH v3 1/6] x86/mm: sparse warning fix for early_memremap Mark Salter
2014-01-10 3:50 ` [PATCH v3 2/6] mm: create generic early_ioremap() support Mark Salter
2014-01-10 3:50 ` Mark Salter
2014-01-10 3:50 ` [PATCH v3 3/6] x86: use generic early_ioremap Mark Salter
2014-01-10 3:50 ` [PATCH v3 4/6] arm: add early_ioremap support Mark Salter
2014-01-10 3:50 ` Mark Salter
2014-01-10 11:34 ` Russell King - ARM Linux
2014-01-10 11:34 ` Russell King - ARM Linux
2014-01-10 13:50 ` Mark Salter
2014-01-10 16:11 ` Rob Herring
2014-01-10 16:11 ` Rob Herring
2014-01-10 16:58 ` Catalin Marinas
2014-01-10 16:58 ` Catalin Marinas
2014-01-10 20:04 ` Rob Herring
2014-01-10 20:04 ` Rob Herring
2014-01-10 20:09 ` Rob Herring
2014-01-10 20:09 ` Rob Herring
2014-01-10 20:51 ` Mark Salter
2014-01-10 20:51 ` Mark Salter
2014-01-10 20:40 ` Stephen Boyd
2014-01-10 20:40 ` Stephen Boyd
2014-01-10 20:52 ` Mark Salter [this message]
2014-01-10 20:52 ` Mark Salter
2014-01-16 0:32 ` Laura Abbott
2014-01-16 0:32 ` Laura Abbott
2014-01-16 0:35 ` Russell King - ARM Linux
2014-01-16 0:35 ` Russell King - ARM Linux
2014-01-16 2:13 ` Mark Salter
2014-01-16 2:13 ` Mark Salter
2014-01-10 3:50 ` [PATCH v3 5/6] arm64: initialize pgprot info earlier in boot Mark Salter
2014-01-10 3:50 ` Mark Salter
2014-01-10 3:50 ` [PATCH v3 6/6] arm64: add early_ioremap support Mark Salter
2014-01-10 3:50 ` Mark Salter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389387122.2591.96.camel@deneb.redhat.com \
--to=msalter@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.