* [meta-fsl-demos][PATCH 0/3] packagegroup refactoring
@ 2014-01-24 23:45 ronunes
2014-01-24 23:45 ` [meta-fsl-demos][PATCH 1/3] packagegroup: rename to packagegroups ronunes
` (3 more replies)
0 siblings, 4 replies; 14+ messages in thread
From: ronunes @ 2014-01-24 23:45 UTC (permalink / raw)
To: meta-freescale; +Cc: Rogerio Nunes
From: Rogerio Nunes <rogerio.nunes@freescale.com>
This patchset refactors the packagegroup recipe, spliting it in
smaller recipes.
With this approach, it will be easier to organize the inclusion of
more packagegroups, and also to re-organize packages already
grouped in one of the current groups.
This is not only about code refactoring tough.
We will have better scalablity also in build time.
When a single packagegroup from a recipe that includes multiple
packagegroups is added to one image, all the tasks to build all
the packages from the same recipe file are added to the execution
queue. In other words, if you need only one of the packagegroups
from a big recipe file in your image, currently you are paying
a high price in terms of build time for this convenience.
Longer term, I hope we will be able to have a better set of reference
images in this layer, from small ones that can be built faster, to
more complete images full of features.
Regards.
Rogerio Nunes (3):
packagegroup: rename to packagegroups
packagegroup-fsl: split packagegroup into multiple recipes
packagegroup-fsl-tools-testapps: Use amd-gpu-x11-bin-mx51 only with
X11
recipes-fsl/packagegroup/packagegroup-fsl.bb | 89 ----------------------
.../packagegroups/packagegroup-fsl-gstreamer.bb | 33 ++++++++
.../packagegroup-fsl-tools-benchmark.bb | 20 +++++
.../packagegroup-fsl-tools-testapps.bb | 45 +++++++++++
4 files changed, 98 insertions(+), 89 deletions(-)
delete mode 100644 recipes-fsl/packagegroup/packagegroup-fsl.bb
create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb
create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb
create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
--
1.8.3.2
^ permalink raw reply [flat|nested] 14+ messages in thread
* [meta-fsl-demos][PATCH 1/3] packagegroup: rename to packagegroups
2014-01-24 23:45 [meta-fsl-demos][PATCH 0/3] packagegroup refactoring ronunes
@ 2014-01-24 23:45 ` ronunes
2014-01-25 13:39 ` Fabio Estevam
2014-01-25 19:15 ` Daiane Angolini
2014-01-24 23:45 ` [meta-fsl-demos][PATCH 2/3] packagegroup-fsl: split packagegroup into multiple recipes ronunes
` (2 subsequent siblings)
3 siblings, 2 replies; 14+ messages in thread
From: ronunes @ 2014-01-24 23:45 UTC (permalink / raw)
To: meta-freescale; +Cc: Rogerio Nunes
From: Rogerio Nunes <rogerio.nunes@freescale.com>
For consistency with other layers, like poky and meta-openembedded,
it's better to have packagegroup(s) directory in the plural version.
This patch prepares the source tree to have the single packagegroup
file split into smaller recipes.
Change-Id: I28ed48fe00dc9cc3875a9029503456af7c4134e6
Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
---
recipes-fsl/packagegroup/packagegroup-fsl.bb | 89 ---------------------------
recipes-fsl/packagegroups/packagegroup-fsl.bb | 89 +++++++++++++++++++++++++++
2 files changed, 89 insertions(+), 89 deletions(-)
delete mode 100644 recipes-fsl/packagegroup/packagegroup-fsl.bb
create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl.bb
diff --git a/recipes-fsl/packagegroup/packagegroup-fsl.bb b/recipes-fsl/packagegroup/packagegroup-fsl.bb
deleted file mode 100644
index 80ce5a4..0000000
--- a/recipes-fsl/packagegroup/packagegroup-fsl.bb
+++ /dev/null
@@ -1,89 +0,0 @@
-# Copyright (C) 2012-2013 Freescale Semiconductor
-# Released under the MIT license (see COPYING.MIT for the terms)
-
-DESCRIPTION = "Freescale package group"
-LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
- file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
-
-PR = "r5"
-
-inherit packagegroup
-
-PROVIDES = "${PACKAGES}"
-PACKAGES += " \
- ${PN}-gstreamer \
- ${PN}-gstreamer-streamer \
- ${PN}-tools-testapps \
- ${PN}-tools-benchmark \
-"
-
-MACHINE_GSTREAMER_PLUGIN ?= ""
-
-RDEPENDS_${PN}-gstreamer = " \
- gst-meta-audio \
- gst-meta-video \
- gst-meta-debug \
- gst-plugins-good-meta \
- ${MACHINE_GSTREAMER_PLUGIN} \
-"
-
-RDEPENDS_${PN}-gstreamer-streamer = " \
- ${PN}-gstreamer \
- gst-plugins-good-udp \
- gst-plugins-good-rtp \
- gst-plugins-good-rtpmanager \
- gst-plugins-good-rtsp \
-"
-
-SOC_TOOLS_TESTAPPS = ""
-SOC_TOOLS_TESTAPPS_mx5 = " \
- amd-gpu-x11-bin-mx51 \
-"
-
-SOC_TOOLS_TESTAPPS_mx6 = " \
- gpu-viv-bin-mx6q \
-"
-
-RDEPENDS_${PN}-tools-testapps = " \
- ${SOC_TOOLS_TESTAPPS} \
- ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
- alsa-utils \
- alsa-tools \
- dosfstools \
- evtest \
- e2fsprogs-mke2fs \
- fsl-rc-local \
- gst-plugins-base-tcp \
- i2c-tools \
- imx-test \
- iproute2 \
- memtester \
- python-subprocess \
- python-datetime \
- python-json \
- ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
- ethtool \
- mtd-utils \
- mtd-utils-ubifs \
-"
-
-RDEPENDS_${PN}-tools-benchmark = " \
- lmbench \
- bonnie++ \
- dbench \
- fio \
- iozone3 \
- iperf \
- nbench-byte \
- tiobench \
- "
-# Disabled as it has CRC problems in denzil branch
-# cpuburn-neon
-
-ALLOW_EMPTY_${PN} = "1"
-ALLOW_EMPTY_${PN}-gstreamer = "1"
-ALLOW_EMPTY_${PN}-tools-testapps = "1"
-ALLOW_EMPTY_${PN}-tools-benchmark = "1"
-
-PACKAGE_ARCH = "${MACHINE_ARCH}"
diff --git a/recipes-fsl/packagegroups/packagegroup-fsl.bb b/recipes-fsl/packagegroups/packagegroup-fsl.bb
new file mode 100644
index 0000000..80ce5a4
--- /dev/null
+++ b/recipes-fsl/packagegroups/packagegroup-fsl.bb
@@ -0,0 +1,89 @@
+# Copyright (C) 2012-2013 Freescale Semiconductor
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+DESCRIPTION = "Freescale package group"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
+ file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
+
+PR = "r5"
+
+inherit packagegroup
+
+PROVIDES = "${PACKAGES}"
+PACKAGES += " \
+ ${PN}-gstreamer \
+ ${PN}-gstreamer-streamer \
+ ${PN}-tools-testapps \
+ ${PN}-tools-benchmark \
+"
+
+MACHINE_GSTREAMER_PLUGIN ?= ""
+
+RDEPENDS_${PN}-gstreamer = " \
+ gst-meta-audio \
+ gst-meta-video \
+ gst-meta-debug \
+ gst-plugins-good-meta \
+ ${MACHINE_GSTREAMER_PLUGIN} \
+"
+
+RDEPENDS_${PN}-gstreamer-streamer = " \
+ ${PN}-gstreamer \
+ gst-plugins-good-udp \
+ gst-plugins-good-rtp \
+ gst-plugins-good-rtpmanager \
+ gst-plugins-good-rtsp \
+"
+
+SOC_TOOLS_TESTAPPS = ""
+SOC_TOOLS_TESTAPPS_mx5 = " \
+ amd-gpu-x11-bin-mx51 \
+"
+
+SOC_TOOLS_TESTAPPS_mx6 = " \
+ gpu-viv-bin-mx6q \
+"
+
+RDEPENDS_${PN}-tools-testapps = " \
+ ${SOC_TOOLS_TESTAPPS} \
+ ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
+ alsa-utils \
+ alsa-tools \
+ dosfstools \
+ evtest \
+ e2fsprogs-mke2fs \
+ fsl-rc-local \
+ gst-plugins-base-tcp \
+ i2c-tools \
+ imx-test \
+ iproute2 \
+ memtester \
+ python-subprocess \
+ python-datetime \
+ python-json \
+ ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
+ ethtool \
+ mtd-utils \
+ mtd-utils-ubifs \
+"
+
+RDEPENDS_${PN}-tools-benchmark = " \
+ lmbench \
+ bonnie++ \
+ dbench \
+ fio \
+ iozone3 \
+ iperf \
+ nbench-byte \
+ tiobench \
+ "
+# Disabled as it has CRC problems in denzil branch
+# cpuburn-neon
+
+ALLOW_EMPTY_${PN} = "1"
+ALLOW_EMPTY_${PN}-gstreamer = "1"
+ALLOW_EMPTY_${PN}-tools-testapps = "1"
+ALLOW_EMPTY_${PN}-tools-benchmark = "1"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
--
1.8.3.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [meta-fsl-demos][PATCH 2/3] packagegroup-fsl: split packagegroup into multiple recipes
2014-01-24 23:45 [meta-fsl-demos][PATCH 0/3] packagegroup refactoring ronunes
2014-01-24 23:45 ` [meta-fsl-demos][PATCH 1/3] packagegroup: rename to packagegroups ronunes
@ 2014-01-24 23:45 ` ronunes
2014-01-25 19:21 ` Daiane Angolini
2014-01-24 23:45 ` [meta-fsl-demos][PATCH 3/3] packagegroup-fsl-tools-testapps: Use amd-gpu-x11-bin-mx51 only with X11 ronunes
2014-01-25 19:12 ` [meta-fsl-demos][PATCH 0/3] packagegroup refactoring Daiane Angolini
3 siblings, 1 reply; 14+ messages in thread
From: ronunes @ 2014-01-24 23:45 UTC (permalink / raw)
To: meta-freescale; +Cc: Rogerio Nunes
From: Rogerio Nunes <rogerio.nunes@freescale.com>
A single packagegroup recipe with multiple packagegroups inside
results in the execution of a huge amount of tasks when any image
that includes at least one packagegroup is baked.
This patch splits the packagegroup-fsl recipe into multiple
recipes. As a consequence, only tasks related to recipes
actually used in an image have tasks added to the execution
queue.
Change-Id: I9a8cd438337caa5601fd4e904c76ed2e8b5dca36
Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
---
.../packagegroups/packagegroup-fsl-gstreamer.bb | 33 ++++++++
.../packagegroup-fsl-tools-benchmark.bb | 20 +++++
.../packagegroup-fsl-tools-testapps.bb | 45 +++++++++++
recipes-fsl/packagegroups/packagegroup-fsl.bb | 89 ----------------------
4 files changed, 98 insertions(+), 89 deletions(-)
create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb
create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb
create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
delete mode 100644 recipes-fsl/packagegroups/packagegroup-fsl.bb
diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb b/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb
new file mode 100644
index 0000000..c071e75
--- /dev/null
+++ b/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb
@@ -0,0 +1,33 @@
+# Copyright (C) 2012-2014 Freescale Semiconductor
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+DESCRIPTION = "Freescale package group - gstreamer"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
+ file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
+
+inherit packagegroup
+
+PACKAGES += " \
+ ${PN}-streamer \
+"
+
+MACHINE_GSTREAMER_PLUGIN ?= ""
+
+RDEPENDS_${PN} = " \
+ gst-meta-audio \
+ gst-meta-video \
+ gst-meta-debug \
+ gst-plugins-good-meta \
+ ${MACHINE_GSTREAMER_PLUGIN} \
+"
+
+RDEPENDS_${PN}-streamer = " \
+ ${PN} \
+ gst-plugins-good-udp \
+ gst-plugins-good-rtp \
+ gst-plugins-good-rtpmanager \
+ gst-plugins-good-rtsp \
+"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb b/recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb
new file mode 100644
index 0000000..dadefb7
--- /dev/null
+++ b/recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb
@@ -0,0 +1,20 @@
+# Copyright (C) 2012-2014 Freescale Semiconductor
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+DESCRIPTION = "Freescale package group - tools/benchmark"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
+ file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
+
+inherit packagegroup
+
+RDEPENDS_${PN} = " \
+ lmbench \
+ bonnie++ \
+ dbench \
+ fio \
+ iozone3 \
+ iperf \
+ nbench-byte \
+ tiobench \
+"
diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
new file mode 100644
index 0000000..8643991
--- /dev/null
+++ b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
@@ -0,0 +1,45 @@
+# Copyright (C) 2012-2014 Freescale Semiconductor
+# Released under the MIT license (see COPYING.MIT for the terms)
+
+DESCRIPTION = "Freescale package group - tools/testapps"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
+ file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
+
+inherit packagegroup
+
+SOC_TOOLS_TESTAPPS = ""
+SOC_TOOLS_TESTAPPS_mx5 = " \
+ amd-gpu-x11-bin-mx51 \
+"
+
+SOC_TOOLS_TESTAPPS_mx6 = " \
+ gpu-viv-bin-mx6q \
+"
+
+MACHINE_GSTREAMER_PLUGIN ?= ""
+
+RDEPENDS_${PN} = " \
+ ${SOC_TOOLS_TESTAPPS} \
+ ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
+ alsa-utils \
+ alsa-tools \
+ dosfstools \
+ evtest \
+ e2fsprogs-mke2fs \
+ fsl-rc-local \
+ gst-plugins-base-tcp \
+ i2c-tools \
+ imx-test \
+ iproute2 \
+ memtester \
+ python-subprocess \
+ python-datetime \
+ python-json \
+ ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
+ ethtool \
+ mtd-utils \
+ mtd-utils-ubifs \
+"
+
+PACKAGE_ARCH = "${MACHINE_ARCH}"
diff --git a/recipes-fsl/packagegroups/packagegroup-fsl.bb b/recipes-fsl/packagegroups/packagegroup-fsl.bb
deleted file mode 100644
index 80ce5a4..0000000
--- a/recipes-fsl/packagegroups/packagegroup-fsl.bb
+++ /dev/null
@@ -1,89 +0,0 @@
-# Copyright (C) 2012-2013 Freescale Semiconductor
-# Released under the MIT license (see COPYING.MIT for the terms)
-
-DESCRIPTION = "Freescale package group"
-LICENSE = "MIT"
-LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
- file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
-
-PR = "r5"
-
-inherit packagegroup
-
-PROVIDES = "${PACKAGES}"
-PACKAGES += " \
- ${PN}-gstreamer \
- ${PN}-gstreamer-streamer \
- ${PN}-tools-testapps \
- ${PN}-tools-benchmark \
-"
-
-MACHINE_GSTREAMER_PLUGIN ?= ""
-
-RDEPENDS_${PN}-gstreamer = " \
- gst-meta-audio \
- gst-meta-video \
- gst-meta-debug \
- gst-plugins-good-meta \
- ${MACHINE_GSTREAMER_PLUGIN} \
-"
-
-RDEPENDS_${PN}-gstreamer-streamer = " \
- ${PN}-gstreamer \
- gst-plugins-good-udp \
- gst-plugins-good-rtp \
- gst-plugins-good-rtpmanager \
- gst-plugins-good-rtsp \
-"
-
-SOC_TOOLS_TESTAPPS = ""
-SOC_TOOLS_TESTAPPS_mx5 = " \
- amd-gpu-x11-bin-mx51 \
-"
-
-SOC_TOOLS_TESTAPPS_mx6 = " \
- gpu-viv-bin-mx6q \
-"
-
-RDEPENDS_${PN}-tools-testapps = " \
- ${SOC_TOOLS_TESTAPPS} \
- ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
- alsa-utils \
- alsa-tools \
- dosfstools \
- evtest \
- e2fsprogs-mke2fs \
- fsl-rc-local \
- gst-plugins-base-tcp \
- i2c-tools \
- imx-test \
- iproute2 \
- memtester \
- python-subprocess \
- python-datetime \
- python-json \
- ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
- ethtool \
- mtd-utils \
- mtd-utils-ubifs \
-"
-
-RDEPENDS_${PN}-tools-benchmark = " \
- lmbench \
- bonnie++ \
- dbench \
- fio \
- iozone3 \
- iperf \
- nbench-byte \
- tiobench \
- "
-# Disabled as it has CRC problems in denzil branch
-# cpuburn-neon
-
-ALLOW_EMPTY_${PN} = "1"
-ALLOW_EMPTY_${PN}-gstreamer = "1"
-ALLOW_EMPTY_${PN}-tools-testapps = "1"
-ALLOW_EMPTY_${PN}-tools-benchmark = "1"
-
-PACKAGE_ARCH = "${MACHINE_ARCH}"
--
1.8.3.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [meta-fsl-demos][PATCH 3/3] packagegroup-fsl-tools-testapps: Use amd-gpu-x11-bin-mx51 only with X11
2014-01-24 23:45 [meta-fsl-demos][PATCH 0/3] packagegroup refactoring ronunes
2014-01-24 23:45 ` [meta-fsl-demos][PATCH 1/3] packagegroup: rename to packagegroups ronunes
2014-01-24 23:45 ` [meta-fsl-demos][PATCH 2/3] packagegroup-fsl: split packagegroup into multiple recipes ronunes
@ 2014-01-24 23:45 ` ronunes
2014-01-25 18:48 ` Otavio Salvador
2014-01-25 19:12 ` [meta-fsl-demos][PATCH 0/3] packagegroup refactoring Daiane Angolini
3 siblings, 1 reply; 14+ messages in thread
From: ronunes @ 2014-01-24 23:45 UTC (permalink / raw)
To: meta-freescale; +Cc: Rogerio Nunes
From: Rogerio Nunes <rogerio.nunes@freescale.com>
Package amd-gpu-x11-bin-mx51 only works if X11 is in
DISTRO_FEATURES, and it should not be installed otherwise.
Change-Id: I526018066de9b7a7d4fd29c65833e5d5d2487884
Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
---
recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
index 8643991..1fc88e8 100644
--- a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
+++ b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
@@ -10,7 +10,7 @@ inherit packagegroup
SOC_TOOLS_TESTAPPS = ""
SOC_TOOLS_TESTAPPS_mx5 = " \
- amd-gpu-x11-bin-mx51 \
+ ${@base_contains('DISTRO_FEATURES', 'x11', 'amd-gpu-x11-bin-mx51', 'amd-gpu-bin-mx51', d)}
"
SOC_TOOLS_TESTAPPS_mx6 = " \
--
1.8.3.2
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [meta-fsl-demos][PATCH 1/3] packagegroup: rename to packagegroups
2014-01-24 23:45 ` [meta-fsl-demos][PATCH 1/3] packagegroup: rename to packagegroups ronunes
@ 2014-01-25 13:39 ` Fabio Estevam
2014-01-25 18:53 ` Rogerio Nunes
2014-01-25 19:15 ` Daiane Angolini
1 sibling, 1 reply; 14+ messages in thread
From: Fabio Estevam @ 2014-01-25 13:39 UTC (permalink / raw)
To: Rogério Nunes; +Cc: meta-freescale@yoctoproject.org, Rogerio Nunes
Hi Rogerio,
On Fri, Jan 24, 2014 at 9:45 PM, <ronunes@gmail.com> wrote:
> From: Rogerio Nunes <rogerio.nunes@freescale.com>
>
> For consistency with other layers, like poky and meta-openembedded,
> it's better to have packagegroup(s) directory in the plural version.
>
> This patch prepares the source tree to have the single packagegroup
> file split into smaller recipes.
>
> Change-Id: I28ed48fe00dc9cc3875a9029503456af7c4134e6
> Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
> ---
> recipes-fsl/packagegroup/packagegroup-fsl.bb | 89 ---------------------------
> recipes-fsl/packagegroups/packagegroup-fsl.bb | 89 +++++++++++++++++++++++++++
When doing file renames in git it is better to use 'git mv' and then
generate the patch via 'git format patch -M'.
Then the git statistics will present it as a simple file rename change
rather than 89 additions and 89 deletions.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-fsl-demos][PATCH 3/3] packagegroup-fsl-tools-testapps: Use amd-gpu-x11-bin-mx51 only with X11
2014-01-24 23:45 ` [meta-fsl-demos][PATCH 3/3] packagegroup-fsl-tools-testapps: Use amd-gpu-x11-bin-mx51 only with X11 ronunes
@ 2014-01-25 18:48 ` Otavio Salvador
2014-01-25 18:49 ` Otavio Salvador
0 siblings, 1 reply; 14+ messages in thread
From: Otavio Salvador @ 2014-01-25 18:48 UTC (permalink / raw)
To: Rogerio Nunes; +Cc: meta-freescale@yoctoproject.org, Rogerio Nunes
Hello Rogerio,
On Fri, Jan 24, 2014 at 9:45 PM, <ronunes@gmail.com> wrote:
> From: Rogerio Nunes <rogerio.nunes@freescale.com>
>
> Package amd-gpu-x11-bin-mx51 only works if X11 is in
> DISTRO_FEATURES, and it should not be installed otherwise.
>
> Change-Id: I526018066de9b7a7d4fd29c65833e5d5d2487884
> Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
> ---
> recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
> index 8643991..1fc88e8 100644
> --- a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
> +++ b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
> @@ -10,7 +10,7 @@ inherit packagegroup
>
> SOC_TOOLS_TESTAPPS = ""
> SOC_TOOLS_TESTAPPS_mx5 = " \
> - amd-gpu-x11-bin-mx51 \
> + ${@base_contains('DISTRO_FEATURES', 'x11', 'amd-gpu-x11-bin-mx51', 'amd-gpu-bin-mx51', d)}
> "
This will fail at parsing; you forgot the add the \ at end of line.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-fsl-demos][PATCH 3/3] packagegroup-fsl-tools-testapps: Use amd-gpu-x11-bin-mx51 only with X11
2014-01-25 18:48 ` Otavio Salvador
@ 2014-01-25 18:49 ` Otavio Salvador
2014-01-25 18:57 ` Rogerio Nunes
0 siblings, 1 reply; 14+ messages in thread
From: Otavio Salvador @ 2014-01-25 18:49 UTC (permalink / raw)
To: Rogerio Nunes; +Cc: meta-freescale@yoctoproject.org, Rogerio Nunes
On Sat, Jan 25, 2014 at 4:48 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> Hello Rogerio,
>
> On Fri, Jan 24, 2014 at 9:45 PM, <ronunes@gmail.com> wrote:
>> From: Rogerio Nunes <rogerio.nunes@freescale.com>
>>
>> Package amd-gpu-x11-bin-mx51 only works if X11 is in
>> DISTRO_FEATURES, and it should not be installed otherwise.
>>
>> Change-Id: I526018066de9b7a7d4fd29c65833e5d5d2487884
>> Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
>> ---
>> recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
>> index 8643991..1fc88e8 100644
>> --- a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
>> +++ b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
>> @@ -10,7 +10,7 @@ inherit packagegroup
>>
>> SOC_TOOLS_TESTAPPS = ""
>> SOC_TOOLS_TESTAPPS_mx5 = " \
>> - amd-gpu-x11-bin-mx51 \
>> + ${@base_contains('DISTRO_FEATURES', 'x11', 'amd-gpu-x11-bin-mx51', 'amd-gpu-bin-mx51', d)}
>> "
>
> This will fail at parsing; you forgot the add the \ at end of line.
I fixed it locally.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-fsl-demos][PATCH 1/3] packagegroup: rename to packagegroups
2014-01-25 13:39 ` Fabio Estevam
@ 2014-01-25 18:53 ` Rogerio Nunes
0 siblings, 0 replies; 14+ messages in thread
From: Rogerio Nunes @ 2014-01-25 18:53 UTC (permalink / raw)
To: Fabio Estevam; +Cc: meta-freescale@yoctoproject.org, Rogerio Nunes
[-- Attachment #1: Type: text/plain, Size: 1222 bytes --]
Thanks Fabio,
I used git mv, but indeed forgot to use git format-pacth with -M...
I'll be careful next time.
Regards,
Rogerio.
On Sat, Jan 25, 2014 at 8:39 AM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Rogerio,
>
> On Fri, Jan 24, 2014 at 9:45 PM, <ronunes@gmail.com> wrote:
> > From: Rogerio Nunes <rogerio.nunes@freescale.com>
> >
> > For consistency with other layers, like poky and meta-openembedded,
> > it's better to have packagegroup(s) directory in the plural version.
> >
> > This patch prepares the source tree to have the single packagegroup
> > file split into smaller recipes.
> >
> > Change-Id: I28ed48fe00dc9cc3875a9029503456af7c4134e6
> > Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
> > ---
> > recipes-fsl/packagegroup/packagegroup-fsl.bb | 89
> ---------------------------
> > recipes-fsl/packagegroups/packagegroup-fsl.bb | 89
> +++++++++++++++++++++++++++
>
> When doing file renames in git it is better to use 'git mv' and then
> generate the patch via 'git format patch -M'.
>
> Then the git statistics will present it as a simple file rename change
> rather than 89 additions and 89 deletions.
>
> Regards,
>
> Fabio Estevam
>
[-- Attachment #2: Type: text/html, Size: 1994 bytes --]
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-fsl-demos][PATCH 3/3] packagegroup-fsl-tools-testapps: Use amd-gpu-x11-bin-mx51 only with X11
2014-01-25 18:49 ` Otavio Salvador
@ 2014-01-25 18:57 ` Rogerio Nunes
0 siblings, 0 replies; 14+ messages in thread
From: Rogerio Nunes @ 2014-01-25 18:57 UTC (permalink / raw)
To: Otavio Salvador; +Cc: meta-freescale@yoctoproject.org, Rogerio Nunes
On Sat, Jan 25, 2014 at 1:49 PM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
>
> On Sat, Jan 25, 2014 at 4:48 PM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
> > Hello Rogerio,
> >
> > On Fri, Jan 24, 2014 at 9:45 PM, <ronunes@gmail.com> wrote:
> >> From: Rogerio Nunes <rogerio.nunes@freescale.com>
> >>
> >> Package amd-gpu-x11-bin-mx51 only works if X11 is in
> >> DISTRO_FEATURES, and it should not be installed otherwise.
> >>
> >> Change-Id: I526018066de9b7a7d4fd29c65833e5d5d2487884
> >> Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
> >> ---
> >> recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
> >> index 8643991..1fc88e8 100644
> >> --- a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
> >> +++ b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
> >> @@ -10,7 +10,7 @@ inherit packagegroup
> >>
> >> SOC_TOOLS_TESTAPPS = ""
> >> SOC_TOOLS_TESTAPPS_mx5 = " \
> >> - amd-gpu-x11-bin-mx51 \
> >> + ${@base_contains('DISTRO_FEATURES', 'x11', 'amd-gpu-x11-bin-mx51', 'amd-gpu-bin-mx51', d)}
> >> "
> >
> > This will fail at parsing; you forgot the add the \ at end of line.
>
> I fixed it locally.
Thanks!! V2 was ready just in case :)
>
> --
> Otavio Salvador O.S. Systems
> http://www.ossystems.com.br http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-fsl-demos][PATCH 0/3] packagegroup refactoring
2014-01-24 23:45 [meta-fsl-demos][PATCH 0/3] packagegroup refactoring ronunes
` (2 preceding siblings ...)
2014-01-24 23:45 ` [meta-fsl-demos][PATCH 3/3] packagegroup-fsl-tools-testapps: Use amd-gpu-x11-bin-mx51 only with X11 ronunes
@ 2014-01-25 19:12 ` Daiane Angolini
3 siblings, 0 replies; 14+ messages in thread
From: Daiane Angolini @ 2014-01-25 19:12 UTC (permalink / raw)
To: ronunes; +Cc: meta-freescale@yoctoproject.org, Rogerio Nunes
On Fri, Jan 24, 2014 at 9:45 PM, <ronunes@gmail.com> wrote:
> From: Rogerio Nunes <rogerio.nunes@freescale.com>
>
> This patchset refactors the packagegroup recipe, spliting it in
> smaller recipes.
>
> With this approach, it will be easier to organize the inclusion of
> more packagegroups, and also to re-organize packages already
> grouped in one of the current groups.
>
> This is not only about code refactoring tough.
> We will have better scalablity also in build time.
>
> When a single packagegroup from a recipe that includes multiple
> packagegroups is added to one image, all the tasks to build all
> the packages from the same recipe file are added to the execution
> queue. In other words, if you need only one of the packagegroups
> from a big recipe file in your image, currently you are paying
> a high price in terms of build time for this convenience.
I'm going to star the review (so, I haven't seem the patches yet), I
hope you have included this
info on your commit log.
>
> Longer term, I hope we will be able to have a better set of reference
> images in this layer, from small ones that can be built faster, to
> more complete images full of features.
I agree, and I hope we can get this for 1.6
Daiane
>
> Regards.
>
> Rogerio Nunes (3):
> packagegroup: rename to packagegroups
> packagegroup-fsl: split packagegroup into multiple recipes
> packagegroup-fsl-tools-testapps: Use amd-gpu-x11-bin-mx51 only with
> X11
>
> recipes-fsl/packagegroup/packagegroup-fsl.bb | 89 ----------------------
> .../packagegroups/packagegroup-fsl-gstreamer.bb | 33 ++++++++
> .../packagegroup-fsl-tools-benchmark.bb | 20 +++++
> .../packagegroup-fsl-tools-testapps.bb | 45 +++++++++++
> 4 files changed, 98 insertions(+), 89 deletions(-)
> delete mode 100644 recipes-fsl/packagegroup/packagegroup-fsl.bb
> create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb
> create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb
> create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
>
> --
> 1.8.3.2
>
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-fsl-demos][PATCH 1/3] packagegroup: rename to packagegroups
2014-01-24 23:45 ` [meta-fsl-demos][PATCH 1/3] packagegroup: rename to packagegroups ronunes
2014-01-25 13:39 ` Fabio Estevam
@ 2014-01-25 19:15 ` Daiane Angolini
1 sibling, 0 replies; 14+ messages in thread
From: Daiane Angolini @ 2014-01-25 19:15 UTC (permalink / raw)
To: ronunes; +Cc: meta-freescale@yoctoproject.org, Rogerio Nunes
On Fri, Jan 24, 2014 at 9:45 PM, <ronunes@gmail.com> wrote:
> From: Rogerio Nunes <rogerio.nunes@freescale.com>
>
> For consistency with other layers, like poky and meta-openembedded,
> it's better to have packagegroup(s) directory in the plural version.
>
> This patch prepares the source tree to have the single packagegroup
> file split into smaller recipes.
It's nice to see a long commit log, thanks a lot.
reviewed
Daiane
>
> Change-Id: I28ed48fe00dc9cc3875a9029503456af7c4134e6
> Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
> ---
> recipes-fsl/packagegroup/packagegroup-fsl.bb | 89 ---------------------------
> recipes-fsl/packagegroups/packagegroup-fsl.bb | 89 +++++++++++++++++++++++++++
> 2 files changed, 89 insertions(+), 89 deletions(-)
> delete mode 100644 recipes-fsl/packagegroup/packagegroup-fsl.bb
> create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl.bb
>
> diff --git a/recipes-fsl/packagegroup/packagegroup-fsl.bb b/recipes-fsl/packagegroup/packagegroup-fsl.bb
> deleted file mode 100644
> index 80ce5a4..0000000
> --- a/recipes-fsl/packagegroup/packagegroup-fsl.bb
> +++ /dev/null
> @@ -1,89 +0,0 @@
> -# Copyright (C) 2012-2013 Freescale Semiconductor
> -# Released under the MIT license (see COPYING.MIT for the terms)
> -
> -DESCRIPTION = "Freescale package group"
> -LICENSE = "MIT"
> -LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
> - file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> -
> -PR = "r5"
> -
> -inherit packagegroup
> -
> -PROVIDES = "${PACKAGES}"
> -PACKAGES += " \
> - ${PN}-gstreamer \
> - ${PN}-gstreamer-streamer \
> - ${PN}-tools-testapps \
> - ${PN}-tools-benchmark \
> -"
> -
> -MACHINE_GSTREAMER_PLUGIN ?= ""
> -
> -RDEPENDS_${PN}-gstreamer = " \
> - gst-meta-audio \
> - gst-meta-video \
> - gst-meta-debug \
> - gst-plugins-good-meta \
> - ${MACHINE_GSTREAMER_PLUGIN} \
> -"
> -
> -RDEPENDS_${PN}-gstreamer-streamer = " \
> - ${PN}-gstreamer \
> - gst-plugins-good-udp \
> - gst-plugins-good-rtp \
> - gst-plugins-good-rtpmanager \
> - gst-plugins-good-rtsp \
> -"
> -
> -SOC_TOOLS_TESTAPPS = ""
> -SOC_TOOLS_TESTAPPS_mx5 = " \
> - amd-gpu-x11-bin-mx51 \
> -"
> -
> -SOC_TOOLS_TESTAPPS_mx6 = " \
> - gpu-viv-bin-mx6q \
> -"
> -
> -RDEPENDS_${PN}-tools-testapps = " \
> - ${SOC_TOOLS_TESTAPPS} \
> - ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
> - alsa-utils \
> - alsa-tools \
> - dosfstools \
> - evtest \
> - e2fsprogs-mke2fs \
> - fsl-rc-local \
> - gst-plugins-base-tcp \
> - i2c-tools \
> - imx-test \
> - iproute2 \
> - memtester \
> - python-subprocess \
> - python-datetime \
> - python-json \
> - ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
> - ethtool \
> - mtd-utils \
> - mtd-utils-ubifs \
> -"
> -
> -RDEPENDS_${PN}-tools-benchmark = " \
> - lmbench \
> - bonnie++ \
> - dbench \
> - fio \
> - iozone3 \
> - iperf \
> - nbench-byte \
> - tiobench \
> - "
> -# Disabled as it has CRC problems in denzil branch
> -# cpuburn-neon
> -
> -ALLOW_EMPTY_${PN} = "1"
> -ALLOW_EMPTY_${PN}-gstreamer = "1"
> -ALLOW_EMPTY_${PN}-tools-testapps = "1"
> -ALLOW_EMPTY_${PN}-tools-benchmark = "1"
> -
> -PACKAGE_ARCH = "${MACHINE_ARCH}"
> diff --git a/recipes-fsl/packagegroups/packagegroup-fsl.bb b/recipes-fsl/packagegroups/packagegroup-fsl.bb
> new file mode 100644
> index 0000000..80ce5a4
> --- /dev/null
> +++ b/recipes-fsl/packagegroups/packagegroup-fsl.bb
> @@ -0,0 +1,89 @@
> +# Copyright (C) 2012-2013 Freescale Semiconductor
> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +DESCRIPTION = "Freescale package group"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
> + file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> +
> +PR = "r5"
> +
> +inherit packagegroup
> +
> +PROVIDES = "${PACKAGES}"
> +PACKAGES += " \
> + ${PN}-gstreamer \
> + ${PN}-gstreamer-streamer \
> + ${PN}-tools-testapps \
> + ${PN}-tools-benchmark \
> +"
> +
> +MACHINE_GSTREAMER_PLUGIN ?= ""
> +
> +RDEPENDS_${PN}-gstreamer = " \
> + gst-meta-audio \
> + gst-meta-video \
> + gst-meta-debug \
> + gst-plugins-good-meta \
> + ${MACHINE_GSTREAMER_PLUGIN} \
> +"
> +
> +RDEPENDS_${PN}-gstreamer-streamer = " \
> + ${PN}-gstreamer \
> + gst-plugins-good-udp \
> + gst-plugins-good-rtp \
> + gst-plugins-good-rtpmanager \
> + gst-plugins-good-rtsp \
> +"
> +
> +SOC_TOOLS_TESTAPPS = ""
> +SOC_TOOLS_TESTAPPS_mx5 = " \
> + amd-gpu-x11-bin-mx51 \
> +"
> +
> +SOC_TOOLS_TESTAPPS_mx6 = " \
> + gpu-viv-bin-mx6q \
> +"
> +
> +RDEPENDS_${PN}-tools-testapps = " \
> + ${SOC_TOOLS_TESTAPPS} \
> + ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
> + alsa-utils \
> + alsa-tools \
> + dosfstools \
> + evtest \
> + e2fsprogs-mke2fs \
> + fsl-rc-local \
> + gst-plugins-base-tcp \
> + i2c-tools \
> + imx-test \
> + iproute2 \
> + memtester \
> + python-subprocess \
> + python-datetime \
> + python-json \
> + ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
> + ethtool \
> + mtd-utils \
> + mtd-utils-ubifs \
> +"
> +
> +RDEPENDS_${PN}-tools-benchmark = " \
> + lmbench \
> + bonnie++ \
> + dbench \
> + fio \
> + iozone3 \
> + iperf \
> + nbench-byte \
> + tiobench \
> + "
> +# Disabled as it has CRC problems in denzil branch
> +# cpuburn-neon
> +
> +ALLOW_EMPTY_${PN} = "1"
> +ALLOW_EMPTY_${PN}-gstreamer = "1"
> +ALLOW_EMPTY_${PN}-tools-testapps = "1"
> +ALLOW_EMPTY_${PN}-tools-benchmark = "1"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> --
> 1.8.3.2
>
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-fsl-demos][PATCH 2/3] packagegroup-fsl: split packagegroup into multiple recipes
2014-01-24 23:45 ` [meta-fsl-demos][PATCH 2/3] packagegroup-fsl: split packagegroup into multiple recipes ronunes
@ 2014-01-25 19:21 ` Daiane Angolini
2014-01-25 20:23 ` Rogerio Nunes
0 siblings, 1 reply; 14+ messages in thread
From: Daiane Angolini @ 2014-01-25 19:21 UTC (permalink / raw)
To: ronunes; +Cc: meta-freescale@yoctoproject.org, Rogerio Nunes
On Fri, Jan 24, 2014 at 9:45 PM, <ronunes@gmail.com> wrote:
> From: Rogerio Nunes <rogerio.nunes@freescale.com>
>
> A single packagegroup recipe with multiple packagegroups inside
> results in the execution of a huge amount of tasks when any image
> that includes at least one packagegroup is baked.
>
> This patch splits the packagegroup-fsl recipe into multiple
> recipes. As a consequence, only tasks related to recipes
> actually used in an image have tasks added to the execution
> queue.
>
> Change-Id: I9a8cd438337caa5601fd4e904c76ed2e8b5dca36
> Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
> ---
> .../packagegroups/packagegroup-fsl-gstreamer.bb | 33 ++++++++
> .../packagegroup-fsl-tools-benchmark.bb | 20 +++++
> .../packagegroup-fsl-tools-testapps.bb | 45 +++++++++++
> recipes-fsl/packagegroups/packagegroup-fsl.bb | 89 ----------------------
> 4 files changed, 98 insertions(+), 89 deletions(-)
> create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb
> create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb
> create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
> delete mode 100644 recipes-fsl/packagegroups/packagegroup-fsl.bb
>
> diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb b/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb
> new file mode 100644
> index 0000000..c071e75
> --- /dev/null
> +++ b/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb
> @@ -0,0 +1,33 @@
> +# Copyright (C) 2012-2014 Freescale Semiconductor
> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +DESCRIPTION = "Freescale package group - gstreamer"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
> + file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> +
> +inherit packagegroup
> +
> +PACKAGES += " \
> + ${PN}-streamer \
> +"
> +
> +MACHINE_GSTREAMER_PLUGIN ?= ""
> +
> +RDEPENDS_${PN} = " \
> + gst-meta-audio \
> + gst-meta-video \
> + gst-meta-debug \
> + gst-plugins-good-meta \
> + ${MACHINE_GSTREAMER_PLUGIN} \
> +"
> +
> +RDEPENDS_${PN}-streamer = " \
> + ${PN} \
> + gst-plugins-good-udp \
> + gst-plugins-good-rtp \
> + gst-plugins-good-rtpmanager \
> + gst-plugins-good-rtsp \
> +"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb b/recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb
> new file mode 100644
> index 0000000..dadefb7
> --- /dev/null
> +++ b/recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb
> @@ -0,0 +1,20 @@
> +# Copyright (C) 2012-2014 Freescale Semiconductor
> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +DESCRIPTION = "Freescale package group - tools/benchmark"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
> + file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> +
> +inherit packagegroup
> +
> +RDEPENDS_${PN} = " \
> + lmbench \
> + bonnie++ \
> + dbench \
> + fio \
> + iozone3 \
> + iperf \
> + nbench-byte \
> + tiobench \
> +"
> diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
> new file mode 100644
> index 0000000..8643991
> --- /dev/null
> +++ b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
> @@ -0,0 +1,45 @@
> +# Copyright (C) 2012-2014 Freescale Semiconductor
> +# Released under the MIT license (see COPYING.MIT for the terms)
> +
> +DESCRIPTION = "Freescale package group - tools/testapps"
> +LICENSE = "MIT"
> +LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
> + file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> +
> +inherit packagegroup
> +
> +SOC_TOOLS_TESTAPPS = ""
> +SOC_TOOLS_TESTAPPS_mx5 = " \
> + amd-gpu-x11-bin-mx51 \
> +"
> +
> +SOC_TOOLS_TESTAPPS_mx6 = " \
> + gpu-viv-bin-mx6q \
> +"
> +
> +MACHINE_GSTREAMER_PLUGIN ?= ""
> +
> +RDEPENDS_${PN} = " \
> + ${SOC_TOOLS_TESTAPPS} \
> + ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
> + alsa-utils \
> + alsa-tools \
> + dosfstools \
> + evtest \
> + e2fsprogs-mke2fs \
> + fsl-rc-local \
> + gst-plugins-base-tcp \
> + i2c-tools \
> + imx-test \
> + iproute2 \
> + memtester \
> + python-subprocess \
> + python-datetime \
> + python-json \
> + ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
> + ethtool \
> + mtd-utils \
> + mtd-utils-ubifs \
> +"
> +
> +PACKAGE_ARCH = "${MACHINE_ARCH}"
> diff --git a/recipes-fsl/packagegroups/packagegroup-fsl.bb b/recipes-fsl/packagegroups/packagegroup-fsl.bb
> deleted file mode 100644
> index 80ce5a4..0000000
> --- a/recipes-fsl/packagegroups/packagegroup-fsl.bb
> +++ /dev/null
> @@ -1,89 +0,0 @@
> -# Copyright (C) 2012-2013 Freescale Semiconductor
> -# Released under the MIT license (see COPYING.MIT for the terms)
> -
> -DESCRIPTION = "Freescale package group"
> -LICENSE = "MIT"
> -LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
> - file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> -
> -PR = "r5"
> -
> -inherit packagegroup
> -
> -PROVIDES = "${PACKAGES}"
> -PACKAGES += " \
> - ${PN}-gstreamer \
> - ${PN}-gstreamer-streamer \
> - ${PN}-tools-testapps \
> - ${PN}-tools-benchmark \
> -"
> -
> -MACHINE_GSTREAMER_PLUGIN ?= ""
> -
> -RDEPENDS_${PN}-gstreamer = " \
> - gst-meta-audio \
> - gst-meta-video \
> - gst-meta-debug \
> - gst-plugins-good-meta \
> - ${MACHINE_GSTREAMER_PLUGIN} \
> -"
> -
> -RDEPENDS_${PN}-gstreamer-streamer = " \
> - ${PN}-gstreamer \
> - gst-plugins-good-udp \
> - gst-plugins-good-rtp \
> - gst-plugins-good-rtpmanager \
> - gst-plugins-good-rtsp \
> -"
> -
> -SOC_TOOLS_TESTAPPS = ""
> -SOC_TOOLS_TESTAPPS_mx5 = " \
> - amd-gpu-x11-bin-mx51 \
> -"
> -
> -SOC_TOOLS_TESTAPPS_mx6 = " \
> - gpu-viv-bin-mx6q \
> -"
> -
> -RDEPENDS_${PN}-tools-testapps = " \
> - ${SOC_TOOLS_TESTAPPS} \
> - ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
> - alsa-utils \
> - alsa-tools \
> - dosfstools \
> - evtest \
> - e2fsprogs-mke2fs \
> - fsl-rc-local \
> - gst-plugins-base-tcp \
> - i2c-tools \
> - imx-test \
> - iproute2 \
> - memtester \
> - python-subprocess \
> - python-datetime \
> - python-json \
> - ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
> - ethtool \
> - mtd-utils \
> - mtd-utils-ubifs \
> -"
> -
> -RDEPENDS_${PN}-tools-benchmark = " \
> - lmbench \
> - bonnie++ \
> - dbench \
> - fio \
> - iozone3 \
> - iperf \
> - nbench-byte \
> - tiobench \
> - "
> -# Disabled as it has CRC problems in denzil branch
> -# cpuburn-neon
You have dropped this comment with no note on commit log
> -
> -ALLOW_EMPTY_${PN} = "1"
> -ALLOW_EMPTY_${PN}-gstreamer = "1"
> -ALLOW_EMPTY_${PN}-tools-testapps = "1"
> -ALLOW_EMPTY_${PN}-tools-benchmark = "1"
You have dropped all the "allow_empty" with no reason on commit log.
It made me think, what the reason for the ALLOW_EMPTY here? (anyway, please
add a note on commit log for those things being dropped)
Daiane
> -
> -PACKAGE_ARCH = "${MACHINE_ARCH}"
> --
> 1.8.3.2
>
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-fsl-demos][PATCH 2/3] packagegroup-fsl: split packagegroup into multiple recipes
2014-01-25 19:21 ` Daiane Angolini
@ 2014-01-25 20:23 ` Rogerio Nunes
2014-01-25 21:51 ` Otavio Salvador
0 siblings, 1 reply; 14+ messages in thread
From: Rogerio Nunes @ 2014-01-25 20:23 UTC (permalink / raw)
To: Daiane Angolini; +Cc: meta-freescale@yoctoproject.org, Rogerio Nunes
On Sat, Jan 25, 2014 at 2:21 PM, Daiane Angolini <daiane.list@gmail.com> wrote:
> On Fri, Jan 24, 2014 at 9:45 PM, <ronunes@gmail.com> wrote:
>> From: Rogerio Nunes <rogerio.nunes@freescale.com>
>>
>> A single packagegroup recipe with multiple packagegroups inside
>> results in the execution of a huge amount of tasks when any image
>> that includes at least one packagegroup is baked.
>>
>> This patch splits the packagegroup-fsl recipe into multiple
>> recipes. As a consequence, only tasks related to recipes
>> actually used in an image have tasks added to the execution
>> queue.
>>
>> Change-Id: I9a8cd438337caa5601fd4e904c76ed2e8b5dca36
>> Signed-off-by: Rogerio Nunes <rogerio.nunes@freescale.com>
>> ---
>> .../packagegroups/packagegroup-fsl-gstreamer.bb | 33 ++++++++
>> .../packagegroup-fsl-tools-benchmark.bb | 20 +++++
>> .../packagegroup-fsl-tools-testapps.bb | 45 +++++++++++
>> recipes-fsl/packagegroups/packagegroup-fsl.bb | 89 ----------------------
>> 4 files changed, 98 insertions(+), 89 deletions(-)
>> create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb
>> create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb
>> create mode 100644 recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
>> delete mode 100644 recipes-fsl/packagegroups/packagegroup-fsl.bb
>>
>> diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb b/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb
>> new file mode 100644
>> index 0000000..c071e75
>> --- /dev/null
>> +++ b/recipes-fsl/packagegroups/packagegroup-fsl-gstreamer.bb
>> @@ -0,0 +1,33 @@
>> +# Copyright (C) 2012-2014 Freescale Semiconductor
>> +# Released under the MIT license (see COPYING.MIT for the terms)
>> +
>> +DESCRIPTION = "Freescale package group - gstreamer"
>> +LICENSE = "MIT"
>> +LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
>> + file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>> +
>> +inherit packagegroup
>> +
>> +PACKAGES += " \
>> + ${PN}-streamer \
>> +"
>> +
>> +MACHINE_GSTREAMER_PLUGIN ?= ""
>> +
>> +RDEPENDS_${PN} = " \
>> + gst-meta-audio \
>> + gst-meta-video \
>> + gst-meta-debug \
>> + gst-plugins-good-meta \
>> + ${MACHINE_GSTREAMER_PLUGIN} \
>> +"
>> +
>> +RDEPENDS_${PN}-streamer = " \
>> + ${PN} \
>> + gst-plugins-good-udp \
>> + gst-plugins-good-rtp \
>> + gst-plugins-good-rtpmanager \
>> + gst-plugins-good-rtsp \
>> +"
>> +
>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
>> diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb b/recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb
>> new file mode 100644
>> index 0000000..dadefb7
>> --- /dev/null
>> +++ b/recipes-fsl/packagegroups/packagegroup-fsl-tools-benchmark.bb
>> @@ -0,0 +1,20 @@
>> +# Copyright (C) 2012-2014 Freescale Semiconductor
>> +# Released under the MIT license (see COPYING.MIT for the terms)
>> +
>> +DESCRIPTION = "Freescale package group - tools/benchmark"
>> +LICENSE = "MIT"
>> +LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
>> + file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>> +
>> +inherit packagegroup
>> +
>> +RDEPENDS_${PN} = " \
>> + lmbench \
>> + bonnie++ \
>> + dbench \
>> + fio \
>> + iozone3 \
>> + iperf \
>> + nbench-byte \
>> + tiobench \
>> +"
>> diff --git a/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
>> new file mode 100644
>> index 0000000..8643991
>> --- /dev/null
>> +++ b/recipes-fsl/packagegroups/packagegroup-fsl-tools-testapps.bb
>> @@ -0,0 +1,45 @@
>> +# Copyright (C) 2012-2014 Freescale Semiconductor
>> +# Released under the MIT license (see COPYING.MIT for the terms)
>> +
>> +DESCRIPTION = "Freescale package group - tools/testapps"
>> +LICENSE = "MIT"
>> +LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
>> + file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>> +
>> +inherit packagegroup
>> +
>> +SOC_TOOLS_TESTAPPS = ""
>> +SOC_TOOLS_TESTAPPS_mx5 = " \
>> + amd-gpu-x11-bin-mx51 \
>> +"
>> +
>> +SOC_TOOLS_TESTAPPS_mx6 = " \
>> + gpu-viv-bin-mx6q \
>> +"
>> +
>> +MACHINE_GSTREAMER_PLUGIN ?= ""
>> +
>> +RDEPENDS_${PN} = " \
>> + ${SOC_TOOLS_TESTAPPS} \
>> + ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
>> + alsa-utils \
>> + alsa-tools \
>> + dosfstools \
>> + evtest \
>> + e2fsprogs-mke2fs \
>> + fsl-rc-local \
>> + gst-plugins-base-tcp \
>> + i2c-tools \
>> + imx-test \
>> + iproute2 \
>> + memtester \
>> + python-subprocess \
>> + python-datetime \
>> + python-json \
>> + ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
>> + ethtool \
>> + mtd-utils \
>> + mtd-utils-ubifs \
>> +"
>> +
>> +PACKAGE_ARCH = "${MACHINE_ARCH}"
>> diff --git a/recipes-fsl/packagegroups/packagegroup-fsl.bb b/recipes-fsl/packagegroups/packagegroup-fsl.bb
>> deleted file mode 100644
>> index 80ce5a4..0000000
>> --- a/recipes-fsl/packagegroups/packagegroup-fsl.bb
>> +++ /dev/null
>> @@ -1,89 +0,0 @@
>> -# Copyright (C) 2012-2013 Freescale Semiconductor
>> -# Released under the MIT license (see COPYING.MIT for the terms)
>> -
>> -DESCRIPTION = "Freescale package group"
>> -LICENSE = "MIT"
>> -LIC_FILES_CHKSUM = "file://${COREBASE}/LICENSE;md5=3f40d7994397109285ec7b81fdeb3b58 \
>> - file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>> -
>> -PR = "r5"
>> -
>> -inherit packagegroup
>> -
>> -PROVIDES = "${PACKAGES}"
>> -PACKAGES += " \
>> - ${PN}-gstreamer \
>> - ${PN}-gstreamer-streamer \
>> - ${PN}-tools-testapps \
>> - ${PN}-tools-benchmark \
>> -"
>> -
>> -MACHINE_GSTREAMER_PLUGIN ?= ""
>> -
>> -RDEPENDS_${PN}-gstreamer = " \
>> - gst-meta-audio \
>> - gst-meta-video \
>> - gst-meta-debug \
>> - gst-plugins-good-meta \
>> - ${MACHINE_GSTREAMER_PLUGIN} \
>> -"
>> -
>> -RDEPENDS_${PN}-gstreamer-streamer = " \
>> - ${PN}-gstreamer \
>> - gst-plugins-good-udp \
>> - gst-plugins-good-rtp \
>> - gst-plugins-good-rtpmanager \
>> - gst-plugins-good-rtsp \
>> -"
>> -
>> -SOC_TOOLS_TESTAPPS = ""
>> -SOC_TOOLS_TESTAPPS_mx5 = " \
>> - amd-gpu-x11-bin-mx51 \
>> -"
>> -
>> -SOC_TOOLS_TESTAPPS_mx6 = " \
>> - gpu-viv-bin-mx6q \
>> -"
>> -
>> -RDEPENDS_${PN}-tools-testapps = " \
>> - ${SOC_TOOLS_TESTAPPS} \
>> - ${@base_contains("MACHINE_GSTREAMER_PLUGIN", "gst-fsl-plugin", "gst-fsl-plugin-gplay", "", d)} \
>> - alsa-utils \
>> - alsa-tools \
>> - dosfstools \
>> - evtest \
>> - e2fsprogs-mke2fs \
>> - fsl-rc-local \
>> - gst-plugins-base-tcp \
>> - i2c-tools \
>> - imx-test \
>> - iproute2 \
>> - memtester \
>> - python-subprocess \
>> - python-datetime \
>> - python-json \
>> - ${@base_contains('DISTRO_FEATURES', 'x11', 'v4l-utils', '', d)} \
>> - ethtool \
>> - mtd-utils \
>> - mtd-utils-ubifs \
>> -"
>> -
>> -RDEPENDS_${PN}-tools-benchmark = " \
>> - lmbench \
>> - bonnie++ \
>> - dbench \
>> - fio \
>> - iozone3 \
>> - iperf \
>> - nbench-byte \
>> - tiobench \
>> - "
>> -# Disabled as it has CRC problems in denzil branch
>> -# cpuburn-neon
>
> You have dropped this comment with no note on commit log
>
Sorry that I didn't bring this comment along. The idea now with the
recipes split is to review
the RDEPEDS for the packages, and also to create/reorg the recipes to
better fit image requirements.
One question though, why cpuburn-neon is still commented out for a
problem in denzil?
I kind of assumed that being still a comment after dylan and dora it
was not that necessary :)
>> -
>> -ALLOW_EMPTY_${PN} = "1"
>> -ALLOW_EMPTY_${PN}-gstreamer = "1"
>> -ALLOW_EMPTY_${PN}-tools-testapps = "1"
>> -ALLOW_EMPTY_${PN}-tools-benchmark = "1"
>
> You have dropped all the "allow_empty" with no reason on commit log.
> It made me think, what the reason for the ALLOW_EMPTY here? (anyway, please
> add a note on commit log for those things being dropped)
>
The packagegroup class sets ALLOW_EMPTY variables automatically for
all packages listed in the
PACKAGES variable in the recipe.
>
>
> Daiane
>
>> -
>> -PACKAGE_ARCH = "${MACHINE_ARCH}"
>> --
>> 1.8.3.2
>>
>> _______________________________________________
>> meta-freescale mailing list
>> meta-freescale@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/meta-freescale
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [meta-fsl-demos][PATCH 2/3] packagegroup-fsl: split packagegroup into multiple recipes
2014-01-25 20:23 ` Rogerio Nunes
@ 2014-01-25 21:51 ` Otavio Salvador
0 siblings, 0 replies; 14+ messages in thread
From: Otavio Salvador @ 2014-01-25 21:51 UTC (permalink / raw)
To: Rogerio Nunes; +Cc: meta-freescale@yoctoproject.org, Rogerio Nunes
On Sat, Jan 25, 2014 at 6:23 PM, Rogerio Nunes <ronunes@gmail.com> wrote:
> One question though, why cpuburn-neon is still commented out for a
> problem in denzil?
> I kind of assumed that being still a comment after dylan and dora it
> was not that necessary :)
This were commented because it had broken source; it has been fixed
but nobody recall to re-enable it.
You can send a patch adding it back but you need to also do it
conditionally as not all SoC support NEON and if not supported we
ought to use cpuburn instead.
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2014-01-25 21:51 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-24 23:45 [meta-fsl-demos][PATCH 0/3] packagegroup refactoring ronunes
2014-01-24 23:45 ` [meta-fsl-demos][PATCH 1/3] packagegroup: rename to packagegroups ronunes
2014-01-25 13:39 ` Fabio Estevam
2014-01-25 18:53 ` Rogerio Nunes
2014-01-25 19:15 ` Daiane Angolini
2014-01-24 23:45 ` [meta-fsl-demos][PATCH 2/3] packagegroup-fsl: split packagegroup into multiple recipes ronunes
2014-01-25 19:21 ` Daiane Angolini
2014-01-25 20:23 ` Rogerio Nunes
2014-01-25 21:51 ` Otavio Salvador
2014-01-24 23:45 ` [meta-fsl-demos][PATCH 3/3] packagegroup-fsl-tools-testapps: Use amd-gpu-x11-bin-mx51 only with X11 ronunes
2014-01-25 18:48 ` Otavio Salvador
2014-01-25 18:49 ` Otavio Salvador
2014-01-25 18:57 ` Rogerio Nunes
2014-01-25 19:12 ` [meta-fsl-demos][PATCH 0/3] packagegroup refactoring Daiane Angolini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.