All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sujith Manoharan <sujith@msujith.org>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] [PATCH 1/3] ath9k: Fix build error on ARM
Date: Tue,  4 Feb 2014 08:37:52 +0530	[thread overview]
Message-ID: <1391483274-20331-2-git-send-email-sujith@msujith.org> (raw)
In-Reply-To: <1391483274-20331-1-git-send-email-sujith@msujith.org>

From: Sujith Manoharan <c_manoha@qca.qualcomm.com>

Use mdelay instead of udelay to fix this error:

ERROR: "__bad_udelay" [drivers/net/wireless/ath/ath9k/ath9k_hw.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

Reported-by: Josh Boyer <jwboyer@fedoraproject.org>
Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath9k/hw.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
index fbf43c0..11eab9f 100644
--- a/drivers/net/wireless/ath/ath9k/hw.c
+++ b/drivers/net/wireless/ath/ath9k/hw.c
@@ -1316,7 +1316,7 @@ static bool ath9k_hw_set_reset(struct ath_hw *ah, int type)
 	if (AR_SREV_9300_20_OR_LATER(ah))
 		udelay(50);
 	else if (AR_SREV_9100(ah))
-		udelay(10000);
+		mdelay(10);
 	else
 		udelay(100);
 
@@ -2051,9 +2051,8 @@ static bool ath9k_hw_set_power_awake(struct ath_hw *ah)
 
 	REG_SET_BIT(ah, AR_RTC_FORCE_WAKE,
 		    AR_RTC_FORCE_WAKE_EN);
-
 	if (AR_SREV_9100(ah))
-		udelay(10000);
+		mdelay(10);
 	else
 		udelay(50);
 
-- 
1.8.5.3

WARNING: multiple messages have this Message-ID (diff)
From: Sujith Manoharan <sujith@msujith.org>
To: John Linville <linville@tuxdriver.com>
Cc: linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org
Subject: [PATCH 1/3] ath9k: Fix build error on ARM
Date: Tue,  4 Feb 2014 08:37:52 +0530	[thread overview]
Message-ID: <1391483274-20331-2-git-send-email-sujith@msujith.org> (raw)
In-Reply-To: <1391483274-20331-1-git-send-email-sujith@msujith.org>

From: Sujith Manoharan <c_manoha@qca.qualcomm.com>

Use mdelay instead of udelay to fix this error:

ERROR: "__bad_udelay" [drivers/net/wireless/ath/ath9k/ath9k_hw.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

Reported-by: Josh Boyer <jwboyer@fedoraproject.org>
Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
---
 drivers/net/wireless/ath/ath9k/hw.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/hw.c b/drivers/net/wireless/ath/ath9k/hw.c
index fbf43c0..11eab9f 100644
--- a/drivers/net/wireless/ath/ath9k/hw.c
+++ b/drivers/net/wireless/ath/ath9k/hw.c
@@ -1316,7 +1316,7 @@ static bool ath9k_hw_set_reset(struct ath_hw *ah, int type)
 	if (AR_SREV_9300_20_OR_LATER(ah))
 		udelay(50);
 	else if (AR_SREV_9100(ah))
-		udelay(10000);
+		mdelay(10);
 	else
 		udelay(100);
 
@@ -2051,9 +2051,8 @@ static bool ath9k_hw_set_power_awake(struct ath_hw *ah)
 
 	REG_SET_BIT(ah, AR_RTC_FORCE_WAKE,
 		    AR_RTC_FORCE_WAKE_EN);
-
 	if (AR_SREV_9100(ah))
-		udelay(10000);
+		mdelay(10);
 	else
 		udelay(50);
 
-- 
1.8.5.3


  reply	other threads:[~2014-02-04  3:07 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-04  3:07 [ath9k-devel] [PATCH 0/3] ath9k patches Sujith Manoharan
2014-02-04  3:07 ` Sujith Manoharan
2014-02-04  3:07 ` Sujith Manoharan [this message]
2014-02-04  3:07   ` [PATCH 1/3] ath9k: Fix build error on ARM Sujith Manoharan
2014-02-04  3:34   ` [ath9k-devel] " Joe Perches
2014-02-04  3:34     ` Joe Perches
2014-02-04  3:40     ` [ath9k-devel] " Sujith Manoharan
2014-02-04  3:40       ` Sujith Manoharan
2014-02-04  7:03       ` [ath9k-devel] " Holger Schurig
2014-02-04  7:03         ` Holger Schurig
2014-02-04 12:59         ` [ath9k-devel] [PATCH] checkpatch: Add test for long udelay Joe Perches
2014-02-04 12:59           ` Joe Perches
2014-02-04 12:59           ` Joe Perches
2014-02-04 16:36         ` [ath9k-devel] [PATCH 1/3] ath9k: Fix build error on ARM Joe Perches
2014-02-04 16:36           ` Joe Perches
2014-02-04 16:36           ` Joe Perches
2014-02-04 18:40           ` Arnd Bergmann
2014-02-04 18:40             ` Arnd Bergmann
2014-02-04 18:40             ` Arnd Bergmann
2014-02-04 19:43             ` Joe Perches
2014-02-04 19:43               ` Joe Perches
2014-02-04 19:43               ` Joe Perches
2014-02-05 11:50           ` Russell King - ARM Linux
2014-02-05 11:50             ` Russell King - ARM Linux
2014-02-05 11:50             ` Russell King - ARM Linux
2014-02-05 12:32             ` Joe Perches
2014-02-05 12:32               ` Joe Perches
2014-02-05 12:32               ` Joe Perches
2014-02-05 12:41               ` Russell King - ARM Linux
2014-02-05 12:41                 ` Russell King - ARM Linux
2014-02-05 12:41                 ` Russell King - ARM Linux
2014-02-05 13:04                 ` Joe Perches
2014-02-05 13:04                   ` Joe Perches
2014-02-05 13:04                   ` Joe Perches
2014-02-05 13:39                   ` Russell King - ARM Linux
2014-02-05 13:39                     ` Russell King - ARM Linux
2014-02-05 13:39                     ` Russell King - ARM Linux
2014-02-05 14:03                     ` Joe Perches
2014-02-05 14:03                       ` Joe Perches
2014-02-05 14:03                       ` Joe Perches
2014-02-05 14:21                       ` Russell King - ARM Linux
2014-02-05 14:21                         ` Russell King - ARM Linux
2014-02-05 14:21                         ` Russell King - ARM Linux
2014-02-05 15:05                         ` Joe Perches
2014-02-05 15:05                           ` Joe Perches
2014-02-05 15:05                           ` Joe Perches
2014-02-04  3:07 ` [ath9k-devel] [PATCH 2/3] ath9k: Do not support PowerSave by default Sujith Manoharan
2014-02-04  3:07   ` Sujith Manoharan
2014-02-04  3:07 ` [ath9k-devel] [PATCH 3/3] ath9k: Fix TX power calculation Sujith Manoharan
2014-02-04  3:07   ` Sujith Manoharan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391483274-20331-2-git-send-email-sujith@msujith.org \
    --to=sujith@msujith.org \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.