From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: peterz@infradead.org, mingo@kernel.org
Cc: alex.shi@linaro.org, linux-kernel@vger.kernel.org,
linaro-kernel@lists.linaro.org
Subject: [PATCH V2 1/3] sched: Remove cpu parameter for idle_balance()
Date: Thu, 6 Feb 2014 23:10:35 +0000 [thread overview]
Message-ID: <1391728237-4441-2-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1391728237-4441-1-git-send-email-daniel.lezcano@linaro.org>
The cpu parameter passed to idle_balance is not needed as it could
be retrieved from the struct rq.
Cc: alex.shi@linaro.org
Cc: peterz@infradead.org
Cc: mingo@kernel.org
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
---
kernel/sched/core.c | 2 +-
kernel/sched/fair.c | 3 ++-
kernel/sched/sched.h | 4 ++--
3 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 210a12a..16b97dd 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -2705,7 +2705,7 @@ need_resched:
pre_schedule(rq, prev);
if (unlikely(!rq->nr_running))
- idle_balance(cpu, rq);
+ idle_balance(rq);
put_prev_task(rq, prev);
next = pick_next_task(rq);
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 4caa803..428bc9d 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -6531,12 +6531,13 @@ out:
* idle_balance is called by schedule() if this_cpu is about to become
* idle. Attempts to pull tasks from other CPUs.
*/
-void idle_balance(int this_cpu, struct rq *this_rq)
+void idle_balance(struct rq *this_rq)
{
struct sched_domain *sd;
int pulled_task = 0;
unsigned long next_balance = jiffies + HZ;
u64 curr_cost = 0;
+ int this_cpu = this_rq->cpu;
this_rq->idle_stamp = rq_clock(this_rq);
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index c2119fd..1436219 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -1176,14 +1176,14 @@ extern const struct sched_class idle_sched_class;
extern void update_group_power(struct sched_domain *sd, int cpu);
extern void trigger_load_balance(struct rq *rq);
-extern void idle_balance(int this_cpu, struct rq *this_rq);
+extern void idle_balance(struct rq *this_rq);
extern void idle_enter_fair(struct rq *this_rq);
extern void idle_exit_fair(struct rq *this_rq);
#else /* CONFIG_SMP */
-static inline void idle_balance(int cpu, struct rq *rq)
+static inline void idle_balance(struct rq *rq)
{
}
--
1.7.9.5
next prev parent reply other threads:[~2014-02-06 23:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 23:10 [PATCH V2 0/3] sched: idle_balance() cleanup and fix Daniel Lezcano
2014-02-06 23:10 ` Daniel Lezcano [this message]
2014-02-13 7:14 ` [PATCH V2 1/3] sched: Remove cpu parameter for idle_balance() Alex Shi
2014-02-06 23:10 ` [PATCH V2 2/3] sched: Fix race in idle_balance() Daniel Lezcano
2014-02-10 9:24 ` Preeti Murthy
2014-02-11 11:11 ` Daniel Lezcano
2014-02-13 7:45 ` Alex Shi
2014-02-13 10:10 ` Preeti U Murthy
2014-02-13 10:22 ` Daniel Lezcano
2014-02-13 7:46 ` Alex Shi
2014-02-06 23:10 ` [PATCH V2 3/3] sched: Move idle_stamp up to the core Daniel Lezcano
2014-02-10 10:04 ` Preeti Murthy
2014-02-11 12:07 ` Daniel Lezcano
2014-02-13 10:14 ` Preeti U Murthy
2014-02-13 7:53 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391728237-4441-2-git-send-email-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=alex.shi@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.