From: Alex Shi <alex.shi@linaro.org>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
Preeti Murthy <preeti.lkml@gmail.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: mingo@kernel.org, LKML <linux-kernel@vger.kernel.org>,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
Preeti U Murthy <preeti@linux.vnet.ibm.com>
Subject: Re: [PATCH V2 2/3] sched: Fix race in idle_balance()
Date: Thu, 13 Feb 2014 15:45:57 +0800 [thread overview]
Message-ID: <52FC7835.1090509@linaro.org> (raw)
In-Reply-To: <52FA0577.6080607@linaro.org>
On 02/11/2014 07:11 PM, Daniel Lezcano wrote:
> On 02/10/2014 10:24 AM, Preeti Murthy wrote:
>> HI Daniel,
>>
>> Isn't the only scenario where another cpu can put an idle task on
>> our runqueue,
>
> Well, I am not sure to understand what you meant, but I assume you are
> asking if it is possible to have a task to be pulled when we are idle,
> right ?
>
> This patch fixes the race when the current cpu is *about* to enter idle
> when calling schedule().
Preeti said the she didn't see a possible to insert a task on the cpu.
I also did a quick check, maybe task come from wakeup path?
--
Thanks
Alex
next prev parent reply other threads:[~2014-02-13 7:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 23:10 [PATCH V2 0/3] sched: idle_balance() cleanup and fix Daniel Lezcano
2014-02-06 23:10 ` [PATCH V2 1/3] sched: Remove cpu parameter for idle_balance() Daniel Lezcano
2014-02-13 7:14 ` Alex Shi
2014-02-06 23:10 ` [PATCH V2 2/3] sched: Fix race in idle_balance() Daniel Lezcano
2014-02-10 9:24 ` Preeti Murthy
2014-02-11 11:11 ` Daniel Lezcano
2014-02-13 7:45 ` Alex Shi [this message]
2014-02-13 10:10 ` Preeti U Murthy
2014-02-13 10:22 ` Daniel Lezcano
2014-02-13 7:46 ` Alex Shi
2014-02-06 23:10 ` [PATCH V2 3/3] sched: Move idle_stamp up to the core Daniel Lezcano
2014-02-10 10:04 ` Preeti Murthy
2014-02-11 12:07 ` Daniel Lezcano
2014-02-13 10:14 ` Preeti U Murthy
2014-02-13 7:53 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52FC7835.1090509@linaro.org \
--to=alex.shi@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=preeti.lkml@gmail.com \
--cc=preeti@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.