All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Genoud <richard.genoud@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Nicolas Ferre" <nicolas.ferre@atmel.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	linux-serial@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	"Richard Genoud" <richard.genoud@gmail.com>
Subject: [PATCH 1/8] tty/serial: at91: use dev_err instead of printk
Date: Fri,  7 Feb 2014 15:59:08 +0100	[thread overview]
Message-ID: <1391785155-18525-2-git-send-email-richard.genoud@gmail.com> (raw)
In-Reply-To: <1391785155-18525-1-git-send-email-richard.genoud@gmail.com>

For better consistency.

Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
---
 drivers/tty/serial/atmel_serial.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index 91c0d8839570..ed9621a21d67 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -1549,7 +1549,7 @@ static int atmel_startup(struct uart_port *port)
 	retval = request_irq(port->irq, atmel_interrupt, IRQF_SHARED,
 			tty ? tty->name : "atmel_serial", port);
 	if (retval) {
-		printk("atmel_serial: atmel_startup - Can't get irq\n");
+		dev_err(port->dev, "atmel_startup - Can't get irq\n");
 		return retval;
 	}
 
@@ -1732,7 +1732,7 @@ static void atmel_serial_pm(struct uart_port *port, unsigned int state,
 		clk_disable_unprepare(atmel_port->clk);
 		break;
 	default:
-		printk(KERN_ERR "atmel_serial: unknown pm %d\n", state);
+		dev_err(port->dev, "atmel_serial: unknown pm %d\n", state);
 	}
 }
 
-- 
1.8.5


WARNING: multiple messages have this Message-ID (diff)
From: richard.genoud@gmail.com (Richard Genoud)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/8] tty/serial: at91: use dev_err instead of printk
Date: Fri,  7 Feb 2014 15:59:08 +0100	[thread overview]
Message-ID: <1391785155-18525-2-git-send-email-richard.genoud@gmail.com> (raw)
In-Reply-To: <1391785155-18525-1-git-send-email-richard.genoud@gmail.com>

For better consistency.

Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
---
 drivers/tty/serial/atmel_serial.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
index 91c0d8839570..ed9621a21d67 100644
--- a/drivers/tty/serial/atmel_serial.c
+++ b/drivers/tty/serial/atmel_serial.c
@@ -1549,7 +1549,7 @@ static int atmel_startup(struct uart_port *port)
 	retval = request_irq(port->irq, atmel_interrupt, IRQF_SHARED,
 			tty ? tty->name : "atmel_serial", port);
 	if (retval) {
-		printk("atmel_serial: atmel_startup - Can't get irq\n");
+		dev_err(port->dev, "atmel_startup - Can't get irq\n");
 		return retval;
 	}
 
@@ -1732,7 +1732,7 @@ static void atmel_serial_pm(struct uart_port *port, unsigned int state,
 		clk_disable_unprepare(atmel_port->clk);
 		break;
 	default:
-		printk(KERN_ERR "atmel_serial: unknown pm %d\n", state);
+		dev_err(port->dev, "atmel_serial: unknown pm %d\n", state);
 	}
 }
 
-- 
1.8.5

  reply	other threads:[~2014-02-07 15:00 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07 14:59 [PATCH 0/8] tty/serial: at91: Add missing modem signals to atmel_serial Richard Genoud
2014-02-07 14:59 ` Richard Genoud
2014-02-07 14:59 ` Richard Genoud [this message]
2014-02-07 14:59   ` [PATCH 1/8] tty/serial: at91: use dev_err instead of printk Richard Genoud
2014-02-07 14:59 ` [PATCH 2/8] tty/serial: at91: remove unused open/close hooks Richard Genoud
2014-02-07 14:59   ` Richard Genoud
2014-02-07 14:59 ` [PATCH 3/8] tty/serial: at91: prepare for more gpio lines to come Richard Genoud
2014-02-07 14:59   ` Richard Genoud
2014-02-07 14:59 ` [PATCH 4/8] tty/serial: at91: add cts control via gpio Richard Genoud
2014-02-07 14:59   ` Richard Genoud
2014-02-07 14:59 ` [PATCH 5/8] tty/serial: at91: add dtr " Richard Genoud
2014-02-07 14:59   ` Richard Genoud
2014-02-07 15:21   ` Alexander Shiyan
2014-02-07 15:21     ` Alexander Shiyan
2014-02-10 10:24     ` Richard Genoud
2014-02-10 10:24       ` Richard Genoud
2014-02-10 10:37       ` Nicolas Ferre
2014-02-10 10:37         ` Nicolas Ferre
2014-02-07 14:59 ` [PATCH 6/8] tty/serial: at91: add dsr " Richard Genoud
2014-02-07 14:59   ` Richard Genoud
2014-02-07 14:59 ` [PATCH 7/8] tty/serial: at91: add ring " Richard Genoud
2014-02-07 14:59   ` Richard Genoud
2014-02-07 14:59 ` [PATCH 8/8] tty/serial: at91: add dcd " Richard Genoud
2014-02-07 14:59   ` Richard Genoud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1391785155-18525-2-git-send-email-richard.genoud@gmail.com \
    --to=richard.genoud@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.