From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, lersek@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH 1/3] block: Fix memory leaks in bdrv_co_do_pwritev()
Date: Fri, 7 Feb 2014 17:12:56 +0100 [thread overview]
Message-ID: <1391789578-19601-2-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1391789578-19601-1-git-send-email-kwolf@redhat.com>
The error path for a failure in one of the two bdrv_aligned_preadv()
calls leaked head_buf or tail_buf, respectively. This fixes the memory
leak.
Reported-by: Laszlo Ersek <lersek@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block.c b/block.c
index ac0ccac..c1d1f74 100644
--- a/block.c
+++ b/block.c
@@ -3279,9 +3279,9 @@ fail:
if (use_local_qiov) {
qemu_iovec_destroy(&local_qiov);
- qemu_vfree(head_buf);
- qemu_vfree(tail_buf);
}
+ qemu_vfree(head_buf);
+ qemu_vfree(tail_buf);
return ret;
}
--
1.8.1.4
next prev parent reply other threads:[~2014-02-07 16:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 16:12 [Qemu-devel] [PATCH 0/3] 512-on-4k follow-up patches Kevin Wolf
2014-02-07 16:12 ` Kevin Wolf [this message]
2014-02-07 16:12 ` [Qemu-devel] [PATCH 2/3] block: bdrv_aligned_pwritev: Assert overlap range Kevin Wolf
2014-02-07 16:12 ` [Qemu-devel] [PATCH 3/3] block: Don't call ROUND_UP with negative values Kevin Wolf
2014-02-07 16:27 ` Eric Blake
2014-02-07 21:45 ` Kevin Wolf
2014-02-07 23:24 ` Laszlo Ersek
2014-02-08 8:17 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391789578-19601-2-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.