All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH 3/3] block: Don't call ROUND_UP with negative values
Date: Sat, 08 Feb 2014 00:24:24 +0100	[thread overview]
Message-ID: <52F56B28.3030600@redhat.com> (raw)
In-Reply-To: <20140207214537.GA3099@dhcp-200-207.str.redhat.com>

On 02/07/14 22:45, Kevin Wolf wrote:
> Am 07.02.2014 um 17:27 hat Eric Blake geschrieben:
>> On 02/07/2014 09:12 AM, Kevin Wolf wrote:
>>> The behaviour of the ROUND_UP macro with negative numbers isn't obvious.
>>> It happens to do the right thing in this please, but better avoid it.
>>
>> s/please/place/
> 
> Indeed... Thanks, fixed it locally.
> 
>>> Suggested-by: Laszlo Ersek <lersek@redhat.com>
>>> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
>>> ---
>>>  block.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Series: Reviewed-by: Eric Blake <eblake@redhat.com>

Not necessary after Eric's review, but here it is anyway:

series
Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Laszlo

  reply	other threads:[~2014-02-07 23:24 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-07 16:12 [Qemu-devel] [PATCH 0/3] 512-on-4k follow-up patches Kevin Wolf
2014-02-07 16:12 ` [Qemu-devel] [PATCH 1/3] block: Fix memory leaks in bdrv_co_do_pwritev() Kevin Wolf
2014-02-07 16:12 ` [Qemu-devel] [PATCH 2/3] block: bdrv_aligned_pwritev: Assert overlap range Kevin Wolf
2014-02-07 16:12 ` [Qemu-devel] [PATCH 3/3] block: Don't call ROUND_UP with negative values Kevin Wolf
2014-02-07 16:27   ` Eric Blake
2014-02-07 21:45     ` Kevin Wolf
2014-02-07 23:24       ` Laszlo Ersek [this message]
2014-02-08  8:17         ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52F56B28.3030600@redhat.com \
    --to=lersek@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.