All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/6] reset: sunxi: Add Allwinner H3 bus resets
Date: Fri, 30 Oct 2015 09:27:03 +0100	[thread overview]
Message-ID: <13919923.o3Dj9msmoa@wuerfel> (raw)
In-Reply-To: <1445964626-6484-5-git-send-email-jenskuske@gmail.com>

On Tuesday 27 October 2015 17:50:24 Jens Kuske wrote:
> 
> +static int sun8i_h3_bus_reset_xlate(struct reset_controller_dev *rcdev,
> +                                   const struct of_phandle_args *reset_spec)
> +{
> +       unsigned int index = reset_spec->args[0];
> +
> +       if (index < 96)
> +               return index;
> +       else if (index < 128)
> +               return index + 32;
> +       else if (index < 160)
> +               return index + 64;
> +       else
> +               return -EINVAL;
> +}
> +
> 

This looks like you are doing something wrong and should either
put the actual number into DT, or use a two-cell representation,
with the first cell indicating the block (0, 1 or 2), and the
second cell the index.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: "Jens Kuske" <jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	"Maxime Ripard"
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	"Chen-Yu Tsai" <wens-jdAy2FN1RRM@public.gmane.org>,
	"Michael Turquette"
	<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
	"Linus Walleij"
	<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	"Rob Herring" <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Philipp Zabel" <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
	"Emilio López" <emilio-0Z03zUJReD5OxF6Tv1QG9Q@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Vishnu Patekar"
	<vishnupatekar0510-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Hans de Goede"
	<hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v4 4/6] reset: sunxi: Add Allwinner H3 bus resets
Date: Fri, 30 Oct 2015 09:27:03 +0100	[thread overview]
Message-ID: <13919923.o3Dj9msmoa@wuerfel> (raw)
In-Reply-To: <1445964626-6484-5-git-send-email-jenskuske-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

On Tuesday 27 October 2015 17:50:24 Jens Kuske wrote:
> 
> +static int sun8i_h3_bus_reset_xlate(struct reset_controller_dev *rcdev,
> +                                   const struct of_phandle_args *reset_spec)
> +{
> +       unsigned int index = reset_spec->args[0];
> +
> +       if (index < 96)
> +               return index;
> +       else if (index < 128)
> +               return index + 32;
> +       else if (index < 160)
> +               return index + 64;
> +       else
> +               return -EINVAL;
> +}
> +
> 

This looks like you are doing something wrong and should either
put the actual number into DT, or use a two-cell representation,
with the first cell indicating the block (0, 1 or 2), and the
second cell the index.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: "Jens Kuske" <jenskuske@gmail.com>,
	"Maxime Ripard" <maxime.ripard@free-electrons.com>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Michael Turquette" <mturquette@baylibre.com>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Emilio López" <emilio@elopez.com.ar>,
	devicetree@vger.kernel.org,
	"Vishnu Patekar" <vishnupatekar0510@gmail.com>,
	linux-kernel@vger.kernel.org,
	"Hans de Goede" <hdegoede@redhat.com>,
	linux-sunxi@googlegroups.com
Subject: Re: [PATCH v4 4/6] reset: sunxi: Add Allwinner H3 bus resets
Date: Fri, 30 Oct 2015 09:27:03 +0100	[thread overview]
Message-ID: <13919923.o3Dj9msmoa@wuerfel> (raw)
In-Reply-To: <1445964626-6484-5-git-send-email-jenskuske@gmail.com>

On Tuesday 27 October 2015 17:50:24 Jens Kuske wrote:
> 
> +static int sun8i_h3_bus_reset_xlate(struct reset_controller_dev *rcdev,
> +                                   const struct of_phandle_args *reset_spec)
> +{
> +       unsigned int index = reset_spec->args[0];
> +
> +       if (index < 96)
> +               return index;
> +       else if (index < 128)
> +               return index + 32;
> +       else if (index < 160)
> +               return index + 64;
> +       else
> +               return -EINVAL;
> +}
> +
> 

This looks like you are doing something wrong and should either
put the actual number into DT, or use a two-cell representation,
with the first cell indicating the block (0, 1 or 2), and the
second cell the index.

	Arnd

  parent reply	other threads:[~2015-10-30  8:27 UTC|newest]

Thread overview: 113+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-27 16:50 [PATCH v4 0/6] ARM: sunxi: Introduce Allwinner H3 support Jens Kuske
2015-10-27 16:50 ` Jens Kuske
2015-10-27 16:50 ` Jens Kuske
2015-10-27 16:50 ` [PATCH v4 1/6] clk: sunxi: Let divs clocks read the base factor clock name from devicetree Jens Kuske
2015-10-27 16:50   ` Jens Kuske
2015-10-27 16:50   ` Jens Kuske
2015-10-30  7:46   ` Chen-Yu Tsai
2015-10-30  7:46     ` Chen-Yu Tsai
2015-10-30  7:46     ` Chen-Yu Tsai
2015-11-01 13:11     ` Jens Kuske
2015-11-01 13:11       ` Jens Kuske
2015-11-01 13:11       ` Jens Kuske
2015-11-04 15:44   ` [PATCH] clk: sunxi: Refactor A31 PLL6 so that it can be reused Maxime Ripard
2015-11-04 15:44     ` Maxime Ripard
2015-11-05  2:28     ` Chen-Yu Tsai
2015-11-05  2:28       ` Chen-Yu Tsai
2015-11-09  1:52       ` Maxime Ripard
2015-11-09  1:52         ` Maxime Ripard
2015-10-27 16:50 ` [PATCH v4 2/6] clk: sunxi: Add H3 clocks support Jens Kuske
2015-10-27 16:50   ` Jens Kuske
2015-10-27 16:50   ` Jens Kuske
2015-10-27 23:12   ` [linux-sunxi] " Julian Calaby
2015-10-27 23:12     ` Julian Calaby
2015-10-27 23:12     ` Julian Calaby
2015-11-04 16:23     ` [linux-sunxi] " Maxime Ripard
2015-11-04 16:23       ` Maxime Ripard
2015-11-04 16:23       ` Maxime Ripard
2015-11-04 22:17       ` [linux-sunxi] " Julian Calaby
2015-11-04 22:17         ` Julian Calaby
2015-11-04 22:17         ` Julian Calaby
2015-10-30  8:28   ` Arnd Bergmann
2015-10-30  8:28     ` Arnd Bergmann
2015-10-30  8:28     ` Arnd Bergmann
2015-11-01 13:40     ` Jens Kuske
2015-11-01 13:40       ` Jens Kuske
2015-11-01 13:40       ` Jens Kuske
2015-11-04 16:24     ` Maxime Ripard
2015-11-04 16:24       ` Maxime Ripard
2015-11-04 16:24       ` Maxime Ripard
2015-10-27 16:50 ` [PATCH v4 3/6] pinctrl: sunxi: Add H3 PIO controller support Jens Kuske
2015-10-27 16:50   ` Jens Kuske
2015-10-27 16:50   ` Jens Kuske
2015-10-30  8:08   ` Chen-Yu Tsai
2015-10-30  8:08     ` Chen-Yu Tsai
2015-10-30  8:08     ` Chen-Yu Tsai
2015-11-01 13:17     ` Jens Kuske
2015-11-01 13:17       ` Jens Kuske
2015-11-01 13:17       ` Jens Kuske
2015-11-01 15:25       ` [linux-sunxi] " Chen-Yu Tsai
2015-11-01 15:25         ` Chen-Yu Tsai
2015-11-01 15:25         ` Chen-Yu Tsai
2015-10-27 16:50 ` [PATCH v4 4/6] reset: sunxi: Add Allwinner H3 bus resets Jens Kuske
2015-10-27 16:50   ` Jens Kuske
2015-10-27 16:50   ` Jens Kuske
2015-10-28 11:42   ` Philipp Zabel
2015-10-28 11:42     ` Philipp Zabel
2015-10-28 11:42     ` Philipp Zabel
2015-10-30  8:27   ` Arnd Bergmann [this message]
2015-10-30  8:27     ` Arnd Bergmann
2015-10-30  8:27     ` Arnd Bergmann
2015-11-01 13:21     ` Jens Kuske
2015-11-01 13:21       ` Jens Kuske
2015-11-01 13:21       ` Jens Kuske
2015-11-04 16:30     ` Maxime Ripard
2015-11-04 16:30       ` Maxime Ripard
2015-11-04 16:30       ` Maxime Ripard
2015-11-05  6:47       ` Jean-Francois Moine
2015-11-05  6:47         ` Jean-Francois Moine
2015-11-05  6:47         ` Jean-Francois Moine
2015-11-23  7:41         ` [linux-sunxi] " Chen-Yu Tsai
2015-11-23  7:41           ` Chen-Yu Tsai
2015-11-23  7:41           ` Chen-Yu Tsai
2015-11-23 11:29           ` [linux-sunxi] " Maxime Ripard
2015-11-23 11:29             ` Maxime Ripard
2015-11-23 11:29             ` Maxime Ripard
2015-10-27 16:50 ` [PATCH v4 5/6] ARM: dts: sunxi: Add Allwinner H3 DTSI Jens Kuske
2015-10-27 16:50   ` Jens Kuske
2015-10-27 16:50   ` Jens Kuske
2015-10-30  7:33   ` Chen-Yu Tsai
2015-10-30  7:33     ` Chen-Yu Tsai
2015-10-30  7:33     ` Chen-Yu Tsai
2015-11-01  9:46     ` Maxime Ripard
2015-11-01  9:46       ` Maxime Ripard
2015-11-01 13:33     ` Jens Kuske
2015-11-01 13:33       ` Jens Kuske
2015-11-01 13:33       ` Jens Kuske
2015-11-23  8:57       ` Maxime Ripard
2015-11-23  8:57         ` Maxime Ripard
2015-11-23  8:57         ` Maxime Ripard
2015-11-23 10:50         ` [linux-sunxi] " Hans de Goede
2015-11-23 10:50           ` Hans de Goede
2015-11-23 10:50           ` Hans de Goede
2015-11-23 16:25           ` [linux-sunxi] " Jens Kuske
2015-11-23 16:25             ` Jens Kuske
2015-11-23 16:25             ` Jens Kuske
2015-11-23 16:48           ` [linux-sunxi] " Chen-Yu Tsai
2015-11-23 16:48             ` Chen-Yu Tsai
2015-11-23 16:48             ` Chen-Yu Tsai
2015-10-30 10:34   ` Jean-Francois Moine
2015-10-30 10:34     ` Jean-Francois Moine
2015-10-30 10:34     ` Jean-Francois Moine
2015-11-01  9:48   ` Maxime Ripard
2015-11-01  9:48     ` Maxime Ripard
2015-11-01  9:48     ` Maxime Ripard
2015-11-01  9:52   ` Maxime Ripard
2015-11-01  9:52     ` Maxime Ripard
2015-11-01  9:52     ` Maxime Ripard
2015-10-27 16:50 ` [PATCH v4 6/6] ARM: dts: sun8i: Add Orange Pi Plus support Jens Kuske
2015-10-27 16:50   ` Jens Kuske
2015-10-27 16:50   ` Jens Kuske
2015-10-27 18:04 ` [PATCH v4 0/6] ARM: sunxi: Introduce Allwinner H3 support Jean-Francois Moine
2015-10-27 18:04   ` Jean-Francois Moine
2015-10-27 18:04   ` Jean-Francois Moine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13919923.o3Dj9msmoa@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.