[PATCH 1/2] usb: host: remove USB_ARCH_HAS_?HCI

[PATCH 1/2] usb: host: remove USB_ARCH_HAS_?HCI

[Paul Bolle]

USB_ARCH_HAS_EHCI, USB_ARCH_HAS_OHCI, and USB_ARCH_HAS_XHCI were made
obsolete in v3.11. They have not been used ever since. Setting them has
no effect. They can safely be removed.

Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Tested with "git grep".

Note that the comment in this Kconfig file (that is also removed)
suggests to first remove the select statements for these symbols and
then the symbols themselves. But I think it makes more sense to first
delete these three symbols and then remove the selects statements (as
that is removing a second order effect). But it could just as well be
done with just one patch, I'd say.

 drivers/usb/Kconfig | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
index 2e6b832..e0cad44 100644
--- a/drivers/usb/Kconfig
+++ b/drivers/usb/Kconfig
@@ -2,10 +2,6 @@
 # USB device configuration
 #
 
-# These are unused now, remove them once they are no longer selected
-config USB_ARCH_HAS_OHCI
-	bool
-
 config USB_OHCI_BIG_ENDIAN_DESC
 	bool
 
@@ -17,18 +13,12 @@ config USB_OHCI_LITTLE_ENDIAN
 	default n if STB03xxx || PPC_MPC52xx
 	default y
 
-config USB_ARCH_HAS_EHCI
-	bool
-
 config USB_EHCI_BIG_ENDIAN_MMIO
 	bool
 
 config USB_EHCI_BIG_ENDIAN_DESC
 	bool
 
-config USB_ARCH_HAS_XHCI
-	bool
-
 menuconfig USB_SUPPORT
 	bool "USB support"
 	depends on HAS_IOMEM
-- 
1.8.5.3

Re: [PATCH 1/2] usb: host: remove USB_ARCH_HAS_?HCI

[Alan Stern]

On Sun, 16 Feb 2014, Paul Bolle wrote:

> USB_ARCH_HAS_EHCI, USB_ARCH_HAS_OHCI, and USB_ARCH_HAS_XHCI were made
> obsolete in v3.11. They have not been used ever since. Setting them has
> no effect. They can safely be removed.
> 
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Tested with "git grep".
> 
> Note that the comment in this Kconfig file (that is also removed)
> suggests to first remove the select statements for these symbols and
> then the symbols themselves. But I think it makes more sense to first
> delete these three symbols and then remove the selects statements (as
> that is removing a second order effect). But it could just as well be
> done with just one patch, I'd say.

There's a simple reason for not getting rid of the symbols first.  
Doing it that way, as you did, leaves a window in which it's possible
to select a non-existent symbol.  If that's not an error, it ought to
be.

Regardless, for both patches:

Acked-by: Alan Stern <stern@rowland.harvard.edu>

Alan Stern

Re: [PATCH 1/2] usb: host: remove USB_ARCH_HAS_?HCI

[Paul Bolle]

On Sun, 2014-02-16 at 15:02 -0500, Alan Stern wrote:
> On Sun, 16 Feb 2014, Paul Bolle wrote:
> > Note that the comment in this Kconfig file (that is also removed)
> > suggests to first remove the select statements for these symbols and
> > then the symbols themselves. But I think it makes more sense to first
> > delete these three symbols and then remove the selects statements (as
> > that is removing a second order effect). But it could just as well be
> > done with just one patch, I'd say.
> 
> There's a simple reason for not getting rid of the symbols first.  
> Doing it that way, as you did, leaves a window in which it's possible
> to select a non-existent symbol.  If that's not an error, it ought to
> be.

It is silently ignored. I've contemplated diving in the kconfig code to
see whether doing that could be made to trigger an error or, perhaps
better, a warning. I've not made up my mind yet.

It's trivial to merge these two patches, though. So feel free to ask me
to do that.

> Regardless, for both patches:
> 
> Acked-by: Alan Stern <stern@rowland.harvard.edu>

Thanks.


Paul Bolle