From: Paul Bolle <pebolle@tiscali.nl>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Nicholas A. Bellinger" <nab@linux-iscsi.org>,
scsi <linux-scsi@vger.kernel.org>,
target-devel <target-devel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] target_core_alua: silence GCC warning
Date: Wed, 19 Feb 2014 11:05:47 +0100 [thread overview]
Message-ID: <1392804347.27558.20.camel@x220> (raw)
In-Reply-To: <CAMuHMdXZrw7oU=n60+PNNQftU6Su=mBf2V75TCO8Ws1pS5z+6Q@mail.gmail.com>
On Wed, 2014-02-19 at 10:59 +0100, Geert Uytterhoeven wrote:
> On Wed, Feb 19, 2014 at 10:52 AM, Paul Bolle <pebolle@tiscali.nl> wrote:
> > - ret = core_alua_state_nonoptimized(cmd, cdb,
> > - nonop_delay_msecs, &alua_ascq);
> > + core_alua_state_nonoptimized(cmd, cdb, nonop_delay_msecs);
>
> I suggest making core_alua_state_nonoptimized() return void, too.
> Currently it always returns zero.
Good catch. Not sure how I missed that, since I deliberately ignore its
return value here.
I'll wait with sending a v2 until after Nicholas or the other target
developers have given their feedback.
Paul Bolle
next prev parent reply other threads:[~2014-02-19 10:05 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 9:02 Build regressions/improvements in v3.14-rc3 Geert Uytterhoeven
2014-02-18 9:06 ` Geert Uytterhoeven
2014-02-18 9:06 ` Geert Uytterhoeven
2014-02-19 9:52 ` [PATCH] target_core_alua: silence GCC warning Paul Bolle
2014-02-19 9:59 ` Geert Uytterhoeven
2014-02-19 10:05 ` Paul Bolle [this message]
2014-02-19 22:59 ` Nicholas A. Bellinger
2014-02-20 8:07 ` [PATCH v2] " Paul Bolle
2014-02-20 18:33 ` Nicholas A. Bellinger
2014-02-20 22:11 ` [PATCH] NVMe: silence GCC warning on 32 bit Paul Bolle
2014-02-20 22:11 ` Paul Bolle
2014-02-21 16:37 ` Keith Busch
2014-02-21 16:37 ` Keith Busch
2014-03-04 9:36 ` [PATCH v2] " Paul Bolle
2014-03-04 9:36 ` Paul Bolle
2014-03-05 15:09 ` Keith Busch
2014-03-05 15:09 ` Keith Busch
2014-03-06 9:56 ` Paul Bolle
2014-03-06 9:56 ` Paul Bolle
2014-03-24 13:11 ` Matthew Wilcox
2014-03-24 13:11 ` Matthew Wilcox
2014-03-24 13:31 ` Matthew Wilcox
2014-03-24 13:31 ` Matthew Wilcox
2014-03-24 15:36 ` Paul Bolle
2014-03-24 15:36 ` Paul Bolle
2014-03-24 15:49 ` Geert Uytterhoeven
2014-03-24 15:49 ` Geert Uytterhoeven
2014-03-24 15:57 ` Paul Bolle
2014-03-24 15:57 ` Paul Bolle
2014-05-08 7:12 ` Paul Bolle
2014-05-08 7:12 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1392804347.27558.20.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.