From: pebolle@tiscali.nl (Paul Bolle)
Subject: [PATCH v2] NVMe: silence GCC warning on 32 bit
Date: Mon, 24 Mar 2014 16:57:46 +0100 [thread overview]
Message-ID: <1395676666.6440.19.camel@x220> (raw)
In-Reply-To: <CAMuHMdVMq30_XFLNzwjj6kXWVvasa8Ewog0MmOd1PNDQDuybqA@mail.gmail.com>
On Mon, 2014-03-24@16:49 +0100, Geert Uytterhoeven wrote:
> On Mon, Mar 24, 2014@4:36 PM, Paul Bolle <pebolle@tiscali.nl> wrote:
> > And as this is now unlikely to be in time for v3.14, we might decide to
> > dig deeper. It won't be the first time that a rather small change (say,
> > converting a variable from signed to unsigned) turns out be enough to
> > make GCC understand the flow of the code.
>
> Anything we can do with factoring out the "if (!first)" in both branches?
That was basically my approach in version one: drop "first" all
together. Worked great: the warning was gone. But Keith noted that I
also completely broke the logic of the code. So I decided, after some
further attempts, to take the easy way out and and initialize "bvprv" to
{ NULL }.
Paul Bolle
WARNING: multiple messages have this Message-ID (diff)
From: Paul Bolle <pebolle@tiscali.nl>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Matthew Wilcox <willy@linux.intel.com>,
Keith Busch <keith.busch@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH v2] NVMe: silence GCC warning on 32 bit
Date: Mon, 24 Mar 2014 16:57:46 +0100 [thread overview]
Message-ID: <1395676666.6440.19.camel@x220> (raw)
In-Reply-To: <CAMuHMdVMq30_XFLNzwjj6kXWVvasa8Ewog0MmOd1PNDQDuybqA@mail.gmail.com>
On Mon, 2014-03-24 at 16:49 +0100, Geert Uytterhoeven wrote:
> On Mon, Mar 24, 2014 at 4:36 PM, Paul Bolle <pebolle@tiscali.nl> wrote:
> > And as this is now unlikely to be in time for v3.14, we might decide to
> > dig deeper. It won't be the first time that a rather small change (say,
> > converting a variable from signed to unsigned) turns out be enough to
> > make GCC understand the flow of the code.
>
> Anything we can do with factoring out the "if (!first)" in both branches?
That was basically my approach in version one: drop "first" all
together. Worked great: the warning was gone. But Keith noted that I
also completely broke the logic of the code. So I decided, after some
further attempts, to take the easy way out and and initialize "bvprv" to
{ NULL }.
Paul Bolle
next prev parent reply other threads:[~2014-03-24 15:57 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 9:02 Build regressions/improvements in v3.14-rc3 Geert Uytterhoeven
2014-02-18 9:06 ` Geert Uytterhoeven
2014-02-18 9:06 ` Geert Uytterhoeven
2014-02-19 9:52 ` [PATCH] target_core_alua: silence GCC warning Paul Bolle
2014-02-19 9:59 ` Geert Uytterhoeven
2014-02-19 10:05 ` Paul Bolle
2014-02-19 22:59 ` Nicholas A. Bellinger
2014-02-20 8:07 ` [PATCH v2] " Paul Bolle
2014-02-20 18:33 ` Nicholas A. Bellinger
2014-02-20 22:11 ` [PATCH] NVMe: silence GCC warning on 32 bit Paul Bolle
2014-02-20 22:11 ` Paul Bolle
2014-02-21 16:37 ` Keith Busch
2014-02-21 16:37 ` Keith Busch
2014-03-04 9:36 ` [PATCH v2] " Paul Bolle
2014-03-04 9:36 ` Paul Bolle
2014-03-05 15:09 ` Keith Busch
2014-03-05 15:09 ` Keith Busch
2014-03-06 9:56 ` Paul Bolle
2014-03-06 9:56 ` Paul Bolle
2014-03-24 13:11 ` Matthew Wilcox
2014-03-24 13:11 ` Matthew Wilcox
2014-03-24 13:31 ` Matthew Wilcox
2014-03-24 13:31 ` Matthew Wilcox
2014-03-24 15:36 ` Paul Bolle
2014-03-24 15:36 ` Paul Bolle
2014-03-24 15:49 ` Geert Uytterhoeven
2014-03-24 15:49 ` Geert Uytterhoeven
2014-03-24 15:57 ` Paul Bolle [this message]
2014-03-24 15:57 ` Paul Bolle
2014-05-08 7:12 ` Paul Bolle
2014-05-08 7:12 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1395676666.6440.19.camel@x220 \
--to=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.