From: Christoph Fritz <chf.fritz@googlemail.com>
To: Tero Kristo <t-kristo@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
bcousson@baylibre.com, Tomi Valkeinen <tomi.valkeinen@ti.com>,
Nishanth Menon <nm@ti.com>,
Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
Daniel Mack <zonque@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH v4 4/4] ARM: OMAP2+: Add pdata quirk for sys_clkout2 for omap3 DBB056
Date: Wed, 05 Mar 2014 14:25:32 +0100 [thread overview]
Message-ID: <1394025932.16566.44.camel@mars> (raw)
In-Reply-To: <53172175.5060603@ti.com>
On Wed, 2014-03-05 at 15:07 +0200, Tero Kristo wrote:
> On 03/01/2014 12:37 AM, Tony Lindgren wrote:
> > * Christoph Fritz <chf.fritz@googlemail.com> [140214 06:24]:
> >> Full device tree support for clock control, especially to set frequencies,
> >> is not yet accomplished. Until then, configure the 24Mhz of sys_clkout2 to
> >> feed an USB-Hub here.
> >
> > Hmm would like to see Tero's comments on this, I wonder if we should
> > wait on this to avoid extra churn?
>
> Well, the set I posted that adds default clock parenting / default rate
> support to DT hasn't actually moved forward, so you might want to take
> this in as is now if it should be rushed. The clk-enable part isn't done
> currently by anything anyway. Just wondering though, should you create
> some sort of driver for your usb-hub which would control these clocks?
The USB-Hub, a USB2512 is wired as non-configurable. Its pin
'XTAL1/CLKIN' can be connected to either a crystal or an external clock
input. To economise the crystal, the clock-out of the omap is wired
here.
So in my view, a driver is unnecessary.
Thanks
-- Christoph
WARNING: multiple messages have this Message-ID (diff)
From: chf.fritz@googlemail.com (Christoph Fritz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 4/4] ARM: OMAP2+: Add pdata quirk for sys_clkout2 for omap3 DBB056
Date: Wed, 05 Mar 2014 14:25:32 +0100 [thread overview]
Message-ID: <1394025932.16566.44.camel@mars> (raw)
In-Reply-To: <53172175.5060603@ti.com>
On Wed, 2014-03-05 at 15:07 +0200, Tero Kristo wrote:
> On 03/01/2014 12:37 AM, Tony Lindgren wrote:
> > * Christoph Fritz <chf.fritz@googlemail.com> [140214 06:24]:
> >> Full device tree support for clock control, especially to set frequencies,
> >> is not yet accomplished. Until then, configure the 24Mhz of sys_clkout2 to
> >> feed an USB-Hub here.
> >
> > Hmm would like to see Tero's comments on this, I wonder if we should
> > wait on this to avoid extra churn?
>
> Well, the set I posted that adds default clock parenting / default rate
> support to DT hasn't actually moved forward, so you might want to take
> this in as is now if it should be rushed. The clk-enable part isn't done
> currently by anything anyway. Just wondering though, should you create
> some sort of driver for your usb-hub which would control these clocks?
The USB-Hub, a USB2512 is wired as non-configurable. Its pin
'XTAL1/CLKIN' can be connected to either a crystal or an external clock
input. To economise the crystal, the clock-out of the omap is wired
here.
So in my view, a driver is unnecessary.
Thanks
-- Christoph
next prev parent reply other threads:[~2014-03-05 13:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 14:20 [PATCH v4 0/4] Christoph Fritz
2014-02-14 14:20 ` Christoph Fritz
2014-02-14 14:20 ` [PATCH v4 1/4] ARM: dts: omap3: Add support for INCOstartec a83x module Christoph Fritz
2014-02-14 14:20 ` Christoph Fritz
2014-02-14 14:20 ` [PATCH v4 2/4] ARM: dts: omap3: Add support for INCOstartec DBB056 baseboard Christoph Fritz
2014-02-14 14:20 ` Christoph Fritz
2014-02-14 14:20 ` [PATCH v4 3/4] ARM: OMAP2+: add legacy display for omap3 DBB056 Christoph Fritz
2014-02-14 14:20 ` Christoph Fritz
2014-02-14 14:35 ` Tomi Valkeinen
2014-02-14 14:35 ` Tomi Valkeinen
2014-02-28 22:38 ` Tony Lindgren
2014-02-28 22:38 ` Tony Lindgren
2014-03-01 20:07 ` Christoph Fritz
2014-03-01 20:07 ` Christoph Fritz
[not found] ` <1392387656-15186-1-git-send-email-chf.fritz-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2014-02-14 14:20 ` [PATCH v4 4/4] ARM: OMAP2+: Add pdata quirk for sys_clkout2 " Christoph Fritz
2014-02-14 14:20 ` Christoph Fritz
2014-02-28 22:37 ` Tony Lindgren
2014-02-28 22:37 ` Tony Lindgren
2014-03-05 13:07 ` Tero Kristo
2014-03-05 13:07 ` Tero Kristo
2014-03-05 13:25 ` Christoph Fritz [this message]
2014-03-05 13:25 ` Christoph Fritz
2014-03-05 17:21 ` Tony Lindgren
2014-03-05 17:21 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394025932.16566.44.camel@mars \
--to=chf.fritz@googlemail.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=javier.martinez@collabora.co.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=t-kristo@ti.com \
--cc=tomi.valkeinen@ti.com \
--cc=tony@atomide.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.