All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
	Geert Uytterhoeven
	<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Subject: Re: [PATCH 2/5] i2c: emev2: add binding documentation
Date: Tue, 07 Jul 2015 22:47:32 +0300	[thread overview]
Message-ID: <13947160.RNzBrc1uk4@avalon> (raw)
In-Reply-To: <20150707194313.GB1572@katana>

Hi Wolfram,

On Tuesday 07 July 2015 21:43:13 Wolfram Sang wrote:
> > > +Device tree configuration for Renesas EMEV2 IIC driver
> > 
> > s/driver/controller/
> 
> Yes,
> 
> > > +- interrupts      : 1 interrupt
> > 
> > I'd write this as "specifier for the IIC controller interrupt".
> 
> Yes.
> 
> > > +- clocks          : phandle to the IP core SCLK
> > 
> > The datasheet mentions PCLK and IIC_SCLK but doesn't provide details. Do
> > you have more information ?
> 
> I follow what is done for the other EMEV2 IP cores currently supported.
> All cores I checked have PCLK and SCLK but only SCLK is referenced in
> the DTS.

Could you briefly explain what the two clocks are for ? Or point me to the 
right documentation ?

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Simon Horman <horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
	Geert Uytterhoeven
	<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Subject: Re: [PATCH 2/5] i2c: emev2: add binding documentation
Date: Tue, 07 Jul 2015 19:47:32 +0000	[thread overview]
Message-ID: <13947160.RNzBrc1uk4@avalon> (raw)
In-Reply-To: <20150707194313.GB1572@katana>

Hi Wolfram,

On Tuesday 07 July 2015 21:43:13 Wolfram Sang wrote:
> > > +Device tree configuration for Renesas EMEV2 IIC driver
> > 
> > s/driver/controller/
> 
> Yes,
> 
> > > +- interrupts      : 1 interrupt
> > 
> > I'd write this as "specifier for the IIC controller interrupt".
> 
> Yes.
> 
> > > +- clocks          : phandle to the IP core SCLK
> > 
> > The datasheet mentions PCLK and IIC_SCLK but doesn't provide details. Do
> > you have more information ?
> 
> I follow what is done for the other EMEV2 IP cores currently supported.
> All cores I checked have PCLK and SCLK but only SCLK is referenced in
> the DTS.

Could you briefly explain what the two clocks are for ? Or point me to the 
right documentation ?

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2015-07-07 19:47 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-06 21:46 [PATCH 0/5] enable I2C on Renesas EMEV2 and KZM9D board Wolfram Sang
2015-07-06 21:46 ` Wolfram Sang
2015-07-06 21:46 ` [PATCH 1/5] clk: shmobile: emev2: deassert reset for IIC0/1 Wolfram Sang
2015-07-06 21:46   ` Wolfram Sang
2015-07-06 21:57   ` Stephen Boyd
2015-07-06 21:57     ` Stephen Boyd
2015-07-06 21:46 ` [PATCH 2/5] i2c: emev2: add binding documentation Wolfram Sang
2015-07-06 21:46   ` Wolfram Sang
2015-07-07  8:41   ` Geert Uytterhoeven
2015-07-07  8:41     ` Geert Uytterhoeven
2015-07-07  9:17     ` Wolfram Sang
2015-07-07  9:17       ` Wolfram Sang
2015-07-07  9:22       ` Geert Uytterhoeven
2015-07-07  9:22         ` Geert Uytterhoeven
2015-07-07 17:26   ` Laurent Pinchart
2015-07-07 17:26     ` Laurent Pinchart
2015-07-07 19:43     ` Wolfram Sang
2015-07-07 19:43       ` Wolfram Sang
2015-07-07 19:47       ` Laurent Pinchart [this message]
2015-07-07 19:47         ` Laurent Pinchart
2015-07-07 19:53         ` Wolfram Sang
2015-07-07 19:53           ` Wolfram Sang
2015-07-09  0:35           ` Laurent Pinchart
2015-07-09  0:35             ` Laurent Pinchart
2015-07-09 15:20             ` Wolfram Sang
2015-07-09 15:20               ` Wolfram Sang
2015-07-06 21:46 ` [PATCH 4/5] ARM: shmobile: emev2: add IIC cores to dtsi Wolfram Sang
2015-07-06 21:46   ` Wolfram Sang
     [not found] ` <1436219188-4325-1-git-send-email-wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
2015-07-06 21:46   ` [PATCH 3/5] i2c: emev2: add driver Wolfram Sang
2015-07-06 21:46     ` Wolfram Sang
2015-07-07 18:40     ` Laurent Pinchart
2015-07-07 18:40       ` Laurent Pinchart
2015-07-07 19:49       ` Wolfram Sang
2015-07-07 19:49         ` Wolfram Sang
2015-07-06 21:46   ` [PATCH 5/5] ARM: shmobile: emev2: kzm9d: enable IIC busses Wolfram Sang
2015-07-06 21:46     ` Wolfram Sang
2015-07-07  8:38   ` [PATCH 0/5] enable I2C on Renesas EMEV2 and KZM9D board Geert Uytterhoeven
2015-07-07  8:38     ` Geert Uytterhoeven
     [not found]     ` <CAMuHMdUwivjTgj-nOKnHhmmU2po0JMPDhHqW6z7ngiO-D+a6iA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-07  9:10       ` Wolfram Sang
2015-07-07  9:10         ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13947160.RNzBrc1uk4@avalon \
    --to=laurent.pinchart-rylnwiuwjnjg/c1bvhzhaw@public.gmane.org \
    --cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
    --cc=horms-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.