All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 1/2] cfg80211/mac80211: ignore signal if the frame was heard on wrong channel
Date: Wed, 19 Mar 2014 15:15:28 +0100	[thread overview]
Message-ID: <1395238528.4142.17.camel@jlt4.sipsolutions.net> (raw)
In-Reply-To: <1393944614-4465-1-git-send-email-emmanuel.grumbach@intel.com>

On Tue, 2014-03-04 at 16:50 +0200, Emmanuel Grumbach wrote:
> On 2.4Ghz band, the channels overlap since the delta
> between different channels is 5Mhz while the width of the
> receiver is 20Mhz (at least).
> 
> This means that we can hear beacons or probe responses from
> adjacent channels. These frames will have a significant
> lower RSSI which will feed all kinds of logic with inaccurate
> data. An obvious example is the roaming algorithm that will
> think our AP is getting weak and will try to move to another
> AP.
> 
> In order to avoid this, update the signal only if the frame
> has been heard on the same channel as the one advertised by
> the AP in its DS / HT IEs.
> We refrain from updating the values only if the AP is
> already in the BSS list so that we will still have a valid
> (but inaccurate) value if the AP was heard on an adjacent
> channel only.
> 
> To achieve this, stop taking the channel from DS / HT IEs
> in mac80211. The DS / HT IEs is taken into account to
> discard the frame if it was received on a disabled channel.
> This can happen due to the same phenomenon: the frame is
> sent on channel 12, but heard on channel 11 while channel
> 12 can be disabled on certain devices. Since this check
> is done in cfg80211, stop even checking this in mac80211.

Applied, I removed a dead variable (rx_freq)

johannes


      parent reply	other threads:[~2014-03-19 14:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-04 14:50 [PATCH 1/2] cfg80211/mac80211: ignore signal if the frame was heard on wrong channel Emmanuel Grumbach
2014-03-04 14:50 ` [PATCH 2/2] mac80211: ignore probe response from adjacent channels Emmanuel Grumbach
2014-03-05  9:08   ` Jouni Malinen
2014-03-05  9:16     ` Grumbach, Emmanuel
2014-03-05 10:51       ` Jouni Malinen
2014-03-05  9:20     ` Grumbach, Emmanuel
2014-03-05 10:54       ` Jouni Malinen
2014-03-05 11:00         ` Grumbach, Emmanuel
2014-03-05 11:20         ` Grumbach, Emmanuel
2014-03-19 14:15 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395238528.4142.17.camel@jlt4.sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=emmanuel.grumbach@intel.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.