From: Jouni Malinen <j@w1.fi>
To: "Grumbach, Emmanuel" <emmanuel.grumbach@intel.com>
Cc: "johannes@sipsolutions.net" <johannes@sipsolutions.net>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] mac80211: ignore probe response from adjacent channels
Date: Wed, 5 Mar 2014 12:54:22 +0200 [thread overview]
Message-ID: <20140305105422.GB32093@w1.fi> (raw)
In-Reply-To: <0BA3FCBA62E2DC44AF3030971E174FB303D7871D@HASMSX103.ger.corp.intel.com>
On Wed, Mar 05, 2014 at 09:20:07AM +0000, Grumbach, Emmanuel wrote:
> > So I guess you want me to revert the code we currently have in
> > ieee80211_rx_mgmt_beacon ;) Don't know really... If you are associated to
> > an AP and hear its beacons / probe responses on another channel you really
> > have a big problem in your radio?
>
> FWIW: this logic is there since:
>
> commit d91f36db51661018f6d54ff5966e283bcec4c545
> Author: Johannes Berg <johannes@sipsolutions.net>
> Date: Thu Apr 16 13:17:26 2009 +0200
>
> mac80211: implement beacon filtering in software
The frequency related areas in this commit are in a location that has a
clear comment about it being for the current BSS. Your patch did not
look like it would be for that case. If it is, the commit log should
really say that clearly.
--
Jouni Malinen PGP id EFC895FA
next prev parent reply other threads:[~2014-03-05 10:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 14:50 [PATCH 1/2] cfg80211/mac80211: ignore signal if the frame was heard on wrong channel Emmanuel Grumbach
2014-03-04 14:50 ` [PATCH 2/2] mac80211: ignore probe response from adjacent channels Emmanuel Grumbach
2014-03-05 9:08 ` Jouni Malinen
2014-03-05 9:16 ` Grumbach, Emmanuel
2014-03-05 10:51 ` Jouni Malinen
2014-03-05 9:20 ` Grumbach, Emmanuel
2014-03-05 10:54 ` Jouni Malinen [this message]
2014-03-05 11:00 ` Grumbach, Emmanuel
2014-03-05 11:20 ` Grumbach, Emmanuel
2014-03-19 14:15 ` [PATCH 1/2] cfg80211/mac80211: ignore signal if the frame was heard on wrong channel Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305105422.GB32093@w1.fi \
--to=j@w1.fi \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.