All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Widawsky <benjamin.widawsky@linux.intel.com>
To: Intel GFX <intel-gfx@lists.freedesktop.org>
Cc: stable@vger.kernel.org
Subject: [PATCH 06/12] drm/i915: Add a partial instruction shootdown workaround on Broadwell.
Date: Fri, 21 Mar 2014 11:48:15 -0700	[thread overview]
Message-ID: <1395427701-13434-7-git-send-email-benjamin.widawsky@linux.intel.com> (raw)
In-Reply-To: <1395427701-13434-1-git-send-email-benjamin.widawsky@linux.intel.com>

From: Kenneth Graunke <kenneth@whitecape.org>

I believe this will be necessary on production hardware.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Ben Widawsky <ben@bwidawsk.net>
[danvet: Fix whitespace fail spotted by checkpatch. Also add missing
:bdw w/a tag that Ville spotted.]
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
[BDW 3.14 backport]
Cc: stable@vger.kernel.org
Signed-off-by: Ben Widawsky <ben@bwidawsk.net>

Conflicts:
	drivers/gpu/drm/i915/intel_pm.c
---
 drivers/gpu/drm/i915/i915_reg.h | 3 +++
 drivers/gpu/drm/i915/intel_pm.c | 4 ++++
 2 files changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index db70031..cb9ff13 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -5012,6 +5012,9 @@
 #define   GEN7_SINGLE_SUBSCAN_DISPATCH_ENABLE	(1<<10)
 #define   GEN7_PSD_SINGLE_PORT_DISPATCH_ENABLE	(1<<3)
 
+#define GEN8_ROW_CHICKEN		0xe4f0
+#define   PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE	(1<<8)
+
 #define GEN7_ROW_CHICKEN2		0xe4f4
 #define GEN7_ROW_CHICKEN2_GT2		0xf4f4
 #define   DOP_CLOCK_GATING_DISABLE	(1<<0)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index a0c6add..a7e5669 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -4713,6 +4713,10 @@ static void gen8_init_clock_gating(struct drm_device *dev)
 
 	WARN(!i915_preliminary_hw_support,
 	     "GEN8_CENTROID_PIXEL_OPT_DIS not be needed for production\n");
+	/* WaDisablePartialInstShootdown:bdw */
+	I915_WRITE(GEN8_ROW_CHICKEN,
+		   _MASKED_BIT_ENABLE(PARTIAL_INSTRUCTION_SHOOTDOWN_DISABLE));
+
 	I915_WRITE(HALF_SLICE_CHICKEN3,
 		   _MASKED_BIT_ENABLE(GEN8_CENTROID_PIXEL_OPT_DIS));
 	I915_WRITE(HALF_SLICE_CHICKEN3,
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2014-03-21 18:48 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-21 18:48 [PATCH 00/12] Broadwell 3.14 backports Ben Widawsky
2014-03-21 18:48 ` [PATCH 01/12] drm/i915: Fix forcewake counts for gen8 Ben Widawsky
2014-03-21 18:48 ` [PATCH 02/12] drm/i915: Do forcewake reset on gen8 Ben Widawsky
2014-03-21 18:48 ` [PATCH 03/12] drm/i915: Disable semaphore wait event idle message on BDW Ben Widawsky
2014-03-21 18:48 ` [PATCH 04/12] drm/i915: Implement WaDisableSDEUnitClockGating:bdw Ben Widawsky
2014-03-21 18:48 ` [PATCH 05/12] drm/i915: We implement WaDisableAsyncFlipPerfMode:bdw Ben Widawsky
2014-03-21 18:48 ` Ben Widawsky [this message]
2014-03-21 18:48 ` [PATCH 07/12] drm/i915: Add thread stall DOP clock gating workaround on Broadwell Ben Widawsky
2014-03-21 18:48 ` [PATCH 08/12] drm/i915/bdw: The TLB invalidation mechanism has been removed from INSTPM Ben Widawsky
2014-03-21 18:48 ` [PATCH 09/12] drm/i915: Don't clobber CHICKEN_PIPESL_1 on BDW Ben Widawsky
2014-03-21 18:48 ` [PATCH 10/12] drm/i915: don't flood the logs about bdw semaphores Ben Widawsky
2014-03-21 22:06   ` [PATCH 10/12] [v2] " Ben Widawsky
2014-03-21 18:48 ` [PATCH 11/12] drm/i915/bdw: Use scratch page table for GEN8 PPGTT Ben Widawsky
2014-03-21 18:48 ` [PATCH 12/12] drm/i915/bdw: Restore PPAT on thaw Ben Widawsky
2014-03-21 19:49 ` [PATCH 00/12] Broadwell 3.14 backports Daniel Vetter
2014-03-21 22:14   ` Ben Widawsky
2014-03-21 23:47     ` Greg KH
2014-03-22  0:06       ` Ben Widawsky
2014-03-22  0:17         ` Ben Widawsky
2014-03-22 11:29           ` Daniel Vetter
2014-03-22  0:51 ` Ben Widawsky
2014-03-22 11:34   ` Daniel Vetter
2014-03-24 23:14     ` Ausmus, James
2014-03-24 23:17       ` Ben Widawsky
2014-03-25  9:43         ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395427701-13434-7-git-send-email-benjamin.widawsky@linux.intel.com \
    --to=benjamin.widawsky@linux.intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.